Title: fix(sdk): Encode channelId in Teams deep-link URL · Issue #771 · github/squad · GitHub
Open Graph Title: fix(sdk): Encode channelId in Teams deep-link URL · Issue #771 · github/squad
X Title: fix(sdk): Encode channelId in Teams deep-link URL · Issue #771 · github/squad
Description: Context PR #768 added validateGraphId() to encode user-controlled IDs in Graph API URLs. However, channelId is used unvalidated in the Teams deep-link URL: url: \https://teams.microsoft.com/l/channel/\\ The Graph API call above it valida...
Open Graph Description: Context PR #768 added validateGraphId() to encode user-controlled IDs in Graph API URLs. However, channelId is used unvalidated in the Teams deep-link URL: url: \https://teams.microsoft.com/l/chann...
X Description: Context PR #768 added validateGraphId() to encode user-controlled IDs in Graph API URLs. However, channelId is used unvalidated in the Teams deep-link URL: url: \https://teams.microsoft.com/l/chann...
Opengraph URL: https://github.com/github/squad/issues/771
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fix(sdk): Encode channelId in Teams deep-link URL","articleBody":"## Context\n\nPR #768 added `validateGraphId()` to encode user-controlled IDs in Graph API URLs. However, `channelId` is used **unvalidated** in the Teams deep-link URL:\n\n```ts\nurl: \\https://teams.microsoft.com/l/channel/\\\\\n```\n\nThe Graph API call above it validates and encodes `channelId`, and `getNotificationUrl` correctly uses `encodeURIComponent` for chat IDs — the channel deep-link should do the same for consistency.\n\n## What to do\n\nApply `encodeURIComponent` to channelId in the deep-link URL in `postUpdate()`.\n\n## Origin\n\nFlagged by RETRO (security review) during PR #768 review — Round 2, Note B.\n\n**Severity:** LOW\n**Related PR:** #768","author":{"url":"https://github.com/diberry","@type":"Person","name":"diberry"},"datePublished":"2026-04-03T00:09:40Z","url":"https://github.com/github/squad/issues/771"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:da11d198-b58d-aa3b-baa5-b01eb1d197e8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 90EC:2E7EBB:1F0694C:273622E:6B016033 |
| html-safe-nonce | 88befbee4cc9788bafd9295c70a16202bc463dfe34b566bea8dfdaa944fcc811 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEVDOjJFN0VCQjoxRjA2OTRDOjI3MzYyMkU6NkIwMTYwMzMiLCJ2aXNpdG9yX2lkIjoiNDI5MDc1Mjk4MTM5NTEzNjU2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3347e09742bd0fe24e114a2e4c74c82f113b950a2bc532896d8810b9254f5db0 |
| hovercard-subject-tag | issue:4197546852 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github/squad/771/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b641923957aecb6ac6d0e0094ba652ede3499434800501835bb350ad9091f6cc/github/squad/issues/771 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b641923957aecb6ac6d0e0094ba652ede3499434800501835bb350ad9091f6cc/github/squad/issues/771 |
| og:image:alt | Context PR #768 added validateGraphId() to encode user-controlled IDs in Graph API URLs. However, channelId is used unvalidated in the Teams deep-link URL: url: \https://teams.microsoft.com/l/chann... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | diberry |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/github/squad git https://github.com/github/squad.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 1151205052 |
| octolytics-dimension-repository_nwo | github/squad |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1151205052 |
| octolytics-dimension-repository_network_root_nwo | github/squad |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width