Title: API.DiffTreeVertexDiffTerm should not be a sum type. · Issue #168 · github/semantic · GitHub
Open Graph Title: API.DiffTreeVertexDiffTerm should not be a sum type. · Issue #168 · github/semantic
X Title: API.DiffTreeVertexDiffTerm should not be a sum type. · Issue #168 · github/semantic
Description: The current definition is an uncomfortable hybrid of a message (a record type) and a field (a sum type): data DiffTreeVertexDiffTerm = Deleted (Maybe DeletedTerm) | Inserted (Maybe InsertedTerm) | Replaced (Maybe ReplacedTerm) | Merged (...
Open Graph Description: The current definition is an uncomfortable hybrid of a message (a record type) and a field (a sum type): data DiffTreeVertexDiffTerm = Deleted (Maybe DeletedTerm) | Inserted (Maybe InsertedTerm) | ...
X Description: The current definition is an uncomfortable hybrid of a message (a record type) and a field (a sum type): data DiffTreeVertexDiffTerm = Deleted (Maybe DeletedTerm) | Inserted (Maybe InsertedTerm) | ...
Opengraph URL: https://github.com/github/semantic/issues/168
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"API.DiffTreeVertexDiffTerm should not be a sum type.","articleBody":"The current definition is an uncomfortable hybrid of a message (a record type) and a field (a sum type):\r\n\r\n```haskell\r\ndata DiffTreeVertexDiffTerm\r\n = Deleted (Maybe DeletedTerm)\r\n | Inserted (Maybe InsertedTerm)\r\n | Replaced (Maybe ReplacedTerm)\r\n | Merged (Maybe MergedTerm)\r\n deriving stock (Eq, Ord, Show, Generic)\r\n deriving anyclass (Proto3.Message, Proto3.Named, NFData)\r\n```\r\n\r\nTo abide by protobuf standards, this should be closer to\r\n\r\n```haskell\r\ndata DiffTreeVertexDiffTerm = DiffTreeVertexDiffTerm\r\n { deleted :: Maybe DeletedTerm\r\n , inserted :: Maybe InsertedTerm\r\n , replaced :: Maybe ReplacedTerm\r\n , merged :: Maybe MergedTerm\r\n }\r\n```\r\n\r\nwhich is much closer to the actual protobuf definition:\r\n\r\n```proto\r\n oneof diff_term {\r\n DeletedTerm deleted = 2;\r\n InsertedTerm inserted = 3;\r\n ReplacedTerm replaced = 4;\r\n MergedTerm merged = 5;\r\n }\r\n```","author":{"url":"https://github.com/patrickt","@type":"Person","name":"patrickt"},"datePublished":"2019-06-19T22:38:39Z","url":"https://github.com/github/semantic/issues/168"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b1a31450-ae89-7acb-d2bd-1e2663ee9649 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 804A:31E99C:2707CBC:341F8E1:6B01AC79 |
| html-safe-nonce | fedb0eac905c49453ac445675584c6d9477a508851e3961b205ba59044a417c5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDRBOjMxRTk5QzoyNzA3Q0JDOjM0MUY4RTE6NkIwMUFDNzkiLCJ2aXNpdG9yX2lkIjoiNzc2OTgzMTQyMzUxMDQyNDY5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ed6d50936d52e7673447c26ecd75ff8b9f8dac1aa6ac9218b649607007340cd0 |
| hovercard-subject-tag | issue:458256432 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github/semantic/168/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8679cc06bd21e0deb2a91e575dc39544fd9510ac47c1107a8cbc5a1480122e25/github/semantic/issues/168 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8679cc06bd21e0deb2a91e575dc39544fd9510ac47c1107a8cbc5a1480122e25/github/semantic/issues/168 |
| og:image:alt | The current definition is an uncomfortable hybrid of a message (a record type) and a field (a sum type): data DiffTreeVertexDiffTerm = Deleted (Maybe DeletedTerm) | Inserted (Maybe InsertedTerm) | ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | patrickt |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/github/semantic git https://github.com/github/semantic.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 175839913 |
| octolytics-dimension-repository_nwo | github/semantic |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 175839913 |
| octolytics-dimension-repository_network_root_nwo | github/semantic |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width