René's URL Explorer Experiment


Title: Remove source expression deduplication. by lgarron · Pull Request #499 · github/secure_headers · GitHub

Open Graph Title: Remove source expression deduplication. by lgarron · Pull Request #499 · github/secure_headers

X Title: Remove source expression deduplication. by lgarron · Pull Request #499 · github/secure_headers

Description: This PR removes dedup_source_list and replaces it with a simple .uniq call. This resolves #491, which is only the latest in a series of ongoing issues with source expression deduplication. secure_h...

Open Graph Description: This PR removes dedup_source_list and replaces it with a simple .uniq call. This resolves #491, which is only the latest in a series of ongoing issues with source expression deduplication. secure_h...

X Description: This PR removes dedup_source_list and replaces it with a simple .uniq call. This resolves #491, which is only the latest in a series of ongoing issues with source expression deduplication. secure_h...

Opengraph URL: https://github.com/github/secure_headers/pull/499

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:691c0067-fdd4-715e-50c8-333ca54abb98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7F2:194F15:1DD6527:28C76B8:6964C78D
html-safe-nonceb60e86f2a5102ec9c940203fabfe322e0d7e1967c85d17f57b1b2264d0bdd382
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0YyOjE5NEYxNToxREQ2NTI3OjI4Qzc2Qjg6Njk2NEM3OEQiLCJ2aXNpdG9yX2lkIjoiNDIwOTc5MTkwMjk0NTY5MTUzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ee8d4cba1d290f407ebdcb898904ce1e6ce642795ca234796be555902b97939
hovercard-subject-tagpull_request:1092685057
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/secure_headers/499/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/75a07e119a21979bdf22e079cd63de56b673925b4a1ea975f5421e80ad11dc34/github/secure_headers/pull/499
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/75a07e119a21979bdf22e079cd63de56b673925b4a1ea975f5421e80ad11dc34/github/secure_headers/pull/499
og:image:altThis PR removes dedup_source_list and replaces it with a simple .uniq call. This resolves #491, which is only the latest in a series of ongoing issues with source expression deduplication. secure_h...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelgarron
hostnamegithub.com
expected-hostnamegithub.com
None21df671ce2c9f1a16940ccbd3af6cb4f3f12a856929ca7eb1b4aea8e384ea442
turbo-cache-controlno-preview
go-importgithub.com/github/secure_headers git https://github.com/github/secure_headers.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id7122663
octolytics-dimension-repository_nwogithub/secure_headers
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7122663
octolytics-dimension-repository_network_root_nwogithub/secure_headers
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5707c685ac172d50a0bdd7533dde4f8aabcf8eef
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/secure_headers/pull/499#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fsecure_headers%2Fpull%2F499
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fsecure_headers%2Fpull%2F499
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fsecure_headers
Reloadhttps://github.com/github/secure_headers/pull/499
Reloadhttps://github.com/github/secure_headers/pull/499
Reloadhttps://github.com/github/secure_headers/pull/499
github https://github.com/github
secure_headershttps://github.com/github/secure_headers
Notifications https://github.com/login?return_to=%2Fgithub%2Fsecure_headers
Fork 253 https://github.com/login?return_to=%2Fgithub%2Fsecure_headers
Star 3.3k https://github.com/login?return_to=%2Fgithub%2Fsecure_headers
Code https://github.com/github/secure_headers
Issues 14 https://github.com/github/secure_headers/issues
Pull requests 7 https://github.com/github/secure_headers/pulls
Actions https://github.com/github/secure_headers/actions
Projects 0 https://github.com/github/secure_headers/projects
Models https://github.com/github/secure_headers/models
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/github/secure_headers/security
Please reload this pagehttps://github.com/github/secure_headers/pull/499
Insights https://github.com/github/secure_headers/pulse
Code https://github.com/github/secure_headers
Issues https://github.com/github/secure_headers/issues
Pull requests https://github.com/github/secure_headers/pulls
Actions https://github.com/github/secure_headers/actions
Projects https://github.com/github/secure_headers/projects
Models https://github.com/github/secure_headers/models
Security https://github.com/github/secure_headers/security
Insights https://github.com/github/secure_headers/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fsecure_headers%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fsecure_headers%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/github/secure_headers/pull/499#issue-comment-box
lgarronhttps://github.com/lgarron
mainhttps://github.com/github/secure_headers/tree/main
lgarron/remove-source-expression-deduphttps://github.com/github/secure_headers/tree/lgarron/remove-source-expression-dedup
Remove source expression deduplication. https://github.com/github/secure_headers/pull/499#top
lgarronhttps://github.com/lgarron
mainhttps://github.com/github/secure_headers/tree/main
lgarron/remove-source-expression-deduphttps://github.com/github/secure_headers/tree/lgarron/remove-source-expression-dedup
Conversation 0 https://github.com/github/secure_headers/pull/499
Commits 3 https://github.com/github/secure_headers/pull/499/commits
Checks 0 https://github.com/github/secure_headers/pull/499/checks
Files changed https://github.com/github/secure_headers/pull/499/files
Please reload this pagehttps://github.com/github/secure_headers/pull/499
https://github.co/hiddenchars
https://github.com/github/secure_headers/pull/{{ revealButtonHref }}
https://github.com/lgarron
lgarronhttps://github.com/lgarron
Oct 19, 2022https://github.com/github/secure_headers/pull/499#issue-1415361982
Please reload this pagehttps://github.com/github/secure_headers/pull/499
#491https://github.com/github/secure_headers/issues/491
since 2015https://github.com/github/secure_headers/commit/32bb3f51e8d877baf1e3e4461663ae0b7b1347c0
deduplicates redundant URL source expressionshttps://github.com/github/secure_headers/blob/494b75ff927464ed8d1c43e98e41fe4d15ce2bdf/lib/secure_headers/headers/content_security_policy.rb#L157-L170
directivehttps://w3c.github.io/webappsec-csp/#framework-directives
URIhttps://docs.ruby-lang.org/en/2.1.0/URI.html
1https://github.com/github/secure_headers/pull/499#user-content-fn-1-be0ec9c83fda81bd8abfc4a7325fc9ef
File.fnmatchhttps://apidock.com/ruby/v2_5_5/File/fnmatch/class
2https://github.com/github/secure_headers/pull/499#user-content-fn-2-be0ec9c83fda81bd8abfc4a7325fc9ef
bug was reported and confirmedhttps://github.com/github/secure_headers/issues/317
fixed by @keithamus (a Hubber) in 2022https://github.com/github/secure_headers/pull/478
new bughttps://github.com/github/secure_headers/issues/491
submitted a fix for the bew bughttps://github.com/github/secure_headers/pull/490
drafted a new implementationhttps://github.com/github/secure_headers/pull/498
introduced by @oreoshake (the then-maintainer) without explanation in 2015https://github.com/github/secure_headers/commit/32bb3f51e8d877baf1e3e4461663ae0b7b1347c0
saidhttps://github.com/github/secure_headers/issues/317#issuecomment-283431124
fix source dedup breaking with port wildcards #490https://github.com/github/secure_headers/pull/490
Semantically parse and deduplicate source expressions #498https://github.com/github/secure_headers/pull/498
↩https://github.com/github/secure_headers/pull/499#user-content-fnref-1-be0ec9c83fda81bd8abfc4a7325fc9ef
↩https://github.com/github/secure_headers/pull/499#user-content-fnref-2-be0ec9c83fda81bd8abfc4a7325fc9ef
Please reload this pagehttps://github.com/github/secure_headers/pull/499
https://github.com/vcsjones
vcsjoneshttps://github.com/vcsjones
Oct 21, 2022 https://github.com/github/secure_headers/pull/499#pullrequestreview-1151074217
View reviewed changes https://github.com/github/secure_headers/pull/499/files
https://github.com/lgarron
lgarronhttps://github.com/lgarron
Oct 24, 2022 https://github.com/github/secure_headers/pull/499#ref-pullrequest-1421210643
CI changes: run on push, drop Ruby 2.5 #500 https://github.com/github/secure_headers/pull/500
lgarronhttps://github.com/lgarron
October 24, 2022 11:01https://github.com/github/secure_headers/pull/499#commits-pushed-af92ce6
https://github.com/lgarron
Add a regression test for a current bug.https://github.com/github/secure_headers/pull/499/commits/af92ce6f09ed96fbad8836eae8739b0191b25dd5
af92ce6https://github.com/github/secure_headers/pull/499/commits/af92ce6f09ed96fbad8836eae8739b0191b25dd5
https://github.com/lgarron
Remove dedup_source_list and replace with a "best-effort" .uniq c…https://github.com/github/secure_headers/pull/499/commits/cdb40e5b851d56b479892b521cd9eb0b1b1a6a83
cdb40e5https://github.com/github/secure_headers/pull/499/commits/cdb40e5b851d56b479892b521cd9eb0b1b1a6a83
https://github.com/lgarron
Update tests.https://github.com/github/secure_headers/pull/499/commits/cd73b021880bb368317b780ed6ac6d1841462574
cd73b02https://github.com/github/secure_headers/pull/499/commits/cd73b021880bb368317b780ed6ac6d1841462574
https://github.com/lgarron
lgarronhttps://github.com/lgarron
force-pushedhttps://github.com/github/secure_headers/compare/8097494c07d9e3de4c696477a4bc493ac218e356..70af13bbae7d3540814ca1f5bf0abe913e165621
8097494https://github.com/github/secure_headers/commit/8097494c07d9e3de4c696477a4bc493ac218e356
70af13bhttps://github.com/github/secure_headers/commit/70af13bbae7d3540814ca1f5bf0abe913e165621
Compare https://github.com/github/secure_headers/compare/8097494c07d9e3de4c696477a4bc493ac218e356..70af13bbae7d3540814ca1f5bf0abe913e165621
October 24, 2022 18:01https://github.com/github/secure_headers/pull/499#event-7656314662
https://github.com/lgarron
lgarronhttps://github.com/lgarron
October 24, 2022 18:01https://github.com/github/secure_headers/pull/499#event-7656317827
https://github.com/lgarron
lgarronhttps://github.com/lgarron
force-pushedhttps://github.com/github/secure_headers/compare/70af13bbae7d3540814ca1f5bf0abe913e165621..cd73b021880bb368317b780ed6ac6d1841462574
70af13bhttps://github.com/github/secure_headers/commit/70af13bbae7d3540814ca1f5bf0abe913e165621
cd73b02https://github.com/github/secure_headers/commit/cd73b021880bb368317b780ed6ac6d1841462574
Compare https://github.com/github/secure_headers/compare/70af13bbae7d3540814ca1f5bf0abe913e165621..cd73b021880bb368317b780ed6ac6d1841462574
October 24, 2022 18:01https://github.com/github/secure_headers/pull/499#event-7656319674
https://github.com/KyFaSt
KyFaSthttps://github.com/KyFaSt
Oct 24, 2022 https://github.com/github/secure_headers/pull/499#pullrequestreview-1153627094
View reviewed changes https://github.com/github/secure_headers/pull/499/files/cd73b021880bb368317b780ed6ac6d1841462574
October 24, 2022 19:01https://github.com/github/secure_headers/pull/499#event-7656730447
lgarronhttps://github.com/lgarron
Oct 24, 2022 https://github.com/github/secure_headers/pull/499#ref-commit-a488b4d
https://github.com/lgarron
CI changes: run on push, drop Ruby 2.5 (https://github.com/github/secure_headers/commit/a488b4d5ec3546e43ae0fe65b43c15fa562d8ef8
#500https://github.com/github/secure_headers/pull/500
)https://github.com/github/secure_headers/commit/a488b4d5ec3546e43ae0fe65b43c15fa562d8ef8
a488b4dhttps://github.com/github/secure_headers/commit/a488b4d5ec3546e43ae0fe65b43c15fa562d8ef8
#499https://github.com/github/secure_headers/pull/499
https://github.com/lgarron
lgarronhttps://github.com/lgarron
b6ef2edhttps://github.com/github/secure_headers/commit/b6ef2ed67a4220291f2144afed2143f445de1f9a
Oct 24, 2022https://github.com/github/secure_headers/pull/499#event-7656741953
https://github.com/lgarron
lgarronhttps://github.com/lgarron
October 24, 2022 19:03https://github.com/github/secure_headers/pull/499#event-7656742077
lgarronhttps://github.com/lgarron
Oct 24, 2022 https://github.com/github/secure_headers/pull/499#ref-commit-5b12e41
https://github.com/lgarron
v6.5.0https://github.com/github/secure_headers/commit/5b12e41a189651f626ea260bfe9c6202e842c25e
5b12e41https://github.com/github/secure_headers/commit/5b12e41a189651f626ea260bfe9c6202e842c25e
@lgarronhttps://github.com/lgarron
#499https://github.com/github/secure_headers/pull/499
https://github.com/lgarron
lgarronhttps://github.com/lgarron
Oct 24, 2022 https://github.com/github/secure_headers/pull/499#ref-pullrequest-1421289397
v6.5.0 #501 https://github.com/github/secure_headers/pull/501
lgarronhttps://github.com/lgarron
Oct 24, 2022 https://github.com/github/secure_headers/pull/499#ref-commit-3adb9ba
https://github.com/lgarron
v6.5.0https://github.com/github/secure_headers/commit/3adb9ba26c1a648f3c6c3c7755cab1c3e1b89371
3adb9bahttps://github.com/github/secure_headers/commit/3adb9ba26c1a648f3c6c3c7755cab1c3e1b89371
@lgarronhttps://github.com/lgarron
#499https://github.com/github/secure_headers/pull/499
lgarronhttps://github.com/lgarron
Oct 24, 2022 https://github.com/github/secure_headers/pull/499#ref-commit-0678a74
https://github.com/lgarron
v6.5.0 (https://github.com/github/secure_headers/commit/0678a7405ed28d83facde598e2e50914b27a6d3e
#501https://github.com/github/secure_headers/pull/501
)https://github.com/github/secure_headers/commit/0678a7405ed28d83facde598e2e50914b27a6d3e
0678a74https://github.com/github/secure_headers/commit/0678a7405ed28d83facde598e2e50914b27a6d3e
@lgarronhttps://github.com/lgarron
#499https://github.com/github/secure_headers/pull/499
fix source dedup breaking with port wildcards #490 https://github.com/github/secure_headers/pull/490
Semantically parse and deduplicate source expressions #498 https://github.com/github/secure_headers/pull/498
https://github.com/lgarron
lgarronhttps://github.com/lgarron
Jan 3, 2023 https://github.com/github/secure_headers/pull/499#ref-issue-211123307
Source Deduplication Doesn't Take Schemes into Account #317 https://github.com/github/secure_headers/issues/317
fletchto99https://github.com/fletchto99
Dec 16, 2025 https://github.com/github/secure_headers/pull/499#ref-commit-a4a4b1b
https://github.com/fletchto99
Fix tests (sources are no longer minified sincehttps://github.com/github/secure_headers/commit/a4a4b1b927534c45085864eb631f7c53bbca32c3
#499https://github.com/github/secure_headers/pull/499
)https://github.com/github/secure_headers/commit/a4a4b1b927534c45085864eb631f7c53bbca32c3
a4a4b1bhttps://github.com/github/secure_headers/commit/a4a4b1b927534c45085864eb631f7c53bbca32c3
rei-moohttps://github.com/rei-moo
Dec 16, 2025 https://github.com/github/secure_headers/pull/499#ref-commit-407d8f8
https://github.com/fletchto99
https://github.com/rei-moo
Fix tests (sources are no longer minified sincehttps://github.com/github/secure_headers/commit/407d8f83e2ac0967fcc89fa6ab970685788a5559
#499https://github.com/github/secure_headers/pull/499
)https://github.com/github/secure_headers/commit/407d8f83e2ac0967fcc89fa6ab970685788a5559
407d8f8https://github.com/github/secure_headers/commit/407d8f83e2ac0967fcc89fa6ab970685788a5559
rei-moohttps://github.com/rei-moo
Dec 16, 2025 https://github.com/github/secure_headers/pull/499#ref-commit-fa4298e
https://github.com/fletchto99
https://github.com/rei-moo
Fix tests (sources are no longer minified sincehttps://github.com/github/secure_headers/commit/fa4298e258e877064f5cb0924f8dd8cb898dc9be
#499https://github.com/github/secure_headers/pull/499
)https://github.com/github/secure_headers/commit/fa4298e258e877064f5cb0924f8dd8cb898dc9be
fa4298ehttps://github.com/github/secure_headers/commit/fa4298e258e877064f5cb0924f8dd8cb898dc9be
rei-moohttps://github.com/rei-moo
Dec 17, 2025 https://github.com/github/secure_headers/pull/499#ref-commit-7f19fb2
https://github.com/fletchto99
https://github.com/rei-moo
Fix tests (sources are no longer minified sincehttps://github.com/github/secure_headers/commit/7f19fb27a9c437e75976f40fab2ad0bf6c81f793
#499https://github.com/github/secure_headers/pull/499
)https://github.com/github/secure_headers/commit/7f19fb27a9c437e75976f40fab2ad0bf6c81f793
7f19fb2https://github.com/github/secure_headers/commit/7f19fb27a9c437e75976f40fab2ad0bf6c81f793
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fsecure_headers%2Fpull%2F499
https://github.com/vcsjones
vcsjones https://github.com/vcsjones
https://github.com/github/secure_headers/pull/499/files/8097494c07d9e3de4c696477a4bc493ac218e356
https://github.com/KyFaSt
KyFaSt https://github.com/KyFaSt
https://github.com/github/secure_headers/pull/499/files/cd73b021880bb368317b780ed6ac6d1841462574
URI::InvalidURIError: Invalid data URI https://github.com/github/secure_headers/issues/491
Please reload this pagehttps://github.com/github/secure_headers/pull/499
https://github.com/lgarron
https://github.com/vcsjones
https://github.com/KyFaSt
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.