René's URL Explorer Experiment


Title: Handle not successful responses by muan · Pull Request #11 · github/remote-input-element · GitHub

Open Graph Title: Handle not successful responses by muan · Pull Request #11 · github/remote-input-element

X Title: Handle not successful responses by muan · Pull Request #11 · github/remote-input-element

Description: An input element that sends its value to a server endpoint and renders the response body. - Handle not successful responses by muan · Pull Request #11 · github/remote-input-element

Open Graph Description: Fixes #10. When response status is not successful (200-299), emits an error event and don't set HTML. cc @arielvalentin

X Description: Fixes #10. When response status is not successful (200-299), emits an error event and don't set HTML. cc @arielvalentin

Opengraph URL: https://github.com/github/remote-input-element/pull/11

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:34ef4114-a7fa-cfe4-471b-9bfd6a5a0072
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB54A:FE611:8AECDE:BB8E70:6A6111C4
html-safe-nonce8fa2240e57ebdb04ec9fd1d410af2492eaafadb6fa0ea4ee4de8190f2230dc71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTRBOkZFNjExOjhBRUNERTpCQjhFNzA6NkE2MTExQzQiLCJ2aXNpdG9yX2lkIjoiNDQ4NTkwNTMwNDQ5MzU2MDI2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac687bc1c2cf7a281a294073761839bb22cb159cd94a8981b5200cca3635a8e3fb
hovercard-subject-tagpull_request:316059681
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/remote-input-element/11/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/98a359b4ff6b7d05cfe049138b6f0ede3f656b7f2ee047044c9efb911097ce2c/github/remote-input-element/pull/11
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/98a359b4ff6b7d05cfe049138b6f0ede3f656b7f2ee047044c9efb911097ce2c/github/remote-input-element/pull/11
og:image:altFixes #10. When response status is not successful (200-299), emits an error event and don't set HTML. cc @arielvalentin
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemuan
hostnamegithub.com
expected-hostnamegithub.com
Nonef6dfd8e93b1f2b4f7bf96e6f6cd7edcd48360b75fee4f2ff9f611032fce38ec2
turbo-cache-controlno-cache
go-importgithub.com/github/remote-input-element git https://github.com/github/remote-input-element.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id184330306
octolytics-dimension-repository_nwogithub/remote-input-element
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id184330306
octolytics-dimension-repository_network_root_nwogithub/remote-input-element
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release731b2ebd4784c28b421dc5f41abecd2dbac357f2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/remote-input-element/pull/11#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fremote-input-element%2Fpull%2F11
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fremote-input-element%2Fpull%2F11
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fremote-input-element
Reloadhttps://github.com/github/remote-input-element/pull/11
Reloadhttps://github.com/github/remote-input-element/pull/11
Reloadhttps://github.com/github/remote-input-element/pull/11
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
github https://github.com/github
remote-input-elementhttps://github.com/github/remote-input-element
Notifications https://github.com/login?return_to=%2Fgithub%2Fremote-input-element
Fork 14 https://github.com/login?return_to=%2Fgithub%2Fremote-input-element
Star 90 https://github.com/login?return_to=%2Fgithub%2Fremote-input-element
Code https://github.com/github/remote-input-element
Issues 1 https://github.com/github/remote-input-element/issues
Pull requests 0 https://github.com/github/remote-input-element/pulls
Actions https://github.com/github/remote-input-element/actions
Models https://github.com/github/remote-input-element/models
Security and quality 0 https://github.com/github/remote-input-element/security
Insights https://github.com/github/remote-input-element/pulse
Code https://github.com/github/remote-input-element
Issues https://github.com/github/remote-input-element/issues
Pull requests https://github.com/github/remote-input-element/pulls
Actions https://github.com/github/remote-input-element/actions
Models https://github.com/github/remote-input-element/models
Security and quality https://github.com/github/remote-input-element/security
Insights https://github.com/github/remote-input-element/pulse
muanhttps://github.com/muan
masterhttps://github.com/github/remote-input-element/tree/master
not-okhttps://github.com/github/remote-input-element/tree/not-ok
Conversationhttps://github.com/github/remote-input-element/pull/11
Commits6 (6)https://github.com/github/remote-input-element/pull/11/commits
Checkshttps://github.com/github/remote-input-element/pull/11/checks
Files changedhttps://github.com/github/remote-input-element/pull/11/files
Handle not successful responseshttps://github.com/github/remote-input-element/pull/11#top
muanhttps://github.com/muan
masterhttps://github.com/github/remote-input-element/tree/master
not-okhttps://github.com/github/remote-input-element/tree/not-ok
https://github.com/muan
muanhttps://github.com/muan
Sep 10, 2019https://github.com/github/remote-input-element/pull/11#issue-491753545
#10https://github.com/github/remote-input-element/issues/10
@arielvalentinhttps://github.com/arielvalentin
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
muanhttps://github.com/muan
September 10, 2019 11:36https://github.com/github/remote-input-element/pull/11#commits-pushed-2cb6b91
https://github.com/muan
Add test to expect failure handlinghttps://github.com/github/remote-input-element/pull/11/commits/2cb6b91cb35fe024fead063cf23c7dfab5c67acc
2cb6b91https://github.com/github/remote-input-element/pull/11/commits/2cb6b91cb35fe024fead063cf23c7dfab5c67acc
https://github.com/muan
Only append results if response.okhttps://github.com/github/remote-input-element/pull/11/commits/8f5ed49e2a9f2b8a9172decc7210c2457907ce95
8f5ed49https://github.com/github/remote-input-element/pull/11/commits/8f5ed49e2a9f2b8a9172decc7210c2457907ce95
https://github.com/muan
muanhttps://github.com/muan
September 10, 2019 15:41https://github.com/github/remote-input-element/pull/11#event-2622757827
https://github.com/dgraham
dgrahamhttps://github.com/dgraham
Sep 10, 2019 https://github.com/github/remote-input-element/pull/11#pullrequestreview-286261788
View reviewed changes https://github.com/github/remote-input-element/pull/11/files/8f5ed49e2a9f2b8a9172decc7210c2457907ce95
index.jshttps://github.com/github/remote-input-element/pull/11/files/8f5ed49e2a9f2b8a9172decc7210c2457907ce95#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
index.jshttps://github.com/github/remote-input-element/pull/11/files/8f5ed49e2a9f2b8a9172decc7210c2457907ce95#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
index.jshttps://github.com/github/remote-input-element/pull/11/files/8f5ed49e2a9f2b8a9172decc7210c2457907ce95#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
index.jshttps://github.com/github/remote-input-element/pull/11/files/8f5ed49e2a9f2b8a9172decc7210c2457907ce95#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
muanhttps://github.com/muan
September 10, 2019 12:23https://github.com/github/remote-input-element/pull/11#commits-pushed-e2e2dc1
https://github.com/muan
https://github.com/dgraham
Apply suggestions from code reviewhttps://github.com/github/remote-input-element/pull/11/commits/e2e2dc12c02c4f419aa2a1d50da0e05f3626538c
e2e2dc1https://github.com/github/remote-input-element/pull/11/commits/e2e2dc12c02c4f419aa2a1d50da0e05f3626538c
https://github.com/muan
Introduct custom events to not overload network error eventshttps://github.com/github/remote-input-element/pull/11/commits/bf97eec977f3405d51cbf3a5ea67ce63a33f022e
bf97eechttps://github.com/github/remote-input-element/pull/11/commits/bf97eec977f3405d51cbf3a5ea67ce63a33f022e
https://github.com/muan
Add test for custom and network error eventshttps://github.com/github/remote-input-element/pull/11/commits/6e8ae1ef833639986c16202e515270b072ed1b40
6e8ae1ehttps://github.com/github/remote-input-element/pull/11/commits/6e8ae1ef833639986c16202e515270b072ed1b40
https://github.com/muan
Document new custom eventshttps://github.com/github/remote-input-element/pull/11/commits/14e86c04aab99268a7bd711f6f902f6e1dd5e860
14e86c0https://github.com/github/remote-input-element/pull/11/commits/14e86c04aab99268a7bd711f6f902f6e1dd5e860
https://github.com/muan
muanhttps://github.com/muan
Sep 10, 2019 https://github.com/github/remote-input-element/pull/11#pullrequestreview-286377066
View reviewed changes https://github.com/github/remote-input-element/pull/11/files/14e86c04aab99268a7bd711f6f902f6e1dd5e860
index.jshttps://github.com/github/remote-input-element/pull/11/files/14e86c04aab99268a7bd711f6f902f6e1dd5e860#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
https://github.com/dgraham
dgrahamhttps://github.com/dgraham
Sep 10, 2019 https://github.com/github/remote-input-element/pull/11#pullrequestreview-286411907
View reviewed changes https://github.com/github/remote-input-element/pull/11/files/14e86c04aab99268a7bd711f6f902f6e1dd5e860
https://github.com/muan
muanhttps://github.com/muan
a45c269https://github.com/github/remote-input-element/commit/a45c2692b63bbdadcc59b92d2d6a3adf5646d67c
Sep 10, 2019https://github.com/github/remote-input-element/pull/11#event-2623729583
https://github.com/muan
muanhttps://github.com/muan
September 10, 2019 21:17https://github.com/github/remote-input-element/pull/11#event-2623729841
https://github.co/hiddenchars
https://github.com/github/remote-input-element/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fremote-input-element%2Fpull%2F11
https://github.com/dgraham
dgraham https://github.com/dgraham
https://github.com/github/remote-input-element/pull/11/files/14e86c04aab99268a7bd711f6f902f6e1dd5e860
How to handle unexpected responses https://github.com/github/remote-input-element/issues/10
Please reload this pagehttps://github.com/github/remote-input-element/pull/11
https://github.com/muan
https://github.com/dgraham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.