Title: Tool tests could be a bit more strict in their assertions · Issue #83 · github/github-mcp-server · GitHub
Open Graph Title: Tool tests could be a bit more strict in their assertions · Issue #83 · github/github-mcp-server
X Title: Tool tests could be a bit more strict in their assertions · Issue #83 · github/github-mcp-server
Description: Description On #82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we call the API with the expected values, only stubbing a response va...
Open Graph Description: Description On #82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we call the API with the expe...
X Description: Description On #82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we call the API with the expe...
Opengraph URL: https://github.com/github/github-mcp-server/issues/83
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tool tests could be a bit more strict in their assertions","articleBody":"## Description\n\nOn https://github.com/github/github-mcp-server/pull/82#discussion_r2027574252, I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we **call** the API with the expected values, only stubbing a response value:\n\nhttps://github.com/github/github-mcp-server/blob/bb567331041d57852a840e0a3fb86890228edea3/pkg/github/issues_test.go#L419-L422\n\nWe should maybe look to tighten these tests up a bit, it would be very easy to break the tool implementations without knowing.","author":{"url":"https://github.com/williammartin","@type":"Person","name":"williammartin"},"datePublished":"2025-04-03T19:02:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/83/github-mcp-server/issues/83"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4a273afa-3da2-f4a0-47cd-1209a6099c15 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A468:2DCCB5:9062CC:C87583:6A62482E |
| html-safe-nonce | 0e14829521fecc67303b3747fa6c37380c982d414a20880e7b5db0740f496f3c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDY4OjJEQ0NCNTo5MDYyQ0M6Qzg3NTgzOjZBNjI0ODJFIiwidmlzaXRvcl9pZCI6IjExNjA2ODE2MzYxMjIyMTY0OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 934fbd54e628f667e2e645a7920cc60a9e9c7ae9fe0d83857925c84a0f7436b3 |
| hovercard-subject-tag | issue:2970437587 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github/github-mcp-server/83/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5b62ab8409873005651d992933743ac90d9b3114b53b686376fcf653d5835884/github/github-mcp-server/issues/83 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b62ab8409873005651d992933743ac90d9b3114b53b686376fcf653d5835884/github/github-mcp-server/issues/83 |
| og:image:alt | Description On #82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we call the API with the expe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | williammartin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5d6ba65d73ecc4e3394fe318d2b2f98e6f8eed4878b5421b938e20d30bde267b |
| turbo-cache-control | no-preview |
| go-import | github.com/github/github-mcp-server git https://github.com/github/github-mcp-server.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 942771284 |
| octolytics-dimension-repository_nwo | github/github-mcp-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 942771284 |
| octolytics-dimension-repository_network_root_nwo | github/github-mcp-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2dadc56fd5989b76a8ae7304e3aa56d0b485e5dc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width