René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Two notification-subscription tools omit destructiveHint, defaulting to destructive under MCP 2025-06-18","articleBody":"### Describe the bug\n\nUnder MCP schema 2025-06-18, an omitted `destructiveHint` defaults to `true`.\n\nTwo tools currently emit `readOnlyHint: false` but omit `destructiveHint`, so a spec-conformant client will render them as destructive even though they appear to operate only on the caller's own notification-subscription state:\n\n1. `manage_notification_subscription` in `pkg/github/notifications.go:413`\n   - Updates the caller's own thread subscription state (`watch`, `ignore`, or remove the subscription preference record at `:460` and `:465`)\n   - This does not modify thread or repository content\n\n2. `manage_repository_notification_subscription` in `pkg/github/notifications.go:509`\n   - Updates the caller's own repository subscription state (`subscribed`, `ignored`, or remove the subscription preference record at `:564` and `:569`)\n   - This does not modify repository content\n\nIf that reading is right, both tools are non-read-only but not destructive, and should set `destructiveHint: false` explicitly.\n\nI'm filing this as a question rather than asserting a bug in case I'm misreading the intended risk model.\n\nI scoped this deliberately to these two tools. I did not include other write tools because their current hints are more arguable from source review.\n\n### Affected version\n\nGitHub MCP Server `v1.5.0`\n\nSource reviewed at commit `40db5e3`  \nAffected code:\n- `pkg/github/notifications.go:413`\n- `pkg/github/notifications.go:509`\n\n### Steps to reproduce\n\n1. Open `pkg/github/notifications.go`\n2. Inspect `manage_notification_subscription` and `manage_repository_notification_subscription`\n3. Note that both emit `readOnlyHint: false`\n4. Note that neither sets `destructiveHint`\n5. Under MCP schema 2025-06-18, a conformant client therefore interprets both as `destructiveHint: true`\n\n### Expected behavior\n\nThese per-user subscription toggles should surface as non-destructive writes.\n\n### Actual behavior\n\nThey default to destructive under schema 2025-06-18, so consent UIs over-warn on operations that appear to affect only the caller's own subscription metadata.\n\n### Logs\n\nN/A. Static annotation review only.\n\nIf this matches the intended semantics, I'm happy to open a small PR setting `destructiveHint: false` explicitly on both. From the repo comments, it looks like snapshots can be regenerated with:\n\n`UPDATE_TOOLSNAPS=true go test ./...`","author":{"url":"https://github.com/MaazAhmed47","@type":"Person","name":"MaazAhmed47"},"datePublished":"2026-07-08T13:26:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/2841/github-mcp-server/issues/2841"}