René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"generateInstructions uses AvailableToolsets instead of EnabledToolsetIDs","articleBody":"## Bug Description\n\nIn `pkg/inventory/instructions.go`, the `generateInstructions()` function iterates over `inv.AvailableToolsets()` which returns **all** toolsets that have tools defined, rather than only the **enabled** toolsets based on the `WithToolsets()` configuration.\n\n```go\n// Collect instructions from each enabled toolset\nfor _, toolset := range inv.AvailableToolsets() {  // \u003c- BUG: should use enabled toolsets\n    if toolset.InstructionsFunc != nil {\n        if toolsetInstructions := toolset.InstructionsFunc(inv); toolsetInstructions != \"\" {\n            instructions = append(instructions, toolsetInstructions)\n        }\n    }\n}\n```\n\n## Expected Behavior\n\nWhen building an inventory with `WithToolsets([]string{\"repos\"})`, the generated instructions should only include instructions for the `repos` toolset.\n\n## Actual Behavior\n\nInstructions for **all** toolsets (context, issues, pull_requests, discussions, projects, etc.) are included regardless of which toolsets are enabled.\n\n## Evidence\n\nFrom [mcp-server-diff](https://github.com/marketplace/actions/mcp-server-diff) action comparing v0.29.0 (base) vs v0.30.1 (branch) with `repos` toolset only:\n\n- Base (v0.29.0): **1226 chars** of instructions\n- Branch (v0.30.1): **5886 chars** of instructions\n\nThe v0.30.1 instructions incorrectly include:\n- \"Always call 'get_me' first...\" (context toolset - not enabled)\n- Discussions instructions (not enabled)\n- Issues instructions (not enabled)\n- Projects instructions (not enabled)\n\n## How to Reproduce\n\n1. Update the [mcp-server-diff](https://github.com/marketplace/actions/mcp-server-diff) action to v2.2.0 to see server instruction diffs in CI\n2. Build an inventory with a single toolset: `WithToolsets([]string{\"repos\"}).WithServerInstructions()`\n3. Check `inv.Instructions()` - it will contain instructions for all toolsets, not just repos\n\n## Suggested Fix\n\nUse `EnabledToolsetIDs()` and look up toolset metadata, or add a new `EnabledToolsets()` method that returns `[]ToolsetMetadata` for only enabled toolsets:\n\n```go\nfor _, toolsetID := range inv.EnabledToolsetIDs() {\n    toolset := inv.GetToolsetMetadata(toolsetID)  // or similar\n    if toolset.InstructionsFunc != nil {\n        // ...\n    }\n}\n```\n\n## Version\n\nv0.30.1","author":{"url":"https://github.com/SamMorrowDrums","@type":"Person","name":"SamMorrowDrums"},"datePublished":"2026-01-26T16:52:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1897/github-mcp-server/issues/1897"}