René's URL Explorer Experiment

Title: Fix and rename LandmarkHasLabel rule to NavigationHasLabel by khiga8 · Pull Request #64 · github/erblint-github · GitHub

Open Graph Title: Fix and rename LandmarkHasLabel rule to NavigationHasLabel by khiga8 · Pull Request #64 · github/erblint-github

X Title: Fix and rename LandmarkHasLabel rule to NavigationHasLabel by khiga8 · Pull Request #64 · github/erblint-github

Description: Fixes: https://github.com/github/accessibility/issues/3290 This is a lint rule that was written before our teams time that looks like we need to revisit. This appears to be flagging all

route-pattern	/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controller	voltron_pull_requests_fragments
route-action	pull_request_layout
fetch-nonce	v2:61f6a62a-1114-2960-fc58-d00252611c9d
current-catalog-service-hash	ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id	D48C:BFD0F:1C55B73:25E6AC0:698D9547
html-safe-nonce	1bf4451f229214506e066fecc94f54847e34771b85cb88b130ca0df208839120
visitor-payload	eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDhDOkJGRDBGOjFDNTVCNzM6MjVFNkFDMDo2OThEOTU0NyIsInZpc2l0b3JfaWQiOiIyNDcyODI2NDkzNDg4MDU5NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac	f31bfeee3f2b051aec5f0f556b463b1623f31454991b3fe8d2e12c757e2ce3a4
hovercard-subject-tag	pull_request:1305297133
github-keyboard-shortcuts	repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification	Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url	https://collector.github.com/github/collect
analytics-location	///voltron/pull_requests_fragments/pull_request_layout
fb:app_id	1401488693436528
apple-itunes-app	app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/erblint-github/64/pull_request_layout
twitter:image	https://opengraph.githubassets.com/325e32e8967db1fa55ae3de8669a3312b85f79837e2d28a65d496de28681f429/github/erblint-github/pull/64
twitter:card	summary_large_image
og:image	https://opengraph.githubassets.com/325e32e8967db1fa55ae3de8669a3312b85f79837e2d28a65d496de28681f429/github/erblint-github/pull/64
og:image:alt	Fixes: https://github.com/github/accessibility/issues/3290 This is a lint rule that was written before our teams time that looks like we need to revisit. This appears to be flagging all <aside&g...
og:image:width	1200
og:image:height	600
og:site_name	GitHub
og:type	object
og:author:username	khiga8
hostname	github.com
expected-hostname	github.com
None	c0818105fa276287e9369cfdefa0a0fa7953719791ceff9b94d69623c0a4fe8a
turbo-cache-control	no-preview
go-import	github.com/github/erblint-github git https://github.com/github/erblint-github.git
octolytics-dimension-user_id	9919
octolytics-dimension-user_login	github
octolytics-dimension-repository_id	419022203
octolytics-dimension-repository_nwo	github/erblint-github
octolytics-dimension-repository_public	true
octolytics-dimension-repository_is_fork	false
octolytics-dimension-repository_network_root_id	419022203
octolytics-dimension-repository_network_root_nwo	github/erblint-github
turbo-body-classes	logged-out env-production page-responsive
disable-turbo	false
browser-stats-url	https://api.github.com/_private/browser/stats
browser-errors-url	https://api.github.com/_private/browser/errors
release	cefb6b50cb02e85b21d59b711abca4e67e11cf47
ui-target	full
theme-color	#1e2327
color-scheme	light dark

Skip to content	https://github.com/github/erblint-github/pull/64#start-of-content
	https://github.com/
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Ferblint-github%2Fpull%2F64
GitHub CopilotWrite better code with AI	https://github.com/features/copilot
GitHub SparkBuild and deploy intelligent apps	https://github.com/features/spark
GitHub ModelsManage and compare prompts	https://github.com/features/models
MCP RegistryNewIntegrate external tools	https://github.com/mcp
ActionsAutomate any workflow	https://github.com/features/actions
CodespacesInstant dev environments	https://github.com/features/codespaces
IssuesPlan and track work	https://github.com/features/issues
Code ReviewManage code changes	https://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilities	https://github.com/security/advanced-security
Code securitySecure your code as you build	https://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they start	https://github.com/security/advanced-security/secret-protection
Why GitHub	https://github.com/why-github
Documentation	https://docs.github.com
Blog	https://github.blog
Changelog	https://github.blog/changelog
Marketplace	https://github.com/marketplace
View all features	https://github.com/features
Enterprises	https://github.com/enterprise
Small and medium teams	https://github.com/team
Startups	https://github.com/enterprise/startups
Nonprofits	https://github.com/solutions/industry/nonprofits
App Modernization	https://github.com/solutions/use-case/app-modernization
DevSecOps	https://github.com/solutions/use-case/devsecops
DevOps	https://github.com/solutions/use-case/devops
CI/CD	https://github.com/solutions/use-case/ci-cd
View all use cases	https://github.com/solutions/use-case
Healthcare	https://github.com/solutions/industry/healthcare
Financial services	https://github.com/solutions/industry/financial-services
Manufacturing	https://github.com/solutions/industry/manufacturing
Government	https://github.com/solutions/industry/government
View all industries	https://github.com/solutions/industry
View all solutions	https://github.com/solutions
AI	https://github.com/resources/articles?topic=ai
Software Development	https://github.com/resources/articles?topic=software-development
DevOps	https://github.com/resources/articles?topic=devops
Security	https://github.com/resources/articles?topic=security
View all topics	https://github.com/resources/articles
Customer stories	https://github.com/customer-stories
Events & webinars	https://github.com/resources/events
Ebooks & reports	https://github.com/resources/whitepapers
Business insights	https://github.com/solutions/executive-insights
GitHub Skills	https://skills.github.com
Documentation	https://docs.github.com
Customer support	https://support.github.com
Community forum	https://github.com/orgs/community/discussions
Trust center	https://github.com/trust-center
Partners	https://github.com/partners
GitHub SponsorsFund open source developers	https://github.com/sponsors
Security Lab	https://securitylab.github.com
Maintainer Community	https://maintainers.github.com
Accelerator	https://github.com/accelerator
Archive Program	https://archiveprogram.github.com
Topics	https://github.com/topics
Trending	https://github.com/trending
Collections	https://github.com/collections
Enterprise platformAI-powered developer platform	https://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security features	https://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI features	https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support	https://github.com/premium-support
Pricing	https://github.com/pricing
Search syntax tips	https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentation	https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Ferblint-github%2Fpull%2F64
Sign up	https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Ferblint-github
Reload	https://github.com/github/erblint-github/pull/64
Reload	https://github.com/github/erblint-github/pull/64
Reload	https://github.com/github/erblint-github/pull/64
github	https://github.com/github
erblint-github	https://github.com/github/erblint-github
Notifications	https://github.com/login?return_to=%2Fgithub%2Ferblint-github
Fork 9	https://github.com/login?return_to=%2Fgithub%2Ferblint-github
Star 61	https://github.com/login?return_to=%2Fgithub%2Ferblint-github
Code	https://github.com/github/erblint-github
Issues 6	https://github.com/github/erblint-github/issues
Pull requests 1	https://github.com/github/erblint-github/pulls
Discussions	https://github.com/github/erblint-github/discussions
Actions	https://github.com/github/erblint-github/actions
Projects 0	https://github.com/github/erblint-github/projects
Models	https://github.com/github/erblint-github/models
Security 0	https://github.com/github/erblint-github/security
Insights	https://github.com/github/erblint-github/pulse
Code	https://github.com/github/erblint-github
Issues	https://github.com/github/erblint-github/issues
Pull requests	https://github.com/github/erblint-github/pulls
Discussions	https://github.com/github/erblint-github/discussions
Actions	https://github.com/github/erblint-github/actions
Projects	https://github.com/github/erblint-github/projects
Models	https://github.com/github/erblint-github/models
Security	https://github.com/github/erblint-github/security
Insights	https://github.com/github/erblint-github/pulse
Sign up for GitHub	https://github.com/signup?return_to=%2Fgithub%2Ferblint-github%2Fissues%2Fnew%2Fchoose
terms of service	https://docs.github.com/terms
privacy statement	https://docs.github.com/privacy
Sign in	https://github.com/login?return_to=%2Fgithub%2Ferblint-github%2Fissues%2Fnew%2Fchoose
Jump to bottom	https://github.com/github/erblint-github/pull/64#issue-comment-box
khiga8	https://github.com/khiga8
main	https://github.com/github/erblint-github/tree/main
kh-fix-landmark-logic	https://github.com/github/erblint-github/tree/kh-fix-landmark-logic
Fix and rename LandmarkHasLabel rule to NavigationHasLabel	https://github.com/github/erblint-github/pull/64#top
khiga8	https://github.com/khiga8
main	https://github.com/github/erblint-github/tree/main
kh-fix-landmark-logic	https://github.com/github/erblint-github/tree/kh-fix-landmark-logic
Conversation 3	https://github.com/github/erblint-github/pull/64
Commits 3	https://github.com/github/erblint-github/pull/64/commits
Checks 0	https://github.com/github/erblint-github/pull/64/checks
Files changed	https://github.com/github/erblint-github/pull/64/files
Please reload this page	https://github.com/github/erblint-github/pull/64
	https://github.co/hiddenchars
	https://github.com/github/erblint-github/pull/{{ revealButtonHref }}
	https://github.com/khiga8
khiga8	https://github.com/khiga8
Apr 6, 2023	https://github.com/github/erblint-github/pull/64#issue-1658066195
Please reload this page	https://github.com/github/erblint-github/pull/64
https://github.com/github/accessibility/issues/3290	https://github.com/github/accessibility/issues/3290
Please reload this page	https://github.com/github/erblint-github/pull/64
	https://github.com/khiga8
Fix lint rule logic	https://github.com/github/erblint-github/pull/64/commits/5295b9332bef1776520b55b4abd081daabbac946
5295b93	https://github.com/github/erblint-github/pull/64/commits/5295b9332bef1776520b55b4abd081daabbac946
	https://github.com/khiga8
khiga8	https://github.com/khiga8
force-pushed	https://github.com/github/erblint-github/compare/dd1574fc40957f401b4a902bbe64b2528e60f29d..5295b9332bef1776520b55b4abd081daabbac946
dd1574f	https://github.com/github/erblint-github/commit/dd1574fc40957f401b4a902bbe64b2528e60f29d
5295b93	https://github.com/github/erblint-github/commit/5295b9332bef1776520b55b4abd081daabbac946
Compare	https://github.com/github/erblint-github/compare/dd1574fc40957f401b4a902bbe64b2528e60f29d..5295b9332bef1776520b55b4abd081daabbac946
April 6, 2023 23:20	https://github.com/github/erblint-github/pull/64#event-8950384021
	https://github.com/khiga8
khiga8	https://github.com/khiga8
Apr 6, 2023	https://github.com/github/erblint-github/pull/64#event-8950404689
	https://github.com/khiga8
Rename rule and deprecate old one	https://github.com/github/erblint-github/pull/64/commits/a95a56f45047af6430c511b96ddb95871fa696a7
a95a56f	https://github.com/github/erblint-github/pull/64/commits/a95a56f45047af6430c511b96ddb95871fa696a7
	https://github.com/khiga8
khiga8	https://github.com/khiga8
force-pushed	https://github.com/github/erblint-github/compare/cc8a730dea3b722519e0c99dc9b162cce237cdfe..a95a56f45047af6430c511b96ddb95871fa696a7
cc8a730	https://github.com/github/erblint-github/commit/cc8a730dea3b722519e0c99dc9b162cce237cdfe
a95a56f	https://github.com/github/erblint-github/commit/a95a56f45047af6430c511b96ddb95871fa696a7
Compare	https://github.com/github/erblint-github/compare/cc8a730dea3b722519e0c99dc9b162cce237cdfe..a95a56f45047af6430c511b96ddb95871fa696a7
April 6, 2023 23:30	https://github.com/github/erblint-github/pull/64#event-8950414753
	https://github.com/khiga8
khiga8	https://github.com/khiga8
April 6, 2023 23:30	https://github.com/github/erblint-github/pull/64#event-8950414987
	https://github.com/khiga8
khiga8	https://github.com/khiga8
code owner	https://github.com/github/erblint-github/blob/cc6a40699a15a170988479d4f08c884925163052/CODEOWNERS#L1
April 6, 2023 23:30	https://github.com/github/erblint-github/pull/64#event-8950415001
	https://github.com/khiga8
khiga8	https://github.com/khiga8
accessibility-bot	https://github.com/accessibility-bot
April 6, 2023 23:30	https://github.com/github/erblint-github/pull/64#event-8950415020
	https://github.com/khiga8
khiga8	https://github.com/khiga8
Apr 6, 2023	https://github.com/github/erblint-github/pull/64#event-8950415499
	https://github.com/accessibility-bot
accessibility-bot	https://github.com/accessibility-bot
Apr 6, 2023	https://github.com/github/erblint-github/pull/64#issuecomment-1499760823
#accessibility	https://github.slack.com/archives/C0FSWLQ0Y
Please reload this page	https://github.com/github/erblint-github/pull/64
	https://github.com/kendallgassner
kendallgassner	https://github.com/kendallgassner
Apr 11, 2023	https://github.com/github/erblint-github/pull/64#pullrequestreview-1379528112
View reviewed changes	https://github.com/github/erblint-github/pull/64/files/a95a56f45047af6430c511b96ddb95871fa696a7
lib/erblint-github/linters/github/accessibility/navigation_has_label.rb	https://github.com/github/erblint-github/pull/64/files/a95a56f45047af6430c511b96ddb95871fa696a7#diff-e0ff528d3dad19e3f7e577a73e4011391e70964f684f403c736e73716e7dc0f1
kendallgassner	https://github.com/kendallgassner
Apr 11, 2023	https://github.com/github/erblint-github/pull/64#discussion_r1162976992
Learn more	https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page	https://github.com/github/erblint-github/pull/64
khiga8	https://github.com/khiga8
Apr 11, 2023	https://github.com/github/erblint-github/pull/64#discussion_r1162983778
Learn more	https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page	https://github.com/github/erblint-github/pull/64
	https://github.com/khiga8
Update navigation_has_label.rb	https://github.com/github/erblint-github/pull/64/commits/0a0e22a10eb05ed2c5d1460c3d9a015b676e60b3
0a0e22a	https://github.com/github/erblint-github/pull/64/commits/0a0e22a10eb05ed2c5d1460c3d9a015b676e60b3
	https://github.com/khiga8
khiga8	https://github.com/khiga8
kendallgassner	https://github.com/kendallgassner
April 11, 2023 15:21	https://github.com/github/erblint-github/pull/64#event-8975292270
	https://github.com/kendallgassner
kendallgassner	https://github.com/kendallgassner
Apr 11, 2023	https://github.com/github/erblint-github/pull/64#pullrequestreview-1379709985
View reviewed changes	https://github.com/github/erblint-github/pull/64/files/0a0e22a10eb05ed2c5d1460c3d9a015b676e60b3
	https://github.com/khiga8
khiga8	https://github.com/khiga8
94d782c	https://github.com/github/erblint-github/commit/94d782c90eea2fb1f245e3b29d2ad640ad83ce8f
Apr 11, 2023	https://github.com/github/erblint-github/pull/64#event-8976242288
	https://github.com/khiga8
khiga8	https://github.com/khiga8
April 11, 2023 16:53	https://github.com/github/erblint-github/pull/64#event-8976242496
Sign up for free	https://github.com/join?source=comment-repo
Sign in to comment	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Ferblint-github%2Fpull%2F64
	https://github.com/kendallgassner
kendallgassner	https://github.com/kendallgassner
	https://github.com/github/erblint-github/pull/64/files/0a0e22a10eb05ed2c5d1460c3d9a015b676e60b3
	https://github.com/accessibility-bot
accessibility-bot	https://github.com/accessibility-bot
Please reload this page	https://github.com/github/erblint-github/pull/64
	https://github.com/khiga8
	https://github.com/accessibility-bot
	https://github.com/kendallgassner
	https://github.com
Terms	https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy	https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security	https://github.com/security
Status	https://www.githubstatus.com/
Community	https://github.community/
Docs	https://docs.github.com/
Contact	https://support.github.com?tags=dotcom-footer