Title: Introduce wrapper around codeql by robertbrignull · Pull Request #93 · github/codeql-action · GitHub
Open Graph Title: Introduce wrapper around codeql by robertbrignull · Pull Request #93 · github/codeql-action
X Title: Introduce wrapper around codeql by robertbrignull · Pull Request #93 · github/codeql-action
Description: I'd be interested to know what people think of this. This PR puts all calls to CodeQL behind an object with an interface that we can override in unit tests. Currently it's not possible to write tests for any area that makes CodeQL calls because it won't be available and you don't want to be actually running queries or creating databases during the unit tests. I'm doing this now because I'd like to move processing of external queries earlier in the process to where we parse the config, and that requires running CodeQL in codepaths that we currently unit test. As well as making more code testable, this also hopefully makes things easier to understand by keeping all the codeql invocations in one place and imposing that there is a named function interface to it with documentation so it's more clear what each call does. I had to use a bit of judgement (i.e. random guesses) at where to draw the boundary of the interface. In some cases it includes a little bit of logic, and in one case it's actually two CodeQL calls combined into one. If you have any suggestions for improvements then please say. @sampart, @Daverlo, @chrisgavin, @rneatherway Merge / deployment checklist Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos! CodeQL using init/analyze actions 3rd party tool using upload action Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.
Open Graph Description: I'd be interested to know what people think of this. This PR puts all calls to CodeQL behind an object with an interface that we can override in unit tests. Currently it's not possible to w...
X Description: I'd be interested to know what people think of this. This PR puts all calls to CodeQL behind an object with an interface that we can override in unit tests. Currently it's not possi...
Opengraph URL: https://github.com/github/codeql-action/pull/93
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0257745f-8781-4268-82e3-39d9d9a99efe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED10:30A6D1:12FEAFA:1B8E1F9:6A563AB6 |
| html-safe-nonce | e679d62d4648c7f3747d5060dd0c7da87e7f7c644a53bf61b1c777ce35b4de4b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDEwOjMwQTZEMToxMkZFQUZBOjFCOEUxRjk6NkE1NjNBQjYiLCJ2aXNpdG9yX2lkIjoiNjMxMDE5NzQwMDgxNzc3NzMzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 24143ad970a5f6e961d993460cc036b66ecba553992827313f2af2f631b374f6 |
| hovercard-subject-tag | pull_request:442146789 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/93/files |
| twitter:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| og:image:alt | I'd be interested to know what people think of this. This PR puts all calls to CodeQL behind an object with an interface that we can override in unit tests. Currently it's not possible to w... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9d78ea552aac0685ca5f006d44f88166cbbf3bb96843f8da0c5a2c0b9908430b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423b2fb76ac2b90de5ab599b7a76a0d2b2c83f24 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width