Title: Use a single Octokit client for everything rather than a bunch of Octokits and an HTTP client. by chrisgavin · Pull Request #82 · github/codeql-action · GitHub
Open Graph Title: Use a single Octokit client for everything rather than a bunch of Octokits and an HTTP client. by chrisgavin · Pull Request #82 · github/codeql-action
X Title: Use a single Octokit client for everything rather than a bunch of Octokits and an HTTP client. by chrisgavin · Pull Request #82 · github/codeql-action
Description: Currently our requests to the GitHub API are pretty inconsistent. In a few places we use an Octokit, but we construct them at the point of use potentially leading to them being initialized inconsistently. We also sometimes just use an HTTP client. Perhaps most importantly, none of these methods actually respect the GITHUB_API_URL environment variable that tells you where to find the GitHub API. Because of this I've replaced these custom Octokits and the HTTP client with a single Octokit to ensure that all requests are made consistently and to the correct host. Merge / deployment checklist Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos! CodeQL using init/analyze actions 3rd party tool using upload action Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.
Open Graph Description: Currently our requests to the GitHub API are pretty inconsistent. In a few places we use an Octokit, but we construct them at the point of use potentially leading to them being initialized inconsis...
X Description: Currently our requests to the GitHub API are pretty inconsistent. In a few places we use an Octokit, but we construct them at the point of use potentially leading to them being initialized inconsis...
Opengraph URL: https://github.com/github/codeql-action/pull/82
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0f5c7f16-cabc-236a-4063-1336989386f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B678:1D923B:77DEA5:A13266:6A541997 |
| html-safe-nonce | 57883ea13f2d1bf34418809176fc6635008f71f94849a1e6c29e4d31bebc19c7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjc4OjFEOTIzQjo3N0RFQTU6QTEzMjY2OjZBNTQxOTk3IiwidmlzaXRvcl9pZCI6Ijc1ODkwNTIxNzQwODY0NDU0NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4bc4311fb25d2fae45643ad532c6899082e42b5c8a2c95daa53927982bb96704 |
| hovercard-subject-tag | pull_request:438794324 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/82/files |
| twitter:image | https://avatars.githubusercontent.com/u/5584439?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5584439?s=400&v=4 |
| og:image:alt | Currently our requests to the GitHub API are pretty inconsistent. In a few places we use an Octokit, but we construct them at the point of use potentially leading to them being initialized inconsis... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width