Title: Handle errors during database upload by robertbrignull · Pull Request #576 · github/codeql-action · GitHub
Open Graph Title: Handle errors during database upload by robertbrignull · Pull Request #576 · github/codeql-action
X Title: Handle errors during database upload by robertbrignull · Pull Request #576 · github/codeql-action
Description: I've made a mistake here with my understanding of errors from octokit. I thought it always returned a response object, but that's not the case and for non-2XX responses it throws an exception instead. This manifested as https://github.com/github/codeql-action/runs/2873026409 which we didn't spot until it made it onto the main branch because that codepath doesn't execute during pull requests. This change should be a fix for it. However this PR doesn't currently address the fact that we didn't catch it and there aren't tests for this area of the code. I'd like to also do that, ideally as part of this PR but could be afterwards instead. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary. Confirm the changelog has been updated if necessary.
Open Graph Description: I've made a mistake here with my understanding of errors from octokit. I thought it always returned a response object, but that's not the case and for non-2XX responses it throws an excepti...
X Description: I've made a mistake here with my understanding of errors from octokit. I thought it always returned a response object, but that's not the case and for non-2XX responses it throws an...
Opengraph URL: https://github.com/github/codeql-action/pull/576
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cb308667-68e4-55bd-58ef-b51d13e0db9c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B6EA:92731:C690DB:10A4735:6A5701D9 |
| html-safe-nonce | ec8488cc66d8bc64e0a5fa9f42a56c5aee8668ac0427375044177e03af1e328e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkVBOjkyNzMxOkM2OTBEQjoxMEE0NzM1OjZBNTcwMUQ5IiwidmlzaXRvcl9pZCI6IjQyNjM5NTY3MDYxOTQwMzEwNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 81ab51705bc692c045af4776bb4b6c6593d3ac973a4585238e09b97b564bee93 |
| hovercard-subject-tag | pull_request:674387128 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/576/files |
| twitter:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| og:image:alt | I've made a mistake here with my understanding of errors from octokit. I thought it always returned a response object, but that's not the case and for non-2XX responses it throws an excepti... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb29e5f807bd95e41196adfbc6d28f9af12d89830d8b684f3e871774ddff2fc |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b056788a129fb0194b61f2ebb4c43f6a9f4dfd27 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width