Title: Make config file parsing more strict by robertbrignull · Pull Request #46 · github/codeql-action · GitHub
Open Graph Title: Make config file parsing more strict by robertbrignull · Pull Request #46 · github/codeql-action
X Title: Make config file parsing more strict by robertbrignull · Pull Request #46 · github/codeql-action
Description: This PR aims to make the parsing of the config file stricter, and safer from a code maintenance point of view. The changes are: Improve error messages to be more descriptive. Throw an error if any field is of a type that it shouldn't be, instead of silently ignoring it. Define constants for all the field names and always use those constants when accessing that field. This is obviously going to conflict a bit with #45 but it shouldn't be too bad and it'll be easy to sort out whichever one gets merged first. Merge / deployment checklist Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos! CodeQL using init/analyze actions 3rd party tool using upload action Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.
Open Graph Description: This PR aims to make the parsing of the config file stricter, and safer from a code maintenance point of view. The changes are: Improve error messages to be more descriptive. Throw an error if any...
X Description: This PR aims to make the parsing of the config file stricter, and safer from a code maintenance point of view. The changes are: Improve error messages to be more descriptive. Throw an error if any...
Opengraph URL: https://github.com/github/codeql-action/pull/46
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c98deae0-eaa4-619d-3e2f-02febd9cbd48 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D0D0:2CBC5E:301FC30:4517D9E:6A567AEA |
| html-safe-nonce | 47558381bcbaf092234570e031880692b9eb82301da639127b28e127da06c8d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEQwOjJDQkM1RTozMDFGQzMwOjQ1MTdEOUU6NkE1NjdBRUEiLCJ2aXNpdG9yX2lkIjoiNzk5NzU1NjA3NDIwNjM2MjM0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2df36b28fbba67f0695035cb1aa7d2a1fb37c641fe9f496e5a424cdab031af05 |
| hovercard-subject-tag | pull_request:423377731 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/46/files |
| twitter:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| og:image:alt | This PR aims to make the parsing of the config file stricter, and safer from a code maintenance point of view. The changes are: Improve error messages to be more descriptive. Throw an error if any... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b5ee9431dcfce15ab4b001d626e4e3a6ba1acb7be814813a52bbebd9a86ef5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fc131753d059926755b1ab26f13a2c96a692f5d7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width