René's URL Explorer Experiment


Title: Failed SARIF testing and logging improvements by mbg · Pull Request #4249 · github/codeql-action · GitHub

Open Graph Title: Failed SARIF testing and logging improvements by mbg · Pull Request #4249 · github/codeql-action

X Title: Failed SARIF testing and logging improvements by mbg · Pull Request #4249 · github/codeql-action

Description: Cherry-picked changes from #4223 which primarily improve our ability to test the failed SARIF upload process in init-post. These changes are in prep for #4223 to make them easier to review, but aren't all used here yet. The main changes here are: For the failed SARIF upload process, the function of shouldSkipSarifUpload is now divided up between it and a new shouldSkipGenerateFailedSarif. To maintain backwards compatibility, shouldSkipSarifUpload implies shouldSkipGenerateFailedSarif by default. Both can now explicitly be set to false rather than just explicitly set to true. shouldSkipGenerateFailedSarif now guards whether the failed SARIF is generated rather than shouldSkipSarifUpload. This allows us to generate the failed SARIF, but not upload it. Previously not uploading it implied not generating it. combineSarifFilesUsingCLI was calling getConfig itself, which made it oblivious to the new failed configuration file that was introduced in #4225. This is changed so that the Config is propagated to it from higher up in the call hierarchy. See #4223 (comment) for one implication of this change. Some logging improvements. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Workflow types: Advanced setup - Impacts users who have custom CodeQL workflows. Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...). Products: Code Scanning - The changes impact analyses when analysis-kinds: code-scanning. Code Quality - The changes impact analyses when analysis-kinds: code-quality. Other first-party - The changes impact other first-party analyses. Third-party analyses - The changes affect the upload-sarif action. Environments: Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency. GHES - Impacts CodeQL workflows on GitHub Enterprise Server. How did/will you validate this change? Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files). End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks). If something goes wrong after this change is released, what are the mitigation and rollback strategies? Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix. How will you know if something goes wrong after this change is released? Telemetry - I rely on existing telemetry or have made changes to the telemetry. Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release. Alerts - New or existing monitors will trip if something goes wrong with this change. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.

Open Graph Description: Cherry-picked changes from #4223 which primarily improve our ability to test the failed SARIF upload process in init-post. These changes are in prep for #4223 to make them easier to review, but are...

X Description: Cherry-picked changes from #4223 which primarily improve our ability to test the failed SARIF upload process in init-post. These changes are in prep for #4223 to make them easier to review, but are...

Opengraph URL: https://github.com/github/codeql-action/pull/4249

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f52156af-de1c-dd93-204f-bf55c0143ec8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C24:3865E3:666E8A:852753:6AED2CA4
html-safe-noncee2aa632482e265da923249831211e2f9afa8949ed3695105d64e1c83de591d53
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzI0OjM4NjVFMzo2NjZFOEE6ODUyNzUzOjZBRUQyQ0E0IiwidmlzaXRvcl9pZCI6IjU0OTQwMDU3ODE4MTMzNDEzNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace0e6fb5c42372af556c9dcd9ce55bfd913a9c1d4086ef8f4a43b50606b6a4503
hovercard-subject-tagpull_request:4891107538
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/4249/files
twitter:imagehttps://avatars.githubusercontent.com/u/278086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/278086?s=400&v=4
og:image:altCherry-picked changes from #4223 which primarily improve our ability to test the failed SARIF upload process in init-post. These changes are in prep for #4223 to make them easier to review, but are...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql-action git https://github.com/github/codeql-action.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id259445878
octolytics-dimension-repository_nwogithub/codeql-action
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id259445878
octolytics-dimension-repository_network_root_nwogithub/codeql-action
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql-action/pull/4249/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F4249%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F4249%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql-action
Reloadhttps://github.com/github/codeql-action/pull/4249/files
Reloadhttps://github.com/github/codeql-action/pull/4249/files
Reloadhttps://github.com/github/codeql-action/pull/4249/files
githubhttps://github.com/github
codeql-actionhttps://github.com/github/codeql-action
Codehttps://github.com/github/codeql-action
Issues165 (165)https://github.com/github/codeql-action/issues
Pull requests41 (41)https://github.com/github/codeql-action/pulls
Actionshttps://github.com/github/codeql-action/actions
Security and quality2 (2)https://github.com/github/codeql-action/security
Insightshttps://github.com/github/codeql-action/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql-action%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql-action%2Fissues%2Fnew%2Fchoose
mbghttps://github.com/mbg
mainhttps://github.com/github/codeql-action/tree/main
mbg/upload-improvements-for-4223https://github.com/github/codeql-action/tree/mbg/upload-improvements-for-4223
Conversation 6 https://github.com/github/codeql-action/pull/4249
Commits 12 https://github.com/github/codeql-action/pull/4249/commits
Checks 225 https://github.com/github/codeql-action/pull/4249/checks
Files changed 12 https://github.com/github/codeql-action/pull/4249/files
Failed SARIF testing and logging improvements https://github.com/github/codeql-action/pull/4249/files#top
Show all changes 12 commits https://github.com/github/codeql-action/pull/4249/files
be1223f Log when we didn't get a normal configuration file mbg Oct 12, 2026 https://github.com/github/codeql-action/pull/4249/commits/be1223f63ec6519618c55fb853646cfce4c5192c
a9cd2f9 Allow to explicitly not skip the SARIF upload mbg Oct 15, 2026 https://github.com/github/codeql-action/pull/4249/commits/a9cd2f9fa7d36f998863794b3c96ad9cec35db22
6e9aec6 Add and use `shouldSkipGenerateFailedSarif` mbg Oct 15, 2026 https://github.com/github/codeql-action/pull/4249/commits/6e9aec682d5a2cb314aac734a431d598d774e438
02fb8cc Propagate `Config` to `combineSarifFilesUsingCLI` mbg Oct 15, 2026 https://github.com/github/codeql-action/pull/4249/commits/02fb8cc38a65e2d5fb2e750982c55ee388c723fb
e7340ee Skip waiting for SARIF if nothing was uploaded mbg Oct 16, 2026 https://github.com/github/codeql-action/pull/4249/commits/e7340eea1b5895c30f5df0120ab216b178008119
1d373e0 Upload failed SARIF as workflow artifact in test mode mbg Oct 12, 2026 https://github.com/github/codeql-action/pull/4249/commits/1d373e07cd06e258526e54ed5e84a989e6efa9de
5b69b28 Improve logging in `uploadSarifArtifact` mbg Oct 16, 2026 https://github.com/github/codeql-action/pull/4249/commits/5b69b28796f47682d750572e7c4649b8edb1508f
950b147 Ensure that `rootDirectory` is suitable for `sarifFile` in `uploadSar… mbg Oct 16, 2026 https://github.com/github/codeql-action/pull/4249/commits/950b1479a1b463f299172b24f365fa18998b5b5f
74ddcd9 Fix typo in comment mbg Oct 20, 2026 https://github.com/github/codeql-action/pull/4249/commits/74ddcd9f65683791ab07eccd074b4ba145d89ea6
a69c7cb Document that setting the env vars to `false` takes precedence mbg Oct 20, 2026 https://github.com/github/codeql-action/pull/4249/commits/a69c7cb332d56f616fcadef002884523c71e8d1c
7fa4518 Use `shouldSkipSarifUpload` in `analyze-action.ts` mbg Oct 20, 2026 https://github.com/github/codeql-action/pull/4249/commits/7fa45180db8d657b23ded3636b5d8583aec6ddfe
b96e339 Change comment for `getConfig` call in `upload-sarif` mbg Oct 20, 2026 https://github.com/github/codeql-action/pull/4249/commits/b96e3390db93dc46c2c3753a94b87c0d734b0b61
Clear filters https://github.com/github/codeql-action/pull/4249/files
Please reload this pagehttps://github.com/github/codeql-action/pull/4249/files
Please reload this pagehttps://github.com/github/codeql-action/pull/4249/files
entry-points.js https://github.com/github/codeql-action/pull/4249/files#diff-73697317a7dd14441dcfb24bc586f637ae2b815b5e503a05a81816be74fcd815
analyze-action.ts https://github.com/github/codeql-action/pull/4249/files#diff-c659460f1608e167fc5bef89e07b4c7db2d8cdf80e542ec788c969a6ed987d34
environment.ts https://github.com/github/codeql-action/pull/4249/files#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
init-action-post-helper.test.ts https://github.com/github/codeql-action/pull/4249/files#diff-62c5bc1fe681a41f34d74ef117f4aa52ae21023a6f78abe2655e635afa48b08a
init-action-post-helper.ts https://github.com/github/codeql-action/pull/4249/files#diff-b5d09ae3a926294c25f263fe282f10168d52ee21a08447eade997108a11523bd
init-action-post.ts https://github.com/github/codeql-action/pull/4249/files#diff-b20d2e5b98b2b7bb62f615d46b97c30d07e8c1f12e2f263a3a323d5ecf8b5ca6
upload-lib.ts https://github.com/github/codeql-action/pull/4249/files#diff-9c600636c759380cf603b7cb23771d1fe5b3cf73df63a71bd566c0cf34fa6b38
upload-sarif-action.ts https://github.com/github/codeql-action/pull/4249/files#diff-8f3f1d0ae3f1ff6da6f40febfbdbdb1ee0a734bcd42dee83d7d5909a2b712aed
upload-sarif.test.ts https://github.com/github/codeql-action/pull/4249/files#diff-485c95cedf5bbfd8a5c4ceb315f66e43575dee6139e177f2850802c35eaaa246
upload-sarif.ts https://github.com/github/codeql-action/pull/4249/files#diff-0ffebd7868a9bec42440b12bf95c55cb48dd2c1340f57c321b706e014eccc173
util.test.ts https://github.com/github/codeql-action/pull/4249/files#diff-5b8db3845646ec2fda6f1a8fb2b5b8c67460b5070568f4be6320f344704969cd
util.ts https://github.com/github/codeql-action/pull/4249/files#diff-3294a832ea2276e554177e0b3007cc2d401c082912c7fbde49fa09141bf1aed1
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
lib/entry-points.jshttps://github.com/github/codeql-action/pull/4249/files#diff-73697317a7dd14441dcfb24bc586f637ae2b815b5e503a05a81816be74fcd815
View file https://github.com/github/codeql-action/blob/b96e3390db93dc46c2c3753a94b87c0d734b0b61/lib/entry-points.js
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/github/codeql-action/pull/4249/files
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
src/analyze-action.tshttps://github.com/github/codeql-action/pull/4249/files#diff-c659460f1608e167fc5bef89e07b4c7db2d8cdf80e542ec788c969a6ed987d34
View file https://github.com/github/codeql-action/blob/b96e3390db93dc46c2c3753a94b87c0d734b0b61/src/analyze-action.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql-action/pull/4249/{{ revealButtonHref }}
https://github.com/github/codeql-action/pull/4249/files#diff-c659460f1608e167fc5bef89e07b4c7db2d8cdf80e542ec788c969a6ed987d34
https://github.com/github/codeql-action/pull/4249/files#diff-c659460f1608e167fc5bef89e07b4c7db2d8cdf80e542ec788c969a6ed987d34
https://github.com/github/codeql-action/pull/4249/files#diff-c659460f1608e167fc5bef89e07b4c7db2d8cdf80e542ec788c969a6ed987d34
https://github.com/github/codeql-action/pull/4249/files#diff-c659460f1608e167fc5bef89e07b4c7db2d8cdf80e542ec788c969a6ed987d34
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
src/environment.tshttps://github.com/github/codeql-action/pull/4249/files#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
View file https://github.com/github/codeql-action/blob/b96e3390db93dc46c2c3753a94b87c0d734b0b61/src/environment.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql-action/pull/4249/{{ revealButtonHref }}
https://github.com/github/codeql-action/pull/4249/files#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
Please reload this pagehttps://github.com/github/codeql-action/pull/4249/files
https://github.com/github/codeql-action/pull/4249/files#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
src/init-action-post-helper.test.tshttps://github.com/github/codeql-action/pull/4249/files#diff-62c5bc1fe681a41f34d74ef117f4aa52ae21023a6f78abe2655e635afa48b08a
View file https://github.com/github/codeql-action/blob/b96e3390db93dc46c2c3753a94b87c0d734b0b61/src/init-action-post-helper.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql-action/pull/4249/{{ revealButtonHref }}
https://github.com/github/codeql-action/pull/4249/files#diff-62c5bc1fe681a41f34d74ef117f4aa52ae21023a6f78abe2655e635afa48b08a
https://github.com/github/codeql-action/pull/4249/files#diff-62c5bc1fe681a41f34d74ef117f4aa52ae21023a6f78abe2655e635afa48b08a
Please reload this pagehttps://github.com/github/codeql-action/pull/4249/files
Please reload this pagehttps://github.com/github/codeql-action/pull/4249/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.