René's URL Explorer Experiment


Title: Do not use `core.exportVariable` in unit tests (2nd attempt) by mbg · Pull Request #4212 · github/codeql-action · GitHub

Open Graph Title: Do not use `core.exportVariable` in unit tests (2nd attempt) by mbg · Pull Request #4212 · github/codeql-action

X Title: Do not use `core.exportVariable` in unit tests (2nd attempt) by mbg · Pull Request #4212 · github/codeql-action

Description: Actions for running CodeQL analysis. Contribute to github/codeql-action development by creating an account on GitHub.

Open Graph Description: This PR revives #3930 as per the discussion at #4198 (comment). This PR aims to accomplish the same goals as #3930, but is updated based on changes that have happened in the codebase since. The ori...

X Description: This PR revives #3930 as per the discussion at #4198 (comment). This PR aims to accomplish the same goals as #3930, but is updated based on changes that have happened in the codebase since. The ori...

Opengraph URL: https://github.com/github/codeql-action/pull/4212

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d93e3dc2-c40f-fedd-4b67-a9bd0bf88876
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFF0:12F69A:222944:2C78FC:6AED18E3
html-safe-nonceb99e133f1e42f42854eb1bb11ab78ee8d4be929bdf6f52f969bcec38d8b40e2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkYwOjEyRjY5QToyMjI5NDQ6MkM3OEZDOjZBRUQxOEUzIiwidmlzaXRvcl9pZCI6IjUzMDI2OTE1Nzg5MTkwNjU4MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccc612dcf976060c2fc8cfe9ebabd7e84a5227e875589bd97fcc2e484322d0154
hovercard-subject-tagpull_request:4777366612
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql-action/4212/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/469e4008e0baca398f4bd5dbe38ca95620153198b4c407f4c0604f621c799422/github/codeql-action/pull/4212
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/469e4008e0baca398f4bd5dbe38ca95620153198b4c407f4c0604f621c799422/github/codeql-action/pull/4212
og:image:altThis PR revives #3930 as per the discussion at #4198 (comment). This PR aims to accomplish the same goals as #3930, but is updated based on changes that have happened in the codebase since. The ori...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamembg
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/github/codeql-action git https://github.com/github/codeql-action.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id259445878
octolytics-dimension-repository_nwogithub/codeql-action
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id259445878
octolytics-dimension-repository_network_root_nwogithub/codeql-action
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/github/codeql-action/pull/4212#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F4212
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F4212
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql-action
Reloadhttps://github.com/github/codeql-action/pull/4212
Reloadhttps://github.com/github/codeql-action/pull/4212
Reloadhttps://github.com/github/codeql-action/pull/4212
githubhttps://github.com/github
codeql-actionhttps://github.com/github/codeql-action
Codehttps://github.com/github/codeql-action
Issues163 (163)https://github.com/github/codeql-action/issues
Pull requests41 (41)https://github.com/github/codeql-action/pulls
Actionshttps://github.com/github/codeql-action/actions
Security and quality2 (2)https://github.com/github/codeql-action/security
Insightshttps://github.com/github/codeql-action/pulse
https://github.com/github/codeql-action
mbghttps://github.com/mbg
mainhttps://github.com/github/codeql-action/tree/main
mbg/tests/fix-export-variable-2https://github.com/github/codeql-action/tree/mbg/tests/fix-export-variable-2
Conversationhttps://github.com/github/codeql-action/pull/4212
Commits7 (7)https://github.com/github/codeql-action/pull/4212/commits
Checkshttps://github.com/github/codeql-action/pull/4212/checks
Files changedhttps://github.com/github/codeql-action/pull/4212/files
Do not use core.exportVariable in unit tests (2nd attempt)https://github.com/github/codeql-action/pull/4212#top
mbghttps://github.com/mbg
mainhttps://github.com/github/codeql-action/tree/main
mbg/tests/fix-export-variable-2https://github.com/github/codeql-action/tree/mbg/tests/fix-export-variable-2
https://github.com/mbg
mbghttps://github.com/mbg
Oct 7, 2026https://github.com/github/codeql-action/pull/4212#issue-5750548613
#3930https://github.com/github/codeql-action/pull/3930
#4198 (comment)https://github.com/github/codeql-action/pull/4198#discussion_r4209290406
#3930https://github.com/github/codeql-action/pull/3930
we already clear environment variables that are set during unit testshttps://github.com/github/codeql-action/blob/0fb8a6672b5f51d3dc5bf6c25f7c19591ddd842c/src/testing-utils.ts#L146
changeloghttps://github.com/github/codeql-action/blob/main/CHANGELOG.md
readmehttps://github.com/github/codeql-action/blob/main/README.md
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
mbghttps://github.com/mbg
October 7, 2026 20:12https://github.com/github/codeql-action/pull/4212#commits-pushed-63c5299
https://github.com/mbg
Move isInTestMode to environment.tshttps://github.com/github/codeql-action/pull/4212/commits/63c529979039e72d333b3758905228aa4d227785
63c5299https://github.com/github/codeql-action/pull/4212/commits/63c529979039e72d333b3758905228aa4d227785
https://github.com/mbg
Add wrapper around core.exportVariablehttps://github.com/github/codeql-action/pull/4212/commits/1728f0c676027d01c7e878d19f05b6d7970ff967
1728f0chttps://github.com/github/codeql-action/pull/4212/commits/1728f0c676027d01c7e878d19f05b6d7970ff967
https://github.com/mbg
Add basic eslint enforcementhttps://github.com/github/codeql-action/pull/4212/commits/59ff83ecef15b13c0ae74b6a22a26ddc1250dbab
59ff83ehttps://github.com/github/codeql-action/pull/4212/commits/59ff83ecef15b13c0ae74b6a22a26ddc1250dbab
https://github.com/mbg
Add NODE_ENV as safe environment variablehttps://github.com/github/codeql-action/pull/4212/commits/75ea4cb2e4a573dea67a45cbdb9c63d94414d41b
75ea4cbhttps://github.com/github/codeql-action/pull/4212/commits/75ea4cb2e4a573dea67a45cbdb9c63d94414d41b
https://github.com/mbg
Deprecate isInTestMode in favour of a more clearly named methodhttps://github.com/github/codeql-action/pull/4212/commits/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5
ebd711fhttps://github.com/github/codeql-action/pull/4212/commits/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
size/M https://github.com/github/codeql-action/issues?q=state%3Aopen%20label%3Asize%2FM
Oct 7, 2026https://github.com/github/codeql-action/pull/4212#event-32719436404
https://github.com/mbg
mbghttps://github.com/mbg
Oct 7, 2026 https://github.com/github/codeql-action/pull/4212#ref-pullrequest-4503232900
Do not use core.exportVariable in unit tests #3930 https://github.com/github/codeql-action/pull/3930
https://github.com/mbg
mbghttps://github.com/mbg
October 8, 2026 09:57https://github.com/github/codeql-action/pull/4212#event-32772111775
https://github.com/mbg
mbghttps://github.com/mbg
code ownerhttps://github.com/github/codeql-action/blob/e0b52dbdc5c3376dd8cb78e956fd23fa07ca2c5b/CODEOWNERS#L1
October 8, 2026 09:57https://github.com/github/codeql-action/pull/4212#event-32772113082
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
October 8, 2026 09:57https://github.com/github/codeql-action/pull/4212#event-32772113254
https://github.com/mbg
mbghttps://github.com/mbg
Oct 8, 2026 https://github.com/github/codeql-action/pull/4212#ref-pullrequest-5730989712
Use setup-codeql logic for finding release assets in start-proxy #4198 https://github.com/github/codeql-action/pull/4198
started reviewinghttps://github.com/github/codeql-action/sessions/21e8e48c-5a95-44ed-9ec8-9576b327789b
mbghttps://github.com/mbg
October 8, 2026 09:57https://github.com/github/codeql-action/pull/4212#event-32772158132
View session https://github.com/github/codeql-action/sessions/21e8e48c-5a95-44ed-9ec8-9576b327789b
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Oct 8, 2026 https://github.com/github/codeql-action/pull/4212#pullrequestreview-5454854027
View reviewed changes https://github.com/github/codeql-action/pull/4212/files/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql-action/pull/4212#pullrequestreview-5454854027
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Excluding content from Copilothttps://docs.github.com/en/copilot/how-tos/configure-content-exclusion/exclude-content-from-copilot
NODE_ENV=test misclassifies workflows and skips GITHUB_ENV exportshttps://github.com/github/codeql-action/pull/4212#discussion_r4217527833
this surveyhttps://survey.alchemer.com/s3/9011660/CCR-Public-Preview-Autoapprove-feedback-survey
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
src/environment.tshttps://github.com/github/codeql-action/pull/4212/files/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
https://github.com/henrymercer
henrymercerhttps://github.com/henrymercer
Oct 8, 2026 https://github.com/github/codeql-action/pull/4212#pullrequestreview-5456063890
View reviewed changes https://github.com/github/codeql-action/pull/4212/files/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5
src/environment.tshttps://github.com/github/codeql-action/pull/4212/files/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
eslint.config.mjshttps://github.com/github/codeql-action/pull/4212/files/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
https://github.com/mbg
Rename exportVariable wrapper to exportEnvVarhttps://github.com/github/codeql-action/pull/4212/commits/d6196d87032950013b37a419798b7e74ee12d305
d6196d8https://github.com/github/codeql-action/pull/4212/commits/d6196d87032950013b37a419798b7e74ee12d305
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
size/L https://github.com/github/codeql-action/issues?q=state%3Aopen%20label%3Asize%2FL
size/M https://github.com/github/codeql-action/issues?q=state%3Aopen%20label%3Asize%2FM
Oct 8, 2026https://github.com/github/codeql-action/pull/4212#event-32818518171
https://github.com/mbg
mbghttps://github.com/mbg
henrymercerhttps://github.com/henrymercer
October 8, 2026 19:19https://github.com/github/codeql-action/pull/4212#event-32818592540
https://github.com/mbg
Add and use __CODEQL_ACTION_TEST_ENV__ in testshttps://github.com/github/codeql-action/pull/4212/commits/bd97dda6bf153afcaf41c6c5ef65567738a1b4c7
bd97ddahttps://github.com/github/codeql-action/pull/4212/commits/bd97dda6bf153afcaf41c6c5ef65567738a1b4c7
https://github.com/mbg
mbghttps://github.com/mbg
force-pushedhttps://github.com/github/codeql-action/compare/932633465bf3bceb7aa0681be6d51befbcb82257..bd97dda6bf153afcaf41c6c5ef65567738a1b4c7
9326334https://github.com/github/codeql-action/commit/932633465bf3bceb7aa0681be6d51befbcb82257
bd97ddahttps://github.com/github/codeql-action/commit/bd97dda6bf153afcaf41c6c5ef65567738a1b4c7
Compare https://github.com/github/codeql-action/compare/932633465bf3bceb7aa0681be6d51befbcb82257..bd97dda6bf153afcaf41c6c5ef65567738a1b4c7
October 8, 2026 19:23https://github.com/github/codeql-action/pull/4212#event-32818865904
https://github.com/henrymercer
henrymercerhttps://github.com/henrymercer
Oct 9, 2026 https://github.com/github/codeql-action/pull/4212#pullrequestreview-5468146429
View reviewed changes https://github.com/github/codeql-action/pull/4212/files/bd97dda6bf153afcaf41c6c5ef65567738a1b4c7
src/environment.tshttps://github.com/github/codeql-action/pull/4212/files/bd97dda6bf153afcaf41c6c5ef65567738a1b4c7#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
henrymercerhttps://github.com/henrymercer
Oct 9, 2026https://github.com/github/codeql-action/pull/4212#discussion_r4228554580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
src/environment.tshttps://github.com/github/codeql-action/pull/4212/files/bd97dda6bf153afcaf41c6c5ef65567738a1b4c7#diff-c0b3266a3c4f1c4857b2a8bc79c4b463560bb7da30deb7c2b6e852f705723827
henrymercerhttps://github.com/henrymercer
Oct 9, 2026https://github.com/github/codeql-action/pull/4212#discussion_r4228557163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
mbghttps://github.com/mbg
Oct 9, 2026https://github.com/github/codeql-action/pull/4212#discussion_r4232879667
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
https://github.com/mbg
mbghttps://github.com/mbg
Oct 9, 2026https://github.com/github/codeql-action/pull/4212#issuecomment-6086070770
@henrymercerhttps://github.com/henrymercer
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
https://github.com/mbg
mbghttps://github.com/mbg
merge queuehttps://github.com/github/codeql-action/queue/main
Oct 9, 2026https://github.com/github/codeql-action/pull/4212#event-32896550479
68f5b57https://github.com/github/codeql-action/commit/68f5b579fa154fb96eff5bbb1ed43fc06f8c79f1
Oct 9, 2026https://github.com/github/codeql-action/pull/4212#event-32897316523
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
https://github.com/mbg
mbghttps://github.com/mbg
October 9, 2026 17:51https://github.com/github/codeql-action/pull/4212#event-32897318896
Merge main into releases/v4 dsp-testing/mario-campos-post-comment-test#6 https://github.com/dsp-testing/mario-campos-post-comment-test/pull/6
Merge main into releases/v4 #4239 https://github.com/github/codeql-action/pull/4239
Merge releases/v4 into releases/v3 #4241 https://github.com/github/codeql-action/pull/4241
https://github.co/hiddenchars
https://github.com/github/codeql-action/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F4212
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/github/codeql-action/pull/4212/files/ebd711ff66bdfe20f4c22a0eeced541bcb5e9fe5
https://github.com/henrymercer
henrymercer https://github.com/henrymercer
https://github.com/github/codeql-action/pull/4212/files/bd97dda6bf153afcaf41c6c5ef65567738a1b4c7
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
size/L https://github.com/github/codeql-action/issues?q=state%3Aopen%20label%3Asize%2FL
Please reload this pagehttps://github.com/github/codeql-action/pull/4212
https://github.com/mbg
https://github.com/henrymercer
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.