Title: Fix merge conflict handling in the rebuild workflow by henrymercer · Pull Request #4191 · github/codeql-action · GitHub
Open Graph Title: Fix merge conflict handling in the rebuild workflow by henrymercer · Pull Request #4191 · github/codeql-action
X Title: Fix merge conflict handling in the rebuild workflow by henrymercer · Pull Request #4191 · github/codeql-action
Description: The rebuild workflow is meant to continue when merging the base branch only conflicts in lib, since rebuilding regenerates it. Since #3568, any conflict has failed the merge step instead, for example in this run. Steps run with bash -e, so a conflicting git merge ended the step before its exit code was recorded. The step now runs git merge as an if condition, which -e doesn't apply to, and continues only if MERGE_HEAD shows the merge is still in progress. Fixing that alone would have exposed a second bug: under pipefail, the check for conflicts outside lib never triggered, because git diff --check exits non-zero whenever it finds a conflict marker, including in lib. The check now lists unmerged paths with git diff --name-only --diff-filter=U, which also catches conflicts without markers, such as modify/delete conflicts. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Environments: Testing/None - This change does not impact any CodeQL workflows in production. How did/will you validate this change? Other - I ran the merge step's script from the workflow under bash --noprofile --norc -e -o pipefail against scratch repositories. A clean merge passes, conflicts only in lib continue and set merge-in-progress, and content or modify/delete conflicts in src fail and list the file. I also ran the whole workflow on a temporary branch with the same conflict in lib/entry-points.js as the linked run. It succeeded, and the merge commit it pushed had no conflict markers. If something goes wrong after this change is released, what are the mitigation and rollback strategies? Development/testing only - This change cannot cause any failures in production. How will you know if something goes wrong after this change is released? Other - This change only affects the Rebuild Action workflow, so problems will show up as failed or incorrect rebuild runs. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: The rebuild workflow is meant to continue when merging the base branch only conflicts in lib, since rebuilding regenerates it. Since #3568, any conflict has failed the merge step instead, for examp...
X Description: The rebuild workflow is meant to continue when merging the base branch only conflicts in lib, since rebuilding regenerates it. Since #3568, any conflict has failed the merge step instead, for examp...
Opengraph URL: https://github.com/github/codeql-action/pull/4191
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:598f6b63-8565-1f3a-22c9-887385c00ea2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9964:257A3D:7A9622:A335AC:6AED2695 |
| html-safe-nonce | 3b849049d5644d4cdd895ed851d2dafb7079d95e6488b58816a56d9dafe2bd09 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTY0OjI1N0EzRDo3QTk2MjI6QTMzNUFDOjZBRUQyNjk1IiwidmlzaXRvcl9pZCI6IjI3OTYyMTE5MDQwNzE5MzU2MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fd1eb5f28ac69605fd75eb6a991648f43c29cbd9ebacb99b784520f19e130a49 |
| hovercard-subject-tag | pull_request:4718471957 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/4191/files |
| twitter:image | https://avatars.githubusercontent.com/u/14129055?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14129055?s=400&v=4 |
| og:image:alt | The rebuild workflow is meant to continue when merging the base branch only conflicts in lib, since rebuilding regenerates it. Since #3568, any conflict has failed the merge step instead, for examp... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 98b41fa4b5635ceb45a4c54320fced73817ff290 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width