Title: Disable `UsePerfData` for `resolveExtractor` by mbg · Pull Request #4162 · github/codeql-action · GitHub
Open Graph Title: Disable `UsePerfData` for `resolveExtractor` by mbg · Pull Request #4162 · github/codeql-action
X Title: Disable `UsePerfData` for `resolveExtractor` by mbg · Pull Request #4162 · github/codeql-action
Description: Disables UsePerfData for codeql resolve extractor calls by default. This is not needed for the command to work correctly and reduces the risk of failures resulting from a race condition if the CLI is invoked concurrently (example). This is currently possible if we are analysing multiple languages at the same time, because we invoke codeql resolve extractor in parallel for each language. We could consider disabling UsePerfData for other CLI calls as well, but this PR is a minimal change to resolve the immediate issue we have observed in our CI that sometimes occurs as a result of the possible race condition. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Workflow types: Advanced setup - Impacts users who have custom CodeQL workflows. Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...). Products: Code Scanning - The changes impact analyses when analysis-kinds: code-scanning. Code Quality - The changes impact analyses when analysis-kinds: code-quality. Other first-party - The changes impact other first-party analyses. Third-party analyses - The changes affect the upload-sarif action. Environments: Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency. GHES - Impacts CodeQL workflows on GitHub Enterprise Server. How did/will you validate this change? End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks). If something goes wrong after this change is released, what are the mitigation and rollback strategies? Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix. How will you know if something goes wrong after this change is released? Telemetry - I rely on existing telemetry or have made changes to the telemetry. Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release. Alerts - New or existing monitors will trip if something goes wrong with this change. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Special considerations - This change should only be merged once certain preconditions are met. Please provide details of those or link to this PR from an internal issue. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: Disables UsePerfData for codeql resolve extractor calls by default. This is not needed for the command to work correctly and reduces the risk of failures resulting from a race condition if the CLI ...
X Description: Disables UsePerfData for codeql resolve extractor calls by default. This is not needed for the command to work correctly and reduces the risk of failures resulting from a race condition if the CLI ...
Opengraph URL: https://github.com/github/codeql-action/pull/4162
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d6867991-724c-c4e2-5a5e-ebd9b91d60ba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC58:34BF50:816299:ADB68E:6AED28E1 |
| html-safe-nonce | 4504596e2242eeaec7f0c188f97d31a964bfd1e7b520a56e846b4ec2b3608e3c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzU4OjM0QkY1MDo4MTYyOTk6QURCNjhFOjZBRUQyOEUxIiwidmlzaXRvcl9pZCI6IjY4MjQ2MzQzNTg2MTA4NjQzNTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1f1f4655d35aeed943946fa253883602f530bf6dba457c1217e81819dc7d8c83 |
| hovercard-subject-tag | pull_request:4612291473 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/4162/files |
| twitter:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| og:image:alt | Disables UsePerfData for codeql resolve extractor calls by default. This is not needed for the command to work correctly and reduces the risk of failures resulting from a race condition if the CLI ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 98b41fa4b5635ceb45a4c54320fced73817ff290 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width