Title: Ignore configuration file repo property for unsupported analysis kinds by mbg · Pull Request #4046 · github/codeql-action · GitHub
Open Graph Title: Ignore configuration file repo property for unsupported analysis kinds by mbg · Pull Request #4046 · github/codeql-action
X Title: Ignore configuration file repo property for unsupported analysis kinds by mbg · Pull Request #4046 · github/codeql-action
Description: This PR is a crude change to ignore the configuration file repository property if analysis-kinds is anything other than just code-scanning. This addresses a potential issue where we want to have a custom configuration file containing query customisations for a repo that has both Code Scanning and Code Quality enabled. We do not currently support query customisation for Code Quality, so that would then result in an error and prevent query customisation via the configuration file. Notes for reviewers This is intended merely as a quick fix if we consider the above issue to be sufficiently significant. We could accept the issue and suggest use of the github-codeql-extra-queries property for query customisation in affected repositories instead. A better solution (but which will take more time) is to not fail/ignore if query customisation is applied to a Code Quality analysis or support it. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Workflow types: Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...). Products: Code Quality - The changes impact analyses when analysis-kinds: code-quality. Other first-party - The changes impact other first-party analyses. Environments: Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency. GHES - Impacts CodeQL workflows on GitHub Enterprise Server. How did/will you validate this change? Test repository - This change will be tested on a test repository before merging. Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files). End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks). If something goes wrong after this change is released, what are the mitigation and rollback strategies? Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix. How will you know if something goes wrong after this change is released? Telemetry - I rely on existing telemetry or have made changes to the telemetry. Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release. Alerts - New or existing monitors will trip if something goes wrong with this change. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: This PR is a crude change to ignore the configuration file repository property if analysis-kinds is anything other than just code-scanning. This addresses a potential issue where we want to have a ...
X Description: This PR is a crude change to ignore the configuration file repository property if analysis-kinds is anything other than just code-scanning. This addresses a potential issue where we want to have a ...
Opengraph URL: https://github.com/github/codeql-action/pull/4046
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f93c8184-0ded-e4c9-292d-d3907d2cafef |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E950:1051BB:2924F6:386EAC:6AED4933 |
| html-safe-nonce | 3837bffc78396276b8ce9fdae9928528d46e3c005570f2ac935241cdf6d0a8ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTUwOjEwNTFCQjoyOTI0RjY6Mzg2RUFDOjZBRUQ0OTMzIiwidmlzaXRvcl9pZCI6Ijg2NTA0MTI2NzI1MzQwMDYwNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fef427daf89d1d8d902012c04e741666dc7299fa9a28f3c97fcf2c2e1515a95f |
| hovercard-subject-tag | pull_request:4142312094 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/4046/files |
| twitter:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| og:image:alt | This PR is a crude change to ignore the configuration file repository property if analysis-kinds is anything other than just code-scanning. This addresses a potential issue where we want to have a ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width