Title: Remove `ready_for_review` triggers from workflows by mbg · Pull Request #3969 · github/codeql-action · GitHub
Open Graph Title: Remove `ready_for_review` triggers from workflows by mbg · Pull Request #3969 · github/codeql-action
X Title: Remove `ready_for_review` triggers from workflows by mbg · Pull Request #3969 · github/codeql-action
Description: For CI-generated commits, we have used the workaround of creating draft PRs and marking them as "Ready for review" to trigger workflows using the ready_for_review type for pull_request events. This appears to no longer be necessary, because we can now click on the "Approve workflow runs" button in the UI instead. This PR removes the ready_for_review triggers we had specifically for this purpose (allowing us to revert to not specifying the event types at all, because the remaining list matches the default list). It also updates the automation where we create PRs to no longer create or mark them as drafts. Removing the ready_for_review triggers has the additional benefit that, for regular PRs, we no longer end up running the workflows twice if they have already run while the PR was a draft. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Environments: Testing/None - This change does not impact any CodeQL workflows in production. How did/will you validate this change? Other - Please provide details. Validated this approach in a different repository which has the same scenario. If something goes wrong after this change is released, what are the mitigation and rollback strategies? Development/testing only - This change cannot cause any failures in production. How will you know if something goes wrong after this change is released? Other - Please provide details. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: For CI-generated commits, we have used the workaround of creating draft PRs and marking them as "Ready for review" to trigger workflows using the ready_for_review type for pull_request ev...
X Description: For CI-generated commits, we have used the workaround of creating draft PRs and marking them as "Ready for review" to trigger workflows using the ready_for_review type for pull_re...
Opengraph URL: https://github.com/github/codeql-action/pull/3969
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e44e2d19-d6e7-d422-e358-f3b98fe9ef38 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8052:1070C6:11FF64:183C4D:6A4C20BD |
| html-safe-nonce | f3c0bdbd292ecf6c4399bda035ec09a05cce9823aa2ecfbfb295c70e75c5a419 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDUyOjEwNzBDNjoxMUZGNjQ6MTgzQzREOjZBNEMyMEJEIiwidmlzaXRvcl9pZCI6IjU3MzA2NjI5NTk0NjMyNzY3MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6ed606c2ea7e427ef762da57f12371de3d5119452b2f62e7b64b501e07ead7d0 |
| hovercard-subject-tag | pull_request:3911886000 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/3969/files |
| twitter:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| og:image:alt | For CI-generated commits, we have used the workaround of creating draft PRs and marking them as "Ready for review" to trigger workflows using the ready_for_review type for pull_request ev... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1b6b16d04026f131a36d57e3b01d0f4d26a51800edf48bf5ed0256e0ac905511 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f95fb36c72adc940ff991c03531114b2245658d0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width