Title: Add more strongly typed wrapper around `test.macro` by mbg · Pull Request #3883 · github/codeql-action · GitHub
Open Graph Title: Add more strongly typed wrapper around `test.macro` by mbg · Pull Request #3883 · github/codeql-action
X Title: Add more strongly typed wrapper around `test.macro` by mbg · Pull Request #3883 · github/codeql-action
Description: When defining a test macro using test.macro, the argument types are not strongly enforced when the macro is used with test, test.serial, etc. This PR adds a makeMacro helper which returns a wrapper around a macro that enforces the argument types. Replaces #3873. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Environments: Testing/None - This change does not impact any CodeQL workflows in production. How did/will you validate this change? Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files). If something goes wrong after this change is released, what are the mitigation and rollback strategies? Development/testing only - This change cannot cause any failures in production. How will you know if something goes wrong after this change is released? Other - Please provide details. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: When defining a test macro using test.macro, the argument types are not strongly enforced when the macro is used with test, test.serial, etc. This PR adds a makeMacro helper which returns a wrapper...
X Description: When defining a test macro using test.macro, the argument types are not strongly enforced when the macro is used with test, test.serial, etc. This PR adds a makeMacro helper which returns a wrapper...
Opengraph URL: https://github.com/github/codeql-action/pull/3883
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dc375057-317f-b402-40a8-29a6774908d2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 94CC:282357:2FE3DF6:43B3C09:6A4D001D |
| html-safe-nonce | fd7d35f9a81e7831d883b0014843f58dd3f76b09a44be31a6456c9432ba53cf0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NENDOjI4MjM1NzoyRkUzREY2OjQzQjNDMDk6NkE0RDAwMUQiLCJ2aXNpdG9yX2lkIjoiMjEyNTY5MTU2NTU0NDExMjE1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 555677eed8d7947313e0aae74149799e48fe34c153c726a4be23a279d53e6d25 |
| hovercard-subject-tag | pull_request:3643554666 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/3883/files |
| twitter:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| og:image:alt | When defining a test macro using test.macro, the argument types are not strongly enforced when the macro is used with test, test.serial, etc. This PR adds a makeMacro helper which returns a wrapper... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fb70bd3c4b2bec429781b65419e912c66e2d5581 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width