Title: Add random suffix when writing diagnostics to avoid filename collisions by henrymercer · Pull Request #3852 · github/codeql-action · GitHub
Open Graph Title: Add random suffix when writing diagnostics to avoid filename collisions by henrymercer · Pull Request #3852 · github/codeql-action
X Title: Add random suffix when writing diagnostics to avoid filename collisions by henrymercer · Pull Request #3852 · github/codeql-action
Description: Fixed a bug where two diagnostics produced within the same millisecond could overwrite each other on disk, causing one of them to be lost. We could also add the source ID to the filename, but that doesn't protect against multiple diagnostics from the same source, and would be more likely to hit file path length limits. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Workflow types: Advanced setup - Impacts users who have custom CodeQL workflows. Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...). Products: Code Scanning - The changes impact analyses when analysis-kinds: code-scanning. Code Quality - The changes impact analyses when analysis-kinds: code-quality. Other first-party - The changes impact other first-party analyses. Third-party analyses - The changes affect the upload-sarif action. Environments: Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency. GHES - Impacts CodeQL workflows on GitHub Enterprise Server. How did/will you validate this change? End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks). If something goes wrong after this change is released, what are the mitigation and rollback strategies? Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix. How will you know if something goes wrong after this change is released? Telemetry - I rely on existing telemetry or have made changes to the telemetry. Alerts - New or existing monitors will trip if something goes wrong with this change. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: Fixed a bug where two diagnostics produced within the same millisecond could overwrite each other on disk, causing one of them to be lost. We could also add the source ID to the filename, but that ...
X Description: Fixed a bug where two diagnostics produced within the same millisecond could overwrite each other on disk, causing one of them to be lost. We could also add the source ID to the filename, but that ...
Opengraph URL: https://github.com/github/codeql-action/pull/3852
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4bf7d452-a5b2-9a89-2c88-fe4d5e507862 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFAA:13B1D:731C7D:9DF3CB:6A4C7F98 |
| html-safe-nonce | 7ba42a6aacb8fb69712044d608dec3cadfd12d5b574c69adf872bca8b1e2da95 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkFBOjEzQjFEOjczMUM3RDo5REYzQ0I6NkE0QzdGOTgiLCJ2aXNpdG9yX2lkIjoiNzI4NjE1MTc2MDQ3OTg0NTM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8c1f14915c4b9128e6dfc13816702b348f1fa98cbabc2f22f1ae77343b730940 |
| hovercard-subject-tag | pull_request:3595306839 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/3852/files |
| twitter:image | https://avatars.githubusercontent.com/u/14129055?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14129055?s=400&v=4 |
| og:image:alt | Fixed a bug where two diagnostics produced within the same millisecond could overwrite each other on disk, causing one of them to be lost. We could also add the source ID to the filename, but that ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd470457e909b9d062f8002cf438ba870e6acff6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width