Title: Add tests for getCredentials with multiple goproxy_servers and maven_… by mario-campos · Pull Request #3799 · github/codeql-action · GitHub
Open Graph Title: Add tests for getCredentials with multiple goproxy_servers and maven_… by mario-campos · Pull Request #3799 · github/codeql-action
X Title: Add tests for getCredentials with multiple goproxy_servers and maven_… by mario-campos · Pull Request #3799 · github/codeql-action
Description: This PR adds two new tests to the start-proxy action, to assert that registry configurations with more than one registry of the same kind (two goproxy_server and two maven_repository in this case) are parsed and reported appropriately. While one additional test would be sufficient to test this multi-registry use-case, I thought two tests across two languages offered a bit more safety. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Workflow types: Advanced setup - Impacts users who have custom CodeQL workflows. Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...). Products: Code Scanning - The changes impact analyses when analysis-kinds: code-scanning. Code Quality - The changes impact analyses when analysis-kinds: code-quality. Environments: Testing/None - This change does not impact any CodeQL workflows in production. How did/will you validate this change? Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files). If something goes wrong after this change is released, what are the mitigation and rollback strategies? Development/testing only - This change cannot cause any failures in production. How will you know if something goes wrong after this change is released? Other - I expect a PR check to fail if these tests are implemented incorrectly. Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: This PR adds two new tests to the start-proxy action, to assert that registry configurations with more than one registry of the same kind (two goproxy_server and two maven_repository in this case) ...
X Description: This PR adds two new tests to the start-proxy action, to assert that registry configurations with more than one registry of the same kind (two goproxy_server and two maven_repository in this case) ...
Opengraph URL: https://github.com/github/codeql-action/pull/3799
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:554aed26-3d26-fd1c-f120-5e662ae3c1af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E480:3FCB4A:2D76C8:3FFB84:6A4C9F6C |
| html-safe-nonce | b6322fe3d9977ba073ae2fc3274ec6b6271af5144d1752121993398da4492e7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDgwOjNGQ0I0QToyRDc2Qzg6M0ZGQjg0OjZBNEM5RjZDIiwidmlzaXRvcl9pZCI6IjQxOTEwMjYxOTg3MDcyMTYyMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2d9f65b0fbbd44fd87dc790d7845e7bfc633da5327ecbc68462aad4cd93ae5c6 |
| hovercard-subject-tag | pull_request:3483038955 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/3799/files |
| twitter:image | https://avatars.githubusercontent.com/u/1663284?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1663284?s=400&v=4 |
| og:image:alt | This PR adds two new tests to the start-proxy action, to assert that registry configurations with more than one registry of the same kind (two goproxy_server and two maven_repository in this case) ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ae90d426644ca15e89bacceb72e51f4e9dbf85f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width