Title: Update eslint to v9 by henrymercer · Pull Request #3497 · github/codeql-action · GitHub
Open Graph Title: Update eslint to v9 by henrymercer · Pull Request #3497 · github/codeql-action
X Title: Update eslint to v9 by henrymercer · Pull Request #3497 · github/codeql-action
Description: This PR updates eslint to v9. It is too early to update to v10 since some of our linter plugins don't yet have support. The eslint config file has changed substantially due to converting to flat config and changes to upstream plugins. I have attempted to ensure that the rules we are running are the same, and note that there is only one change to disable directives, which is to remove a while (true) statement that is no longer flagged by the no constant condition linting rule. However this PR would benefit from a careful look at this config file. I checked import/no-cycle manually, since this has caught user-visible issues for us in the past. Strangely I could not get import/no-cycle to work with eslint v9. It ran, but did not detect an example import cycle. I have replaced it by import-x/no-cycle, but it's still odd to me that this didn't work initially. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Environments: Testing/None - This change does not impact any CodeQL workflows in production. How did/will you validate this change? Going through linter plugins to check rules, confirming other disable directives are still required. If something goes wrong after this change is released, what are the mitigation and rollback strategies? Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix. How will you know if something goes wrong after this change is released? n/a Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: This PR updates eslint to v9. It is too early to update to v10 since some of our linter plugins don't yet have support. The eslint config file has changed substantially due to converting to fl...
X Description: This PR updates eslint to v9. It is too early to update to v10 since some of our linter plugins don't yet have support. The eslint config file has changed substantially due to converting t...
Opengraph URL: https://github.com/github/codeql-action/pull/3497
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fd27967f-699a-cb51-0279-2e7f123b3d28 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4C6:951F5:DF4D5C:143D0EB:6A4CC681 |
| html-safe-nonce | cf6bc28ef78fffb0cf0d8fe2d48011a93700d7e70e8b3d8819ff1a56828fe2b1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEM2Ojk1MUY1OkRGNEQ1QzoxNDNEMEVCOjZBNENDNjgxIiwidmlzaXRvcl9pZCI6IjgxNDIzMjI0ODY2OTc4MzgyMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d46d459896eef8c2560d54305631d38905655d1b917bb0176b9c27f536895d3e |
| hovercard-subject-tag | pull_request:3308621269 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/3497/files |
| twitter:image | https://avatars.githubusercontent.com/u/14129055?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14129055?s=400&v=4 |
| og:image:alt | This PR updates eslint to v9. It is too early to update to v10 since some of our linter plugins don't yet have support. The eslint config file has changed substantially due to converting to fl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d0da0eb92994395299ed4450bf67b0373005be36 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width