Title: Disable TypeScript `noUnusedLocals` and `noUnusedParameters` options, already covered by eslint by mbg · Pull Request #3464 · github/codeql-action · GitHub
Open Graph Title: Disable TypeScript `noUnusedLocals` and `noUnusedParameters` options, already covered by eslint by mbg · Pull Request #3464 · github/codeql-action
X Title: Disable TypeScript `noUnusedLocals` and `noUnusedParameters` options, already covered by eslint by mbg · Pull Request #3464 · github/codeql-action
Description: Probably a controversial change, but: We already use eslint, which has the same rules configured. eslint allows the equivalent errors to be suppressed with comments. TypeScript allows unused parameter errors to be suppressed with a leading _ in the name, but there is no way to suppress unused locals. While working on changes, it is annoying to get errors for this when testing partially complete code. Meanwhile eslint can be run on demand when it makes sense. Risk assessment For internal use only. Please select the risk level of this change: Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only. Which use cases does this change impact? Testing/None - This change does not impact any CodeQL workflows in production. How did/will you validate this change? None - I am not validating these changes. If something goes wrong after this change is released, what are the mitigation and rollback strategies? Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix. How will you know if something goes wrong after this change is released? N/A Are there any special considerations for merging or releasing this change? No special considerations - This change can be merged at any time. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Consider adding a changelog entry for this change. Confirm the readme and docs have been updated if necessary.
Open Graph Description: Probably a controversial change, but: We already use eslint, which has the same rules configured. eslint allows the equivalent errors to be suppressed with comments. TypeScript allows unused param...
X Description: Probably a controversial change, but: We already use eslint, which has the same rules configured. eslint allows the equivalent errors to be suppressed with comments. TypeScript allows unused param...
Opengraph URL: https://github.com/github/codeql-action/pull/3464
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5e4e4936-330b-cd55-62a8-4538a219400a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF00:110179:908CA5:C4D285:6A4D4B12 |
| html-safe-nonce | 2b60e866fbaea6528c3f4e40a10af1c1d698c4b7711ec82f7a7a89360fdf46c3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjAwOjExMDE3OTo5MDhDQTU6QzREMjg1OjZBNEQ0QjEyIiwidmlzaXRvcl9pZCI6IjQyMTc0NjgxMDkwMzA1MDkzMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e5edafdabbb04ff72dc9dcc7ce0595fb9b2973eb32963784e7a49521d8c2a6ba |
| hovercard-subject-tag | pull_request:3252484326 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/3464/files |
| twitter:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/278086?s=400&v=4 |
| og:image:alt | Probably a controversial change, but: We already use eslint, which has the same rules configured. eslint allows the equivalent errors to be suppressed with comments. TypeScript allows unused param... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fc8347865a14e2ec811533d68f929cf4e0ec19 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width