René's URL Explorer Experiment


Title: Handle the case where branches may be strings, wildcards by simon-engledew · Pull Request #332 · github/codeql-action · GitHub

Open Graph Title: Handle the case where branches may be strings, wildcards by simon-engledew · Pull Request #332 · github/codeql-action

X Title: Handle the case where branches may be strings, wildcards by simon-engledew · Pull Request #332 · github/codeql-action

Description: Actions for running CodeQL analysis. Contribute to github/codeql-action development by creating an account on GitHub.

Open Graph Description: This PR: fixes an oversight where branches could also be set to a string handles wildcard branches, testing if they overlap or not

X Description: This PR: fixes an oversight where branches could also be set to a string handles wildcard branches, testing if they overlap or not

Opengraph URL: https://github.com/github/codeql-action/pull/332

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:eeee30db-cdba-f16d-4d5f-833f3b983794
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87BA:39F5AD:BE563B:1048833:6A53A2E1
html-safe-noncef33a6a596fc5844958e891681a3790269dfae3e813fd5ee4a9d2f768ca1c2211
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0JBOjM5RjVBRDpCRTU2M0I6MTA0ODgzMzo2QTUzQTJFMSIsInZpc2l0b3JfaWQiOiI3MjYzNjIwOTA0MzQwNjYwOTYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacef94371f59b2ef2b5d2b33f62dbc1c4d6109106f4eb27351ac267b81eb27de11
hovercard-subject-tagpull_request:530256664
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/332
twitter:imagehttps://opengraph.githubassets.com/d2b23364c40e6b5fb3f954b36c5d96f55d1b7b881050703f5889d75efe9a593b/github/codeql-action/pull/332
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d2b23364c40e6b5fb3f954b36c5d96f55d1b7b881050703f5889d75efe9a593b/github/codeql-action/pull/332
og:image:altThis PR: fixes an oversight where branches could also be set to a string handles wildcard branches, testing if they overlap or not
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesimon-engledew
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/github/codeql-action git https://github.com/github/codeql-action.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id259445878
octolytics-dimension-repository_nwogithub/codeql-action
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id259445878
octolytics-dimension-repository_network_root_nwogithub/codeql-action
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql-action/pull/332#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F332
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F332
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=github%2Fcodeql-action
Reloadhttps://github.com/github/codeql-action/pull/332
Reloadhttps://github.com/github/codeql-action/pull/332
Reloadhttps://github.com/github/codeql-action/pull/332
Please reload this pagehttps://github.com/github/codeql-action/pull/332
github https://github.com/github
codeql-actionhttps://github.com/github/codeql-action
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Fork 472 https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Star 1.6k https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Code https://github.com/github/codeql-action
Issues 156 https://github.com/github/codeql-action/issues
Pull requests 24 https://github.com/github/codeql-action/pulls
Actions https://github.com/github/codeql-action/actions
Models https://github.com/github/codeql-action/models
Security and quality 2 https://github.com/github/codeql-action/security
Insights https://github.com/github/codeql-action/pulse
Code https://github.com/github/codeql-action
Issues https://github.com/github/codeql-action/issues
Pull requests https://github.com/github/codeql-action/pulls
Actions https://github.com/github/codeql-action/actions
Models https://github.com/github/codeql-action/models
Security and quality https://github.com/github/codeql-action/security
Insights https://github.com/github/codeql-action/pulse
simon-engledewhttps://github.com/simon-engledew
mainhttps://github.com/github/codeql-action/tree/main
simon-engledew/string-brancheshttps://github.com/github/codeql-action/tree/simon-engledew/string-branches
Conversationhttps://github.com/github/codeql-action/pull/332
Commits15 (15)https://github.com/github/codeql-action/pull/332/commits
Checkshttps://github.com/github/codeql-action/pull/332/checks
Files changedhttps://github.com/github/codeql-action/pull/332/files
Handle the case where branches may be strings, wildcardshttps://github.com/github/codeql-action/pull/332#top
simon-engledewhttps://github.com/simon-engledew
mainhttps://github.com/github/codeql-action/tree/main
simon-engledew/string-brancheshttps://github.com/github/codeql-action/tree/simon-engledew/string-branches
https://github.com/simon-engledew
simon-engledewhttps://github.com/simon-engledew
Dec 1, 2020https://github.com/github/codeql-action/pull/332#issue-754339875
Please reload this pagehttps://github.com/github/codeql-action/pull/332
Please reload this pagehttps://github.com/github/codeql-action/pull/332
Handle the case where branches may be strings, including "*"https://github.com/github/codeql-action/pull/332/commits/ac1c081de895ff6e94b49e4d57d3e243ffa67602
ac1c081https://github.com/github/codeql-action/pull/332/commits/ac1c081de895ff6e94b49e4d57d3e243ffa67602
https://github.com/robertbrignull
robertbrignullhttps://github.com/robertbrignull
Dec 1, 2020 https://github.com/github/codeql-action/pull/332#pullrequestreview-541868713
View reviewed changes https://github.com/github/codeql-action/pull/332/files/ac1c081de895ff6e94b49e4d57d3e243ffa67602
robertbrignullhttps://github.com/robertbrignull
Please reload this pagehttps://github.com/github/codeql-action/pull/332
https://github.com/github/codeql-action/pull/332#pullrequestreview-541868713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
December 1, 2020 15:21https://github.com/github/codeql-action/pull/332#commits-pushed-c8ee1f4
Handle wildcard brancheshttps://github.com/github/codeql-action/pull/332/commits/c8ee1f4ef311e9b4a14bdaab96c8a9ed00f50d1b
c8ee1f4https://github.com/github/codeql-action/pull/332/commits/c8ee1f4ef311e9b4a14bdaab96c8a9ed00f50d1b
Add more test caseshttps://github.com/github/codeql-action/pull/332/commits/14719432ef949a2ae254216ca2037651305a3258
1471943https://github.com/github/codeql-action/pull/332/commits/14719432ef949a2ae254216ca2037651305a3258
Add more wildcard exampleshttps://github.com/github/codeql-action/pull/332/commits/145a3c1ed9a622a7db5f27a65e3e8952359cb787
145a3c1https://github.com/github/codeql-action/pull/332/commits/145a3c1ed9a622a7db5f27a65e3e8952359cb787
Have a catch all coded error for lint failureshttps://github.com/github/codeql-action/pull/332/commits/f99af1c014f725690f2c5aa3ad349c5e5e7fde0b
f99af1chttps://github.com/github/codeql-action/pull/332/commits/f99af1c014f725690f2c5aa3ad349c5e5e7fde0b
https://github.com/simon-engledew
simon-engledewhttps://github.com/simon-engledew
Dec 1, 2020https://github.com/github/codeql-action/pull/332#issuecomment-736636371
Please reload this pagehttps://github.com/github/codeql-action/pull/332
Please reload this pagehttps://github.com/github/codeql-action/pull/332
https://github.com/robertbrignull
robertbrignullhttps://github.com/robertbrignull
Dec 1, 2020https://github.com/github/codeql-action/pull/332#issuecomment-736686777
Please reload this pagehttps://github.com/github/codeql-action/pull/332
https://github.com/simon-engledew
simon-engledewhttps://github.com/simon-engledew
Dec 1, 2020https://github.com/github/codeql-action/pull/332#issuecomment-736689367
Please reload this pagehttps://github.com/github/codeql-action/pull/332
December 1, 2020 17:16https://github.com/github/codeql-action/pull/332#commits-pushed-b1be00d
Test the branch patterns work both wayshttps://github.com/github/codeql-action/pull/332/commits/b1be00db57562d91089f540cea70c301f50365ad
b1be00dhttps://github.com/github/codeql-action/pull/332/commits/b1be00db57562d91089f540cea70c301f50365ad
Do not show lint failed in the UX if it happenshttps://github.com/github/codeql-action/pull/332/commits/56b1ead679faebfa0cf769f08c879ed6acb253d2
56b1eadhttps://github.com/github/codeql-action/pull/332/commits/56b1ead679faebfa0cf769f08c879ed6acb253d2
https://github.com/robertbrignull
robertbrignullhttps://github.com/robertbrignull
Dec 1, 2020 https://github.com/github/codeql-action/pull/332#pullrequestreview-542178286
View reviewed changes https://github.com/github/codeql-action/pull/332/files/56b1ead679faebfa0cf769f08c879ed6acb253d2
robertbrignullhttps://github.com/robertbrignull
https://github.com/github/codeql-action/pull/332#pullrequestreview-542178286
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
src/actions-util.test.tshttps://github.com/github/codeql-action/pull/332/files/56b1ead679faebfa0cf769f08c879ed6acb253d2#diff-a776af20f7684e62a6a0c9686d6bd1872666b510a10d33bce0e892b4bc7b48e7
robertbrignullhttps://github.com/robertbrignull
Dec 1, 2020https://github.com/github/codeql-action/pull/332#discussion_r533627767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
simon-engledewhttps://github.com/simon-engledew
Dec 1, 2020https://github.com/github/codeql-action/pull/332#discussion_r533690098
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
src/init-action.tshttps://github.com/github/codeql-action/pull/332/files/56b1ead679faebfa0cf769f08c879ed6acb253d2#diff-87bf9e0a2a9244ba1f26eb01d404deaccbc9580479d2e2530a4ff2fd5bd91565
robertbrignullhttps://github.com/robertbrignull
Dec 1, 2020https://github.com/github/codeql-action/pull/332#discussion_r533628743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
simon-engledewhttps://github.com/simon-engledew
Dec 1, 2020https://github.com/github/codeql-action/pull/332#discussion_r533691620
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
src/actions-util.tshttps://github.com/github/codeql-action/pull/332/files/56b1ead679faebfa0cf769f08c879ed6acb253d2#diff-272a83a2815879238f61d8c6a4358a34cf98138946d7e7e950851282d8ca0b7d
robertbrignullhttps://github.com/robertbrignull
Dec 1, 2020https://github.com/github/codeql-action/pull/332#discussion_r533630867
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
simon-engledewhttps://github.com/simon-engledew
Dec 1, 2020https://github.com/github/codeql-action/pull/332#discussion_r533691189
Please reload this pagehttps://github.com/github/codeql-action/pull/332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
December 1, 2020 20:08https://github.com/github/codeql-action/pull/332#commits-pushed-4d86261
First iteration on feedbackhttps://github.com/github/codeql-action/pull/332/commits/4d862616ce467d271806d3c689386ba6fb9616a9
4d86261https://github.com/github/codeql-action/pull/332/commits/4d862616ce467d271806d3c689386ba6fb9616a9
Just convert the pattern into a RegExp...https://github.com/github/codeql-action/pull/332/commits/698e2a5487380139074ccdf3cb3953a47a8c34ac
698e2a5https://github.com/github/codeql-action/pull/332/commits/698e2a5487380139074ccdf3cb3953a47a8c34ac
https://github.com/simon-engledew
simon-engledewhttps://github.com/simon-engledew
Dec 1, 2020https://github.com/github/codeql-action/pull/332#issuecomment-736815376
Please reload this pagehttps://github.com/github/codeql-action/pull/332
December 2, 2020 08:34https://github.com/github/codeql-action/pull/332#commits-pushed-78b9d23
Remove unecessary if statementhttps://github.com/github/codeql-action/pull/332/commits/78b9d23d098694e0937a32f9a78da8266577e6a6
78b9d23https://github.com/github/codeql-action/pull/332/commits/78b9d23d098694e0937a32f9a78da8266577e6a6
Merge branch 'main' into simon-engledew/string-brancheshttps://github.com/github/codeql-action/pull/332/commits/ec8015bc03bb575406384c75313f12355a274fcb
ec8015bhttps://github.com/github/codeql-action/pull/332/commits/ec8015bc03bb575406384c75313f12355a274fcb
Add advanced test casehttps://github.com/github/codeql-action/pull/332/commits/107fe8422f6f41da96765110380257cdcfaa0114
107fe84https://github.com/github/codeql-action/pull/332/commits/107fe8422f6f41da96765110380257cdcfaa0114
https://github.com/simon-engledew
simon-engledewhttps://github.com/simon-engledew
Dec 2, 2020https://github.com/github/codeql-action/pull/332#event-4061303133
December 3, 2020 13:41https://github.com/github/codeql-action/pull/332#commits-pushed-7100f22
Add a bunch of tests cases and harden the function aganst malformed w…https://github.com/github/codeql-action/pull/332/commits/7100f2293270014f6345dc33ed14b70482f33af1
7100f22https://github.com/github/codeql-action/pull/332/commits/7100f2293270014f6345dc33ed14b70482f33af1
Merge remote-tracking branch 'origin/main' into simon-engledew/string…https://github.com/github/codeql-action/pull/332/commits/1dc40ba1654ad2ee7d0acb560d8c86a68b849e26
1dc40bahttps://github.com/github/codeql-action/pull/332/commits/1dc40ba1654ad2ee7d0acb560d8c86a68b849e26
https://github.com/robertbrignull
robertbrignullhttps://github.com/robertbrignull
Dec 4, 2020 https://github.com/github/codeql-action/pull/332#pullrequestreview-545012225
View reviewed changes https://github.com/github/codeql-action/pull/332/files/1dc40ba1654ad2ee7d0acb560d8c86a68b849e26
robertbrignullhttps://github.com/robertbrignull
https://github.com/github/codeql-action/pull/332#pullrequestreview-545012225
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/332
fix another edge casehttps://github.com/github/codeql-action/pull/332/commits/18c6a7d6d1aeae5683db105a64011887c9186f12
18c6a7dhttps://github.com/github/codeql-action/pull/332/commits/18c6a7d6d1aeae5683db105a64011887c9186f12
https://github.com/simon-engledew
simon-engledewhttps://github.com/simon-engledew
a43ce96https://github.com/github/codeql-action/commit/a43ce966aaa3824b10e10429a5b6365356cae362
Dec 4, 2020https://github.com/github/codeql-action/pull/332#event-4073469965
https://github.com/simon-engledew
simon-engledewhttps://github.com/simon-engledew
December 4, 2020 16:27https://github.com/github/codeql-action/pull/332#event-4073470019
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Dec 7, 2020 https://github.com/github/codeql-action/pull/332#ref-pullrequest-758318279
Merge main into v1 #338 https://github.com/github/codeql-action/pull/338
[Snyk] Fix for 21 vulnerabilities aliscco/codeql-action#85 https://github.com/aliscco/codeql-action/pull/85
[Snyk] Fix for 23 vulnerabilities aliscco/codeql-action#232 https://github.com/aliscco/codeql-action/pull/232
https://github.co/hiddenchars
https://github.com/github/codeql-action/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F332
https://github.com/robertbrignull
robertbrignull https://github.com/robertbrignull
https://github.com/github/codeql-action/pull/332/files/1dc40ba1654ad2ee7d0acb560d8c86a68b849e26
Please reload this pagehttps://github.com/github/codeql-action/pull/332
https://github.com/simon-engledew
https://github.com/robertbrignull
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.