René's URL Explorer Experiment


Title: Fix `upload-sarif` not uploading non-`.sarif` files by mbg · Pull Request #3157 · github/codeql-action · GitHub

Open Graph Title: Fix `upload-sarif` not uploading non-`.sarif` files by mbg · Pull Request #3157 · github/codeql-action

X Title: Fix `upload-sarif` not uploading non-`.sarif` files by mbg · Pull Request #3157 · github/codeql-action

Description: Actions for running CodeQL analysis. Contribute to github/codeql-action development by creating an account on GitHub.

Open Graph Description: Fixes #3156. In #3123, we inadvertently introduced a regression by using the same logic for uploading SARIF files as in the analyze Action: if a file ends in .quality.sarif, we upload it to Code Qu...

X Description: Fixes #3156. In #3123, we inadvertently introduced a regression by using the same logic for uploading SARIF files as in the analyze Action: if a file ends in .quality.sarif, we upload it to Code Qu...

Opengraph URL: https://github.com/github/codeql-action/pull/3157

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:38b8df8f-2153-dff7-14dd-4651eeff704d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8DC:28F606:239692:2FE406:6A526C91
html-safe-nonce06e7a9ba53595fbcd79ee17dab4a2aea4d589b8c6d022dcf8713f00a3fb65dd1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOERDOjI4RjYwNjoyMzk2OTI6MkZFNDA2OjZBNTI2QzkxIiwidmlzaXRvcl9pZCI6Ijg1MTM4NTMzMzI2NDkwNDUxMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac092f0ab2ac25c463a8aeaf11d888ada744a28d21fa4e8862c426c42aa2336d2b
hovercard-subject-tagpull_request:2862002422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql-action/3157/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5d4d369aa7920434dc6b909de024bb26ec1b857b800a73171c20b0e79a021b90/github/codeql-action/pull/3157
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5d4d369aa7920434dc6b909de024bb26ec1b857b800a73171c20b0e79a021b90/github/codeql-action/pull/3157
og:image:altFixes #3156. In #3123, we inadvertently introduced a regression by using the same logic for uploading SARIF files as in the analyze Action: if a file ends in .quality.sarif, we upload it to Code Qu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamembg
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/github/codeql-action git https://github.com/github/codeql-action.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id259445878
octolytics-dimension-repository_nwogithub/codeql-action
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id259445878
octolytics-dimension-repository_network_root_nwogithub/codeql-action
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql-action/pull/3157#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F3157
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F3157
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql-action
Reloadhttps://github.com/github/codeql-action/pull/3157
Reloadhttps://github.com/github/codeql-action/pull/3157
Reloadhttps://github.com/github/codeql-action/pull/3157
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
github https://github.com/github
codeql-actionhttps://github.com/github/codeql-action
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Fork 471 https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Star 1.6k https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Code https://github.com/github/codeql-action
Issues 156 https://github.com/github/codeql-action/issues
Pull requests 24 https://github.com/github/codeql-action/pulls
Actions https://github.com/github/codeql-action/actions
Models https://github.com/github/codeql-action/models
Security and quality 2 https://github.com/github/codeql-action/security
Insights https://github.com/github/codeql-action/pulse
Code https://github.com/github/codeql-action
Issues https://github.com/github/codeql-action/issues
Pull requests https://github.com/github/codeql-action/pulls
Actions https://github.com/github/codeql-action/actions
Models https://github.com/github/codeql-action/models
Security and quality https://github.com/github/codeql-action/security
Insights https://github.com/github/codeql-action/pulse
mbghttps://github.com/mbg
mainhttps://github.com/github/codeql-action/tree/main
mbg/fix/upload-sarif-non-sarifhttps://github.com/github/codeql-action/tree/mbg/fix/upload-sarif-non-sarif
Conversationhttps://github.com/github/codeql-action/pull/3157
Commits14 (14)https://github.com/github/codeql-action/pull/3157/commits
Checkshttps://github.com/github/codeql-action/pull/3157/checks
Files changedhttps://github.com/github/codeql-action/pull/3157/files
Fix upload-sarif not uploading non-.sarif fileshttps://github.com/github/codeql-action/pull/3157#top
mbghttps://github.com/mbg
mainhttps://github.com/github/codeql-action/tree/main
mbg/fix/upload-sarif-non-sarifhttps://github.com/github/codeql-action/tree/mbg/fix/upload-sarif-non-sarif
https://github.com/mbg
mbghttps://github.com/mbg
Sep 25, 2025https://github.com/github/codeql-action/pull/3157#issue-3455141688
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
#3156https://github.com/github/codeql-action/issues/3156
#3123https://github.com/github/codeql-action/pull/3123
changeloghttps://github.com/github/codeql-action/blob/main/CHANGELOG.md
readmehttps://github.com/github/codeql-action/blob/main/README.md
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
https://github.com/mbg
mbghttps://github.com/mbg
September 25, 2025 23:02https://github.com/github/codeql-action/pull/3157#event-19930896515
https://github.com/mbg
mbghttps://github.com/mbg
code ownerhttps://github.com/github/codeql-action/blob/94a9b7a1101a1320dcadcbda5e7fd9a1e6abaaca/CODEOWNERS#L1
September 25, 2025 23:02https://github.com/github/codeql-action/pull/3157#event-19930896602
https://github.com/mbg
mbghttps://github.com/mbg
Copilothttps://github.com/apps/copilot-pull-request-reviewer
henrymercerhttps://github.com/henrymercer
September 25, 2025 23:02https://github.com/github/codeql-action/pull/3157#event-19930896637
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Sep 25, 2025 https://github.com/github/codeql-action/pull/3157#pullrequestreview-3269677269
View reviewed changes https://github.com/github/codeql-action/pull/3157/files
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql-action/pull/3157#pullrequestreview-3269677269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
src/upload-sarif.tshttps://github.com/github/codeql-action/pull/3157/files#diff-0ffebd7868a9bec42440b12bf95c55cb48dd2c1340f57c321b706e014eccc173
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
https://github.com/mbg
mbghttps://github.com/mbg
Sep 25, 2025 https://github.com/github/codeql-action/pull/3157#ref-issue-3455079214
upload-sarif 3.30.4 silently stopped uploading (2025-09-25) #3156 https://github.com/github/codeql-action/issues/3156
https://github.com/esbena
esbenahttps://github.com/esbena
Sep 26, 2025 https://github.com/github/codeql-action/pull/3157#pullrequestreview-3270248561
View reviewed changes https://github.com/github/codeql-action/pull/3157/files
esbenahttps://github.com/esbena
https://github.com/github/codeql-action/pull/3157#pullrequestreview-3270248561
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
src/upload-sarif.tshttps://github.com/github/codeql-action/pull/3157/files#diff-0ffebd7868a9bec42440b12bf95c55cb48dd2c1340f57c321b706e014eccc173
esbenahttps://github.com/esbena
Sep 26, 2025https://github.com/github/codeql-action/pull/3157#discussion_r2380944814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
mbghttps://github.com/mbg
Sep 26, 2025https://github.com/github/codeql-action/pull/3157#discussion_r2382021310
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
src/upload-sarif.tshttps://github.com/github/codeql-action/pull/3157/files#diff-0ffebd7868a9bec42440b12bf95c55cb48dd2c1340f57c321b706e014eccc173
esbenahttps://github.com/esbena
Sep 26, 2025https://github.com/github/codeql-action/pull/3157#discussion_r2380974861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
codeql-action/src/upload-lib.tshttps://github.com/github/codeql-action/blob/245e2e5cde27ee775820c30dec085797b344b9a0/src/upload-lib.ts#L448-L459
245e2e5https://github.com/github/codeql-action/commit/245e2e5cde27ee775820c30dec085797b344b9a0
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
mbghttps://github.com/mbg
Sep 26, 2025https://github.com/github/codeql-action/pull/3157#discussion_r2382026705
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3123https://github.com/github/codeql-action/pull/3123
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
mbghttps://github.com/mbg
September 26, 2025 15:02https://github.com/github/codeql-action/pull/3157#commits-pushed-022d7d5
https://github.com/mbg
Move error checks out of getSarifFilePathshttps://github.com/github/codeql-action/pull/3157/commits/022d7d5aa6d329ec5535c412be4a41a95a1c39f4
022d7d5https://github.com/github/codeql-action/pull/3157/commits/022d7d5aa6d329ec5535c412be4a41a95a1c39f4
https://github.com/mbg
Warn if no SARIF files were uploadedhttps://github.com/github/codeql-action/pull/3157/commits/975347365fd502995e7b3b992603ecb05d05d04b
9753473https://github.com/github/codeql-action/pull/3157/commits/975347365fd502995e7b3b992603ecb05d05d04b
https://github.com/mbg
Move findAndUpload to new upload-sarif modulehttps://github.com/github/codeql-action/pull/3157/commits/fc8843601d33d9f57afebaaa7f4c8ec66eb92120
fc88436https://github.com/github/codeql-action/pull/3157/commits/fc8843601d33d9f57afebaaa7f4c8ec66eb92120
https://github.com/mbg
Use getSarifFilePaths in upload-sarifhttps://github.com/github/codeql-action/pull/3157/commits/c1f21e42fbba5a4252333c29d788883363658878
c1f21e4https://github.com/github/codeql-action/pull/3157/commits/c1f21e42fbba5a4252333c29d788883363658878
https://github.com/mbg
Move main upload-sarif logic to new upload-sarif modulehttps://github.com/github/codeql-action/pull/3157/commits/ff359630c66958b42d09e5ab6861ccc32cf93a79
ff35963https://github.com/github/codeql-action/pull/3157/commits/ff359630c66958b42d09e5ab6861ccc32cf93a79
https://github.com/mbg
Use FeatureEnablement rather than Features in upload-sarifhttps://github.com/github/codeql-action/pull/3157/commits/d7509a4aaf5ddcd4d7afd2e6caabbde688aa5c90
d7509a4https://github.com/github/codeql-action/pull/3157/commits/d7509a4aaf5ddcd4d7afd2e6caabbde688aa5c90
https://github.com/mbg
Add some tests for findAndUpload and uploadSarifhttps://github.com/github/codeql-action/pull/3157/commits/4c60b18145ebfebb807eded62cb6d27de2886e09
4c60b18https://github.com/github/codeql-action/pull/3157/commits/4c60b18145ebfebb807eded62cb6d27de2886e09
https://github.com/mbg
Fix sarif-ids format not matching documentationhttps://github.com/github/codeql-action/pull/3157/commits/0e1ad534f339e0ff182e4bf235dd0fcb41c7b192
0e1ad53https://github.com/github/codeql-action/pull/3157/commits/0e1ad534f339e0ff182e4bf235dd0fcb41c7b192
https://github.com/mbg
Test that uploaded files match expectations for each analysis kindhttps://github.com/github/codeql-action/pull/3157/commits/f6ff68d584b1bdea26f45f5d1b07dbd84b6010da
f6ff68dhttps://github.com/github/codeql-action/pull/3157/commits/f6ff68d584b1bdea26f45f5d1b07dbd84b6010da
https://github.com/mbg
mbghttps://github.com/mbg
force-pushedhttps://github.com/github/codeql-action/compare/245e2e5cde27ee775820c30dec085797b344b9a0..f6ff68d584b1bdea26f45f5d1b07dbd84b6010da
245e2e5https://github.com/github/codeql-action/commit/245e2e5cde27ee775820c30dec085797b344b9a0
f6ff68dhttps://github.com/github/codeql-action/commit/f6ff68d584b1bdea26f45f5d1b07dbd84b6010da
Compare https://github.com/github/codeql-action/compare/245e2e5cde27ee775820c30dec085797b344b9a0..f6ff68d584b1bdea26f45f5d1b07dbd84b6010da
September 26, 2025 14:14https://github.com/github/codeql-action/pull/3157#event-19945449374
mbghttps://github.com/mbg
September 26, 2025 15:32https://github.com/github/codeql-action/pull/3157#commits-pushed-320fdb3
https://github.com/mbg
Tests: ensure uploadSpecifiedFiles wasn't called if we don't expect…https://github.com/github/codeql-action/pull/3157/commits/320fdb37738bd4752e64aed181ce42af6e813449
320fdb3https://github.com/github/codeql-action/pull/3157/commits/320fdb37738bd4752e64aed181ce42af6e813449
https://github.com/mbg
Add isOtherAnalysisSarif with testshttps://github.com/github/codeql-action/pull/3157/commits/b26519c6c0c1cfb8afdc78a676dd27674dd9d3b1
b26519chttps://github.com/github/codeql-action/pull/3157/commits/b26519c6c0c1cfb8afdc78a676dd27674dd9d3b1
https://github.com/mbg
Check that file doesn't belong to other analysis in getSarifFilePathshttps://github.com/github/codeql-action/pull/3157/commits/7b7f47d02c136c198dc14e8cdd6dc2aabac84e26
7b7f47dhttps://github.com/github/codeql-action/pull/3157/commits/7b7f47d02c136c198dc14e8cdd6dc2aabac84e26
https://github.com/mbg
Check if file is .quality.sarif for CQ uploadhttps://github.com/github/codeql-action/pull/3157/commits/e080dc827a19b2800cf36dfd4c0d8ee107b07427
e080dc8https://github.com/github/codeql-action/pull/3157/commits/e080dc827a19b2800cf36dfd4c0d8ee107b07427
https://github.com/mbg
Merge branch 'main' into mbg/fix/upload-sarif-non-sarifhttps://github.com/github/codeql-action/pull/3157/commits/4989465202a0f65293340b0c6746f432f3f2a596
4989465https://github.com/github/codeql-action/pull/3157/commits/4989465202a0f65293340b0c6746f432f3f2a596
Hotfix upload-sarif not uploading non-.sarif files #3160 https://github.com/github/codeql-action/pull/3160
Add tests for upload-sarif #3166 https://github.com/github/codeql-action/pull/3166
https://github.com/mbg
mbghttps://github.com/mbg
Sep 29, 2025https://github.com/github/codeql-action/pull/3157#issuecomment-3347207867
#3160https://github.com/github/codeql-action/pull/3160
#3166https://github.com/github/codeql-action/pull/3166
#3167https://github.com/github/codeql-action/pull/3167
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
https://github.com/mbg
mbghttps://github.com/mbg
Sep 29, 2025https://github.com/github/codeql-action/pull/3157#event-19985501313
fix(snyk): Update action and split report upload Accenture/AutoFixture.XUnit2.AutoMock#318 https://github.com/Accenture/AutoFixture.XUnit2.AutoMock/pull/318
feat: switch code quality setup to ultracite and biome ahmadk953/poixpixel-discord-bot#769 https://github.com/ahmadk953/poixpixel-discord-bot/pull/769
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
May 19, 2026 https://github.com/github/codeql-action/pull/3157#ref-pullrequest-4474696512
Add Trivy security scanning workflow (weekly + manual) ggfevans/zed-hujson#7 https://github.com/ggfevans/zed-hujson/pull/7
https://github.co/hiddenchars
https://github.com/github/codeql-action/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F3157
https://github.com/esbena
esbena https://github.com/esbena
https://github.com/github/codeql-action/pull/3157/files/245e2e5cde27ee775820c30dec085797b344b9a0
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql-action/pull/3157/files/245e2e5cde27ee775820c30dec085797b344b9a0
https://github.com/henrymercer
henrymercer https://github.com/henrymercer
upload-sarif 3.30.4 silently stopped uploading (2025-09-25) https://github.com/github/codeql-action/issues/3156
Please reload this pagehttps://github.com/github/codeql-action/pull/3157
https://github.com/mbg
https://github.com/esbena
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.