Title: Abort CodeQL action if the status cannot be reported by simon-engledew · Pull Request #308 · github/codeql-action · GitHub
Open Graph Title: Abort CodeQL action if the status cannot be reported by simon-engledew · Pull Request #308 · github/codeql-action
X Title: Abort CodeQL action if the status cannot be reported by simon-engledew · Pull Request #308 · github/codeql-action
Description: Save action minutes by only running the CodeQL check if code scanning is enabled for the repository. This reverts some work done in #128 This is nearly a no-op against Enterprise but there is value in not maintaining two separate behaviours. Enterprise will log a warning and not fail on a 422. This may occur if the bundled version of CodeQL was updated on an old version of Enterprise. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary. I have only ever seen the Octokit request raise HTTPErrors rather than return a response with non-200 status codes. I need to check with @robertbrignull if this behaviour is new, or if there is an edge case that I have not managed to reproduce in my local setup. I think this is likely a change in octokit. As both the response and the HTTP error have a status field it seems reasonable to check it on both success and failure using the same code. If it changes in future this code should continue to work the same.
Open Graph Description: Save action minutes by only running the CodeQL check if code scanning is enabled for the repository. This reverts some work done in #128 This is nearly a no-op against Enterprise but there is value...
X Description: Save action minutes by only running the CodeQL check if code scanning is enabled for the repository. This reverts some work done in #128 This is nearly a no-op against Enterprise but there is value...
Opengraph URL: https://github.com/github/codeql-action/pull/308
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d8783ff6-e04f-f370-b09b-edf61b799b4d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D832:2987FD:F8DCAE:14B1FC3:6A541933 |
| html-safe-nonce | 006f5a44c9b5872ed51d6eba01d0c57c600178061a8099a7231e7d0151df7921 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODMyOjI5ODdGRDpGOERDQUU6MTRCMUZDMzo2QTU0MTkzMyIsInZpc2l0b3JfaWQiOiI1MzA1Mjg0MDI5NzU4ODM5MDkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 646c1e620bd25e4e7927bed914ba473b4ed5540acea16a2aa24eb902105bd503 |
| hovercard-subject-tag | pull_request:522660594 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/308/files |
| twitter:image | https://avatars.githubusercontent.com/u/14410?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14410?s=400&v=4 |
| og:image:alt | Save action minutes by only running the CodeQL check if code scanning is enabled for the repository. This reverts some work done in #128 This is nearly a no-op against Enterprise but there is value... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width