Title: Run all tests on latest tools by robertbrignull · Pull Request #290 · github/codeql-action · GitHub
Open Graph Title: Run all tests on latest tools by robertbrignull · Pull Request #290 · github/codeql-action
X Title: Run all tests on latest tools by robertbrignull · Pull Request #290 · github/codeql-action
Description: Makes all integration tests use the latest bundle version by default. There is one test that already runs on latest and the version in the environment, to test that code path as well. By running on the latest version of the tools we'll get better confidence when we upgrade the bundle. Currently the CI checks when updating the bundle are basically useless because it uses the tools from the environment. I also run into this with #222 but I realise that PR is held up by the virtual environment being updated anyway. So if anything using the latest version in our tests would have actually masked the error on that PR and made it more dangerous. It's dangerous if our testing environment is different from the environment that users see. I guess the ultimate option would be to run all tests on both tools versions, but that is probably prohibitively expensive given the number of checks we already have. So there are pros and cons of making this change. What do people think? Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.
Open Graph Description: Makes all integration tests use the latest bundle version by default. There is one test that already runs on latest and the version in the environment, to test that code path as well. By running on...
X Description: Makes all integration tests use the latest bundle version by default. There is one test that already runs on latest and the version in the environment, to test that code path as well. By running on...
Opengraph URL: https://github.com/github/codeql-action/pull/290
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:34fd7c44-1301-78cd-0254-6f8d72b391a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D02A:FF3C6:32AD73:45A30B:6A5522B1 |
| html-safe-nonce | 2e664503c98c042bcd4dcd7d8cc9d312fdb874ebbe5231047f4d48d44c142c9f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDJBOkZGM0M2OjMyQUQ3Mzo0NUEzMEI6NkE1NTIyQjEiLCJ2aXNpdG9yX2lkIjoiODQ3ODM3MTI5Nzg1MTk0MTU1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a71aa7109a80fd5073e7b863026af4a462843a7d66c61420a99be0f4a34b074c |
| hovercard-subject-tag | pull_request:515321699 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/290/files |
| twitter:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| og:image:alt | Makes all integration tests use the latest bundle version by default. There is one test that already runs on latest and the version in the environment, to test that code path as well. By running on... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 682d273eacb2ac51680c6eb9c0b270f029f7ce74c32090f319083c34497e28a5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 358dd24ad7465d20e3fae729b5b169d35b0dd7f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width