Title: Make URL parsing more robust, and handle subdomain isolation by robertbrignull · Pull Request #235 · github/codeql-action · GitHub
Open Graph Title: Make URL parsing more robust, and handle subdomain isolation by robertbrignull · Pull Request #235 · github/codeql-action
X Title: Make URL parsing more robust, and handle subdomain isolation by robertbrignull · Pull Request #235 · github/codeql-action
Description: This PR makes the runner's parsing of the URL a bit more robust and should make it handle the case where GHES is using subdomain isolation. I need to test that this actually works and I will do so before merging, but from my prelimanary experimentation it looks like it should do as the /api/v3 route on the main GHES domain still seems to work. So we don't need to be able to reconstruct the isolated subdomain. The other changes to the URL parsing make it so if you don't pass a scheme then it'll assume it's https. Also makes the output URL more consistent. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.
Open Graph Description: This PR makes the runner's parsing of the URL a bit more robust and should make it handle the case where GHES is using subdomain isolation. I need to test that this actually works and I will do...
X Description: This PR makes the runner's parsing of the URL a bit more robust and should make it handle the case where GHES is using subdomain isolation. I need to test that this actually works and I wil...
Opengraph URL: https://github.com/github/codeql-action/pull/235
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:adf79570-b4f5-3821-49ef-9794a138b343 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCCE:3DBE0D:843FF0:B75C49:6A552F6C |
| html-safe-nonce | ca3baac581106cdd3c78a99389491a20dcbb9daf34ef5580b970bc5facf885dd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0NFOjNEQkUwRDo4NDNGRjA6Qjc1QzQ5OjZBNTUyRjZDIiwidmlzaXRvcl9pZCI6IjQ4NjU5NjcwNTkzMDAwNjkyMjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 38efa2865a5e76930270b1b4aaa7fa264a581a19884efecb2b546f8df036325c |
| hovercard-subject-tag | pull_request:494299759 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/235/files |
| twitter:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| og:image:alt | This PR makes the runner's parsing of the URL a bit more robust and should make it handle the case where GHES is using subdomain isolation. I need to test that this actually works and I will do... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cf96660b44878f418b09d3d6ecde00ad62332910 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width