Title: Use tmp dir for external queries test by robertbrignull · Pull Request #19 · github/codeql-action · GitHub
Open Graph Title: Use tmp dir for external queries test by robertbrignull · Pull Request #19 · github/codeql-action
X Title: Use tmp dir for external queries test by robertbrignull · Pull Request #19 · github/codeql-action
Description: The external queries tests run in a fixed directory. This is arguably fine when run as part of CI, but if the tests are run multiple times locally then they start to interfere with each other. To see it's working, you can see in the test logs Cloning into '/tmp/codeql-action-1XUxpg/github/codeql-go' This PR creates a random tmp dir for each test run and deletes it when the test is done. I created a shared function for this because I intend to start using it for other tests as well. Also by populating the RUNNER_WORKSPACE env var we can make it required in checkoutExternalQueries and this avoids the hardcoded alternative path. @Daverlo Merge / deployment checklist Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos! CodeQL using init/analyze actions - https://github.com/Anthophila/test-electron/actions/runs/96083423 3rd party tool using upload action - https://github.com/Anthophila/test-electron/actions/runs/96083425 Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.
Open Graph Description: The external queries tests run in a fixed directory. This is arguably fine when run as part of CI, but if the tests are run multiple times locally then they start to interfere with each other. To s...
X Description: The external queries tests run in a fixed directory. This is arguably fine when run as part of CI, but if the tests are run multiple times locally then they start to interfere with each other. To s...
Opengraph URL: https://github.com/github/codeql-action/pull/19
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d55bcf26-5430-46f5-083c-ce4b1c140992 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C034:A02C3:D65658:12294C1:6A555FEE |
| html-safe-nonce | 7062bf3c4636c651ced1c1011b8d3984246553642358e19188367ba891962586 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDM0OkEwMkMzOkQ2NTY1ODoxMjI5NEMxOjZBNTU1RkVFIiwidmlzaXRvcl9pZCI6IjE3Njg3ODY2ODUyNTk1MDU2NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f4d5c63cd4e7a2c68d8d1f5d600f350c3db7e5381f114751042f9c8e1cb71233 |
| hovercard-subject-tag | pull_request:413448969 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/19/files |
| twitter:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| og:image:alt | The external queries tests run in a fixed directory. This is arguably fine when run as part of CI, but if the tests are run multiple times locally then they start to interfere with each other. To s... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8201d0b7bc32164c4662de52242e463a356df543 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width