Title: Break out tracer-config.ts to its own file by robertbrignull · Pull Request #158 · github/codeql-action · GitHub
Open Graph Title: Break out tracer-config.ts to its own file by robertbrignull · Pull Request #158 · github/codeql-action
X Title: Break out tracer-config.ts to its own file by robertbrignull · Pull Request #158 · github/codeql-action
Description: Pulls a bunch of code from setup-tracer.ts to a new tracer-config.ts file. This is the code that generates the environment variables to be set when running later processes so that CodeQL can intercept the compiler commands. This is in preparation for chaning the behaviour when in CLI mode to output the env vars to a file instead of using core.exportVariable, while keeping all the code that generates the environment the same. Also while I'm doing it I've written tests for this code which was previously untested. Also reverts a bad change from a previous PR of mine. In https://github.com/github/codeql-action/pull/140/files#diff-244be00bfdf0600dd7b228caba9f8232L57 I changed the type of the argument from an object to an array because I thought it wouldn't make a difference, but I missed a call to Object.keys which then silently did the wrong thing of returning keys like 0, 1, 2, 3... This basically didn't make a difference thankfully so tracing still worked, and the only functionality that was broken by this was the requirement to put the spec from cpp at the end. Other than the above noted fix of a regression, this PR shouldn't make any changes to behaviour. @sampart do you have scope to review this? Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.
Open Graph Description: Pulls a bunch of code from setup-tracer.ts to a new tracer-config.ts file. This is the code that generates the environment variables to be set when running later processes so that CodeQL can interc...
X Description: Pulls a bunch of code from setup-tracer.ts to a new tracer-config.ts file. This is the code that generates the environment variables to be set when running later processes so that CodeQL can interc...
Opengraph URL: https://github.com/github/codeql-action/pull/158
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bc8e6084-2c4f-4123-7c24-43921ffd9e68 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C790:3FB6B5:65A900:88EB68:6A56E6B4 |
| html-safe-nonce | b06ce4141d44032ba48f1a817a9f02278e855b8bb190621ae3f8629d3d25068e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzkwOjNGQjZCNTo2NUE5MDA6ODhFQjY4OjZBNTZFNkI0IiwidmlzaXRvcl9pZCI6IjkwNTU0NzM0MjE5MTY3NTk3MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8828e26688781a8935a26e228a2ce491c1a25c2ad94abd7bab6a8c8d0e96c074 |
| hovercard-subject-tag | pull_request:472467072 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/158/files |
| twitter:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3749000?s=400&v=4 |
| og:image:alt | Pulls a bunch of code from setup-tracer.ts to a new tracer-config.ts file. This is the code that generates the environment variables to be set when running later processes so that CodeQL can interc... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5220a278731283038daf0ed00b41f06ef7ff9539020ecc806c5c5a0fb6bda25a |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8684ae1a81cd3e4ef219b241179982bbda1a5b1f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width