René's URL Explorer Experiment


Title: Remove some shared env by robertbrignull · Pull Request #140 · github/codeql-action · GitHub

Open Graph Title: Remove some shared env by robertbrignull · Pull Request #140 · github/codeql-action

X Title: Remove some shared env by robertbrignull · Pull Request #140 · github/codeql-action

Description: This PR aims to remove a few elements from shared-environment.ts. Most of this is pretty easy because the variable is only used from one place, or the data is readily available in the config already. This doesn't remove ODASA_TRACER_CONFIGURATION or CODEQL_WORKFLOW_STARTED_AT because those are unfortunately going to be slightly more tricky. I think the only bit that needs explaining is the removal of should_abort. I claim this is safe to do because it's functionality of checking that the init action has already run is covered by the call to getConfig in the autobuild and analyze actions. In the init and upload-sarif actions, all it was doing was validating that the github ref env var was populated, which doesn't seem worth it to keep the function around. Merge / deployment checklist Confirm this change is backwards compatible with existing workflows. Confirm the readme has been updated if necessary.

Open Graph Description: This PR aims to remove a few elements from shared-environment.ts. Most of this is pretty easy because the variable is only used from one place, or the data is readily available in the config alread...

X Description: This PR aims to remove a few elements from shared-environment.ts. Most of this is pretty easy because the variable is only used from one place, or the data is readily available in the config alread...

Opengraph URL: https://github.com/github/codeql-action/pull/140

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4e5cee3e-9054-dd89-8cd4-54e7e9d08f51
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88C0:1748BD:45AA833:624592A:6A56E693
html-safe-nonceb41865401ad87b3d2e462ef18a9d52bb2670dc41b81d241ae5e0d070ab0423ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEMwOjE3NDhCRDo0NUFBODMzOjYyNDU5MkE6NkE1NkU2OTMiLCJ2aXNpdG9yX2lkIjoiMjg4MDQ0ODI5ODc3NDYxOTc5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4149cfba1e0e30b542305651f4ad2231c8f11bcb5752a99e8f2f52df58d69dba
hovercard-subject-tagpull_request:464697411
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql-action/pull/140/files
twitter:imagehttps://avatars.githubusercontent.com/u/3749000?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3749000?s=400&v=4
og:image:altThis PR aims to remove a few elements from shared-environment.ts. Most of this is pretty easy because the variable is only used from one place, or the data is readily available in the config alread...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5220a278731283038daf0ed00b41f06ef7ff9539020ecc806c5c5a0fb6bda25a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql-action git https://github.com/github/codeql-action.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id259445878
octolytics-dimension-repository_nwogithub/codeql-action
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id259445878
octolytics-dimension-repository_network_root_nwogithub/codeql-action
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8684ae1a81cd3e4ef219b241179982bbda1a5b1f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql-action/pull/140/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F140%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql-action%2Fpull%2F140%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql-action
Reloadhttps://github.com/github/codeql-action/pull/140/files
Reloadhttps://github.com/github/codeql-action/pull/140/files
Reloadhttps://github.com/github/codeql-action/pull/140/files
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
github https://github.com/github
codeql-actionhttps://github.com/github/codeql-action
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Fork 472 https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Star 1.6k https://github.com/login?return_to=%2Fgithub%2Fcodeql-action
Code https://github.com/github/codeql-action
Issues 157 https://github.com/github/codeql-action/issues
Pull requests 28 https://github.com/github/codeql-action/pulls
Actions https://github.com/github/codeql-action/actions
Models https://github.com/github/codeql-action/models
Security and quality 2 https://github.com/github/codeql-action/security
Insights https://github.com/github/codeql-action/pulse
Code https://github.com/github/codeql-action
Issues https://github.com/github/codeql-action/issues
Pull requests https://github.com/github/codeql-action/pulls
Actions https://github.com/github/codeql-action/actions
Models https://github.com/github/codeql-action/models
Security and quality https://github.com/github/codeql-action/security
Insights https://github.com/github/codeql-action/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql-action%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql-action%2Fissues%2Fnew%2Fchoose
robertbrignullhttps://github.com/robertbrignull
mainhttps://github.com/github/codeql-action/tree/main
remove_some_shared_envhttps://github.com/github/codeql-action/tree/remove_some_shared_env
Conversation 3 https://github.com/github/codeql-action/pull/140
Findings https://github.com/github/codeql-action/pull/140/findings
Commits 5 https://github.com/github/codeql-action/pull/140/commits
Checks 0 https://github.com/github/codeql-action/pull/140/checks
Files changed https://github.com/github/codeql-action/pull/140/files
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
Remove some shared env https://github.com/github/codeql-action/pull/140/files#top
Show all changes 5 commits https://github.com/github/codeql-action/pull/140/files
5b35de6 remove CODEQL_ACTION_DATABASE_DIR robertbrignull Aug 7, 2020 https://github.com/github/codeql-action/pull/140/commits/5b35de62bd133511274cd43999c52aabb9af5012
e5ad069 remove CODEQL_ACTION_ANALYSIS_KEY robertbrignull Aug 7, 2020 https://github.com/github/codeql-action/pull/140/commits/e5ad069f2c000c1285f362d2886dfed89d0830d3
396f716 remove CODEQL_ACTION_TRACED_LANGUAGES and CODEQL_ACTION_SCANNED_LANGU… robertbrignull Aug 7, 2020 https://github.com/github/codeql-action/pull/140/commits/396f7167d8e62c928562022166cde376ce50ae8c
a0660c8 remove should_abort method robertbrignull Aug 7, 2020 https://github.com/github/codeql-action/pull/140/commits/a0660c80bd2a95f985a3e3891e4186c6db42946e
eb4eda5 Merge branch 'main' into remove_some_shared_env robertbrignull Aug 10, 2020 https://github.com/github/codeql-action/pull/140/commits/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e
Clear filters https://github.com/github/codeql-action/pull/140/files
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
integration-testing.yml https://github.com/github/codeql-action/pull/140/files#diff-3a1fea4e5bb8f47ffb16d851debf4b504b20e782df9dc03336b120d14126147d
autobuild.js https://github.com/github/codeql-action/pull/140/files#diff-d85b7b843f71dd120db4b7f43fc567ca182bf0347b077cd690b7bd650acaa606
autobuild.js.map https://github.com/github/codeql-action/pull/140/files#diff-7e16048c8a24fdf059ab69ea374066068718dd9756280f09d0f281997e8b8ae9
codeql.js https://github.com/github/codeql-action/pull/140/files#diff-5bd808ec74194675da6319beb80c228163039f26c9ddf1b8bf3eef9b12c9341b
codeql.js.map https://github.com/github/codeql-action/pull/140/files#diff-325a6cb428a1dafbcfbd43461aa4ae95826c648a3f9a7d7b6e6bf05878152d64
finalize-db.js https://github.com/github/codeql-action/pull/140/files#diff-0718e3e92a103d254d2a24b24d8b8cd75970ae3c8b195ec8e4713d392323222c
finalize-db.js.map https://github.com/github/codeql-action/pull/140/files#diff-06c49c3f8e23c5c9bf6fba4b926e5088a3f2b4f48bf74ae64140f7e1822cf683
setup-tracer.js https://github.com/github/codeql-action/pull/140/files#diff-877b143cf413a90c33abd53758e2827d64840dd70d0a6b2cca162e03846a06ea
setup-tracer.js.map https://github.com/github/codeql-action/pull/140/files#diff-23f2b9f88b890e8be64f341f58f8f242ab824a85fe527f24b6c7a37de047ff2d
shared-environment.js https://github.com/github/codeql-action/pull/140/files#diff-54ee56fdea0bf0a1aeaad4f1073fe8b200e3a47afd1df7da1b7bf07a6888bbd2
shared-environment.js.map https://github.com/github/codeql-action/pull/140/files#diff-6aa43e46572a4319f3aa2e809fd23f2616996a4802a8a0490de380c7f855dab5
upload-sarif.js https://github.com/github/codeql-action/pull/140/files#diff-ecd14e360a0f243a50e6ea43e10c9253de1786a85dbc35e0aa04a7f63ec4aa25
upload-sarif.js.map https://github.com/github/codeql-action/pull/140/files#diff-4db3528bcd7478641ebbd43777f9b344b37684fc94fbd5fa46b3dd6b455cc653
util.js https://github.com/github/codeql-action/pull/140/files#diff-3fb720f70ea34fb2975fd6c38ac4b6b6131373be2abfa4760dfaae8a25daaee2
util.js.map https://github.com/github/codeql-action/pull/140/files#diff-709978ba6652a9d1f2f2cfb89f74b8743ec9a8aac0470253725ecf2c62a1651e
autobuild.ts https://github.com/github/codeql-action/pull/140/files#diff-e8e280e07642ac43bae0f81a751fcf1841a78a5a34db8977b4e540690d36ecf5
codeql.ts https://github.com/github/codeql-action/pull/140/files#diff-473ad8cf33ad034dc4f9ae468a3ce5d87106ace4f96f6a23a000261d46efaa60
finalize-db.ts https://github.com/github/codeql-action/pull/140/files#diff-8ccda6cc78c0645f45113228ce43bfac9fc341746dbf1680430a20bacc75e0a1
setup-tracer.ts https://github.com/github/codeql-action/pull/140/files#diff-32828111aa07ddc8e64c1ecb5182060aa40f5b9e50804f0245050a997efab618
shared-environment.ts https://github.com/github/codeql-action/pull/140/files#diff-6c7b3bb4430ed4cfff0c133a9f462c2cd2200a0938c97538a966123739df30e2
upload-sarif.ts https://github.com/github/codeql-action/pull/140/files#diff-0ffebd7868a9bec42440b12bf95c55cb48dd2c1340f57c321b706e014eccc173
util.ts https://github.com/github/codeql-action/pull/140/files#diff-3294a832ea2276e554177e0b3007cc2d401c082912c7fbde49fa09141bf1aed1
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
.github/workflows/integration-testing.ymlhttps://github.com/github/codeql-action/pull/140/files#diff-3a1fea4e5bb8f47ffb16d851debf4b504b20e782df9dc03336b120d14126147d
View file https://github.com/github/codeql-action/blob/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e/.github/workflows/integration-testing.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql-action/pull/140/{{ revealButtonHref }}
https://github.com/github/codeql-action/pull/140/files#diff-3a1fea4e5bb8f47ffb16d851debf4b504b20e782df9dc03336b120d14126147d
https://github.com/github/codeql-action/pull/140/files#diff-3a1fea4e5bb8f47ffb16d851debf4b504b20e782df9dc03336b120d14126147d
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
lib/autobuild.jshttps://github.com/github/codeql-action/pull/140/files#diff-d85b7b843f71dd120db4b7f43fc567ca182bf0347b077cd690b7bd650acaa606
View file https://github.com/github/codeql-action/blob/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e/lib/autobuild.js
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
lib/autobuild.js.maphttps://github.com/github/codeql-action/pull/140/files#diff-7e16048c8a24fdf059ab69ea374066068718dd9756280f09d0f281997e8b8ae9
View file https://github.com/github/codeql-action/blob/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e/lib/autobuild.js.map
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
lib/codeql.jshttps://github.com/github/codeql-action/pull/140/files#diff-5bd808ec74194675da6319beb80c228163039f26c9ddf1b8bf3eef9b12c9341b
View file https://github.com/github/codeql-action/blob/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e/lib/codeql.js
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
lib/codeql.js.maphttps://github.com/github/codeql-action/pull/140/files#diff-325a6cb428a1dafbcfbd43461aa4ae95826c648a3f9a7d7b6e6bf05878152d64
View file https://github.com/github/codeql-action/blob/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e/lib/codeql.js.map
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
lib/finalize-db.jshttps://github.com/github/codeql-action/pull/140/files#diff-0718e3e92a103d254d2a24b24d8b8cd75970ae3c8b195ec8e4713d392323222c
View file https://github.com/github/codeql-action/blob/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e/lib/finalize-db.js
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
https://github.com/github/codeql-action/blob/main/CODEOWNERS#L1
lib/finalize-db.js.maphttps://github.com/github/codeql-action/pull/140/files#diff-06c49c3f8e23c5c9bf6fba4b926e5088a3f2b4f48bf74ae64140f7e1822cf683
View file https://github.com/github/codeql-action/blob/eb4eda5cbed813270dcc056e3bc7d38dd69f1d7e/lib/finalize-db.js.map
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
Please reload this pagehttps://github.com/github/codeql-action/pull/140/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.