Title: Fingerprinting in the upload-sarif action fails with directories · Issue #478 · github/codeql-action · GitHub
Open Graph Title: Fingerprinting in the upload-sarif action fails with directories · Issue #478 · github/codeql-action
X Title: Fingerprinting in the upload-sarif action fails with directories · Issue #478 · github/codeql-action
Description: The Android linter started supporting sarif files in the latest version (4.2). When trying it out in one of my projects (https://github.com/jellyfin/jellyfin-androidtv) it failed uploading the artifact. This is because one of the linter ...
Open Graph Description: The Android linter started supporting sarif files in the latest version (4.2). When trying it out in one of my projects (https://github.com/jellyfin/jellyfin-androidtv) it failed uploading the arti...
X Description: The Android linter started supporting sarif files in the latest version (4.2). When trying it out in one of my projects (https://github.com/jellyfin/jellyfin-androidtv) it failed uploading the arti...
Opengraph URL: https://github.com/github/codeql-action/issues/478
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fingerprinting in the upload-sarif action fails with directories","articleBody":"The Android linter started supporting sarif files in the latest version (4.2). When trying it out in one of my projects (https://github.com/jellyfin/jellyfin-androidtv) it failed uploading the artifact. This is because one of the linter rules adds a directory as uri in the locations object. The fingerprinting code assumes it is a file and tries to fingerprint the directory. The specification says that an uri should be pointing to a file (https://rawgit.com/sarif-standard/sarif-spec/master/Static Analysis Results Interchange Format (SARIF).html#fileformat-uriproperties) but I don't expect this action to fail.\r\n\r\nError:\r\n\r\n```\r\nRun github/codeql-action/upload-sarif@v1\r\n with:\r\n sarif_file: .\r\n checkout_path: /home/runner/work/jellyfin-androidtv/jellyfin-androidtv\r\n token: ***\r\n matrix: null\r\n env:\r\n JAVA_HOME: /opt/hostedtoolcache/Java_Adopt_jdk/11.0.10-9/x64\r\nUploading sarif files: [\"/home/runner/work/jellyfin-androidtv/jellyfin-androidtv/app/build/reports/detekt/detekt.sarif\",\"/home/runner/work/jellyfin-androidtv/jellyfin-androidtv/app/build/reports/lint-results.sarif\"]\r\nError: EISDIR: illegal operation on a directory, read\r\nError: EISDIR: illegal operation on a directory, read\r\n at Object.readSync (fs.js:506:3)\r\n at tryReadSync (fs.js:331:20)\r\n at Object.readFileSync (fs.js:368:19)\r\n at Object.addFingerprints (/home/runner/work/_actions/github/codeql-action/v1/lib/fingerprints.js:239:33)\r\n at uploadFiles (/home/runner/work/_actions/github/codeql-action/v1/lib/upload-lib.js:249:33)\r\n at Object.uploadFromActions (/home/runner/work/_actions/github/codeql-action/v1/lib/upload-lib.js:123:18)\r\n at async run (/home/runner/work/_actions/github/codeql-action/v1/lib/upload-sarif-action.js:34:29)\r\n at async runWrapper (/home/runner/work/_actions/github/codeql-action/v1/lib/upload-sarif-action.js:46:9) {\r\n errno: -21,\r\n syscall: 'read',\r\n code: 'EISDIR'\r\n}\r\n```\r\n\r\nFile that should reproduce the issue:\r\n\r\n[android-lint.sarif.txt](https://github.com/github/codeql-action/files/6429409/android-lint.sarif.txt)","author":{"url":"https://github.com/nielsvanvelzen","@type":"Person","name":"nielsvanvelzen"},"datePublished":"2021-05-05T18:28:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/478/codeql-action/issues/478"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:659758d2-a774-007f-2962-8187a06836fc |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ECA6:17CF54:1C46503:26913E7:6A5400A5 |
| html-safe-nonce | 013f80fadff44098bbafe1abce4821628029ea157f7943efda2d8d680661aa41 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0E2OjE3Q0Y1NDoxQzQ2NTAzOjI2OTEzRTc6NkE1NDAwQTUiLCJ2aXNpdG9yX2lkIjoiMjM3MDM4NzA4ODAzMjEzNzM4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a6404297d49724aff5c3b55fdaddd410c57f2fb63e0b1cd565c892f8322619bc |
| hovercard-subject-tag | issue:876724894 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github/codeql-action/478/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5ce34bbeb34b01311af3af3c3869db3d0c5ef22c6cdd15539fed0d7d8c05a2ec/github/codeql-action/issues/478 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5ce34bbeb34b01311af3af3c3869db3d0c5ef22c6cdd15539fed0d7d8c05a2ec/github/codeql-action/issues/478 |
| og:image:alt | The Android linter started supporting sarif files in the latest version (4.2). When trying it out in one of my projects (https://github.com/jellyfin/jellyfin-androidtv) it failed uploading the arti... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nielsvanvelzen |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width