Title: ESLint transition: update code so "no-shadow" passes · Issue #202 · github/codeql-action · GitHub
Open Graph Title: ESLint transition: update code so "no-shadow" passes · Issue #202 · github/codeql-action
X Title: ESLint transition: update code so "no-shadow" passes · Issue #202 · github/codeql-action
Description: This issue relates to the no-shadow rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a temporary override in the .eslintrc.json file to t...
Open Graph Description: This issue relates to the no-shadow rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a temporary ...
X Description: This issue relates to the no-shadow rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a tempor...
Opengraph URL: https://github.com/github/codeql-action/issues/202
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ESLint transition: update code so \"no-shadow\" passes","articleBody":"This issue relates to the [no-shadow](https://eslint.org/docs/rules/no-shadow) rule.\r\n\r\nDuring the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a temporary override in the `.eslintrc.json` file to temporarily disable them.\r\n\r\nThis issue covers removing that temporary override and any changes to the typescript code required to get the rule passing. Use `npm run lint` to run the linter and once you've done changing the typescript don't forget to also run `npm run build` to reflect the changes in the built javascript (which also needs to be checked in).","author":{"url":"https://github.com/cbraynor","@type":"Person","name":"cbraynor"},"datePublished":"2020-09-14T15:04:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/202/codeql-action/issues/202"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:80608c5f-ece8-8b22-452e-a66b5d83269a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B368:172D3F:9A0DCD:CE526B:6A54009C |
| html-safe-nonce | 514463fcfa596961f0e95c2ff7b5850a352717dadd9619eff7089a9195937287 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzY4OjE3MkQzRjo5QTBEQ0Q6Q0U1MjZCOjZBNTQwMDlDIiwidmlzaXRvcl9pZCI6IjY5NTEzMzA3NjU2NDE4NzU2MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 49612206cb9eb78532771ceffe2bd278dd361281c8c0a1c656a03b17c2dbceb9 |
| hovercard-subject-tag | issue:701186604 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github/codeql-action/202/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c079caa363f2ca60fc42b4a4f56bb7a003c67a3bd9d9ac6176a79672e4cb9385/github/codeql-action/issues/202 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c079caa363f2ca60fc42b4a4f56bb7a003c67a3bd9d9ac6176a79672e4cb9385/github/codeql-action/issues/202 |
| og:image:alt | This issue relates to the no-shadow rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a temporary ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cbraynor |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width