Title: ESLint transition: update code so "github/no-then" passes · Issue #200 · github/codeql-action · GitHub
Open Graph Title: ESLint transition: update code so "github/no-then" passes · Issue #200 · github/codeql-action
X Title: ESLint transition: update code so "github/no-then" passes · Issue #200 · github/codeql-action
Description: This issue relates to the github/no-then rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a temporary override in the .eslintrc.json file...
Open Graph Description: This issue relates to the github/no-then rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a tempo...
X Description: This issue relates to the github/no-then rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a t...
Opengraph URL: https://github.com/github/codeql-action/issues/200
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ESLint transition: update code so \"github/no-then\" passes","articleBody":"This issue relates to the [github/no-then](https://github.com/github/eslint-plugin-github/blob/main/docs/rules/no-then.md) rule.\r\n\r\nDuring the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a temporary override in the `.eslintrc.json` file to temporarily disable them.\r\n\r\nThis issue covers removing that temporary override and any changes to the typescript code required to get the rule passing. Use `npm run lint` to run the linter and once you've done changing the typescript don't forget to also run `npm run build` to reflect the changes in the built javascript (which also needs to be checked in).","author":{"url":"https://github.com/cbraynor","@type":"Person","name":"cbraynor"},"datePublished":"2020-09-14T15:02:20.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/200/codeql-action/issues/200"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b6323859-8afb-6065-07b4-b98af141ad55 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EA3C:1BB425:229ACEB:2F084C6:6A5393AE |
| html-safe-nonce | f7babc725db6e001261e9f68bb8aa2ff1a688e58a9d6ef9a6c25ecbe33ea4244 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTNDOjFCQjQyNToyMjlBQ0VCOjJGMDg0QzY6NkE1MzkzQUUiLCJ2aXNpdG9yX2lkIjoiNDQ5NjQ4ODIxOTg3NDEzNzAwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 00b40c930847bb1870d6a3c96280b0aa2ea6ab317490565cbdd62ca6bfe4cf53 |
| hovercard-subject-tag | issue:701184239 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github/codeql-action/200/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3bccb1406feebf55cf80947c9481b17a455e2b615b62f666657690bb008587a2/github/codeql-action/issues/200 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3bccb1406feebf55cf80947c9481b17a455e2b615b62f666657690bb008587a2/github/codeql-action/issues/200 |
| og:image:alt | This issue relates to the github/no-then rule. During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a tempo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cbraynor |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/github/codeql-action git https://github.com/github/codeql-action.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 259445878 |
| octolytics-dimension-repository_nwo | github/codeql-action |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 259445878 |
| octolytics-dimension-repository_network_root_nwo | github/codeql-action |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width