René's URL Explorer Experiment


Title: Java: Fix Local Temp File/Dir Incorrect Guard Logic by JLLeitschuh · Pull Request #8681 · github/codeql · GitHub

Open Graph Title: Java: Fix Local Temp File/Dir Incorrect Guard Logic by JLLeitschuh · Pull Request #8681 · github/codeql

X Title: Java: Fix Local Temp File/Dir Incorrect Guard Logic by JLLeitschuh · Pull Request #8681 · github/codeql

Description: Resolves: #8032 (comment) Thanks @aschackmull for your feedback and review!

Open Graph Description: Resolves: #8032 (comment) Thanks @aschackmull for your feedback and review!

X Description: Resolves: #8032 (comment) Thanks @aschackmull for your feedback and review!

Opengraph URL: https://github.com/github/codeql/pull/8681

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:058d947c-372e-ed16-4017-53e4b86f05b5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95EE:9C16A:1F7024:2E04BC:6A4DFF44
html-safe-noncee2e1398d6afc68052fdd8a102a926d7edf8157ea1fc81100ecd2819e7fd331d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUVFOjlDMTZBOjFGNzAyNDoyRTA0QkM6NkE0REZGNDQiLCJ2aXNpdG9yX2lkIjoiMTUwNTYyNTczNjg2MTMxODk4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0e9832d0295937a0e91b531776964a1c86c794b7bedfd0e29d042af1dd1762c7
hovercard-subject-tagpull_request:901560353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/8681/files
twitter:imagehttps://avatars.githubusercontent.com/u/1323708?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1323708?s=400&v=4
og:image:altResolves: #8032 (comment) Thanks @aschackmull for your feedback and review!
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release52bde38e24398476f8eb1e0760c81346c6a00812
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/8681/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F8681%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F8681%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/8681/files
Reloadhttps://github.com/github/codeql/pull/8681/files
Reloadhttps://github.com/github/codeql/pull/8681/files
Please reload this pagehttps://github.com/github/codeql/pull/8681/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 426 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
aschackmullhttps://github.com/aschackmull
github:mainhttps://github.com/github/codeql/tree/main
JLLeitschuh:fix/JLL/os_check_bugshttps://github.com/JLLeitschuh/ql/tree/fix/JLL/os_check_bugs
Conversation 5 https://github.com/github/codeql/pull/8681
Findings https://github.com/github/codeql/pull/8681/findings
Commits 1 https://github.com/github/codeql/pull/8681/commits
Checks 0 https://github.com/github/codeql/pull/8681/checks
Files changed https://github.com/github/codeql/pull/8681/files
Please reload this pagehttps://github.com/github/codeql/pull/8681/files
Java: Fix Local Temp File/Dir Incorrect Guard Logic https://github.com/github/codeql/pull/8681/files#top
Show all changes 1 commit https://github.com/github/codeql/pull/8681/files
2753521 Java: Fix Local Temp File/Dir Incorrect Guard Logic JLLeitschuh Apr 6, 2022 https://github.com/github/codeql/pull/8681/commits/27535216502aba81889c3a76ee45861ea1adcbec
Clear filters https://github.com/github/codeql/pull/8681/files
Please reload this pagehttps://github.com/github/codeql/pull/8681/files
Please reload this pagehttps://github.com/github/codeql/pull/8681/files
OSCheck.qll https://github.com/github/codeql/pull/8681/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5
TempDirLocalInformationDisclosure.ql https://github.com/github/codeql/pull/8681/files#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2
TempDirUtils.qll https://github.com/github/codeql/pull/8681/files#diff-0188c0fb3eef6f8bb0eccd9371e1a126aaaec4d8d851bde07f576559a5f5f7ca
2022-04-06-local-temp-file-or-directory-bugfix.md https://github.com/github/codeql/pull/8681/files#diff-9b16c0ed50d13218db547b6e350298e274e7eaf9c1f374a8e3750f106b68a91b
TempDirLocalInformationDisclosure.expected https://github.com/github/codeql/pull/8681/files#diff-f2f51b90009dbf4d61c3cde42778dc5826a11351c7c4edc7fdfe69a506782e64
Test.java https://github.com/github/codeql/pull/8681/files#diff-5bd3840e93ec550ae6b38744db95e2dfa16eb6d3f1bda6d0b56f996ff172fe05
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/os/OSCheck.qllhttps://github.com/github/codeql/pull/8681/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5
View file https://github.com/JLLeitschuh/ql/blob/27535216502aba81889c3a76ee45861ea1adcbec/java/ql/lib/semmle/code/java/os/OSCheck.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/8681/{{ revealButtonHref }}
https://github.com/github/codeql/pull/8681/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5
https://github.com/github/codeql/pull/8681/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.qlhttps://github.com/github/codeql/pull/8681/files#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2
View file https://github.com/JLLeitschuh/ql/blob/27535216502aba81889c3a76ee45861ea1adcbec/java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/8681/{{ revealButtonHref }}
https://github.com/github/codeql/pull/8681/files#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2
https://github.com/github/codeql/pull/8681/files#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2
https://github.com/github/codeql/pull/8681/files#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2
https://github.com/github/codeql/pull/8681/files#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/Security/CWE/CWE-200/TempDirUtils.qllhttps://github.com/github/codeql/pull/8681/files#diff-0188c0fb3eef6f8bb0eccd9371e1a126aaaec4d8d851bde07f576559a5f5f7ca
View file https://github.com/JLLeitschuh/ql/blob/27535216502aba81889c3a76ee45861ea1adcbec/java/ql/src/Security/CWE/CWE-200/TempDirUtils.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/8681/{{ revealButtonHref }}
https://github.com/github/codeql/pull/8681/files#diff-0188c0fb3eef6f8bb0eccd9371e1a126aaaec4d8d851bde07f576559a5f5f7ca
aschackmullhttps://github.com/aschackmull
Apr 6, 2022https://github.com/github/codeql/pull/8681/files#r844004814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/8681/files
JLLeitschuhhttps://github.com/JLLeitschuh
Apr 6, 2022https://github.com/github/codeql/pull/8681/files#r844092101
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
codeql/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qllhttps://github.com/github/codeql/blob/879b8a1200fa946d7e8db5dd4ce360a8d37c8d52/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll#L331
879b8a1https://github.com/github/codeql/commit/879b8a1200fa946d7e8db5dd4ce360a8d37c8d52
Please reload this pagehttps://github.com/github/codeql/pull/8681/files
https://github.com/github/codeql/pull/8681/files#diff-0188c0fb3eef6f8bb0eccd9371e1a126aaaec4d8d851bde07f576559a5f5f7ca
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/change-notes/2022-04-06-local-temp-file-or-directory-bugfix.mdhttps://github.com/github/codeql/pull/8681/files#diff-9b16c0ed50d13218db547b6e350298e274e7eaf9c1f374a8e3750f106b68a91b
View file https://github.com/JLLeitschuh/ql/blob/27535216502aba81889c3a76ee45861ea1adcbec/java/ql/src/change-notes/2022-04-06-local-temp-file-or-directory-bugfix.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/8681/{{ revealButtonHref }}
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
...test/query-tests/security/CWE-200/semmle/tests/TempDirLocalInformationDisclosure.expectedhttps://github.com/github/codeql/pull/8681/files#diff-f2f51b90009dbf4d61c3cde42778dc5826a11351c7c4edc7fdfe69a506782e64
View file https://github.com/JLLeitschuh/ql/blob/27535216502aba81889c3a76ee45861ea1adcbec/java/ql/test/query-tests/security/CWE-200/semmle/tests/TempDirLocalInformationDisclosure.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/8681/{{ revealButtonHref }}
https://github.com/github/codeql/pull/8681/files#diff-f2f51b90009dbf4d61c3cde42778dc5826a11351c7c4edc7fdfe69a506782e64
https://github.com/github/codeql/pull/8681/files#diff-f2f51b90009dbf4d61c3cde42778dc5826a11351c7c4edc7fdfe69a506782e64
https://github.com/github/codeql/pull/8681/files#diff-f2f51b90009dbf4d61c3cde42778dc5826a11351c7c4edc7fdfe69a506782e64
https://github.com/github/codeql/pull/8681/files#diff-f2f51b90009dbf4d61c3cde42778dc5826a11351c7c4edc7fdfe69a506782e64
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/test/query-tests/security/CWE-200/semmle/tests/Test.javahttps://github.com/github/codeql/pull/8681/files#diff-5bd3840e93ec550ae6b38744db95e2dfa16eb6d3f1bda6d0b56f996ff172fe05
View file https://github.com/JLLeitschuh/ql/blob/27535216502aba81889c3a76ee45861ea1adcbec/java/ql/test/query-tests/security/CWE-200/semmle/tests/Test.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/8681/{{ revealButtonHref }}
https://github.com/github/codeql/pull/8681/files#diff-5bd3840e93ec550ae6b38744db95e2dfa16eb6d3f1bda6d0b56f996ff172fe05
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.