Title: Java: Revert #8325, Add CharacterLiteral to CompileTimeConstantExpr.getStringValue by smowton · Pull Request #8407 · github/codeql · GitHub
Open Graph Title: Java: Revert #8325, Add CharacterLiteral to CompileTimeConstantExpr.getStringValue by smowton · Pull Request #8407 · github/codeql
X Title: Java: Revert #8325, Add CharacterLiteral to CompileTimeConstantExpr.getStringValue by smowton · Pull Request #8407 · github/codeql
Description: As pointed out in #8325's thread, this breaks the corner case of char-literal addition and the convention that getStringValue only applies to String-typed constants.
Open Graph Description: As pointed out in #8325's thread, this breaks the corner case of char-literal addition and the convention that getStringValue only applies to String-typed constants.
X Description: As pointed out in #8325's thread, this breaks the corner case of char-literal addition and the convention that getStringValue only applies to String-typed constants.
Opengraph URL: https://github.com/github/codeql/pull/8407
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b5920b29-be01-29ce-5bc6-7b720d78b08d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C702:3BBB5A:ED1F6:140CCF:6A4D8320 |
| html-safe-nonce | b969a3845f1d61473864eaab2bba59201ebea4db58aded297b42dd6555c3178b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzAyOjNCQkI1QTpFRDFGNjoxNDBDQ0Y6NkE0RDgzMjAiLCJ2aXNpdG9yX2lkIjoiMjA4NjI3MTEwMTU3MTAwNzI2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 657f35acbf36a9d31e73ff73b760a9fdaa43351843dfb8c1ceebd8252640c1ef |
| hovercard-subject-tag | pull_request:877404142 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql/pull/8407/files |
| twitter:image | https://avatars.githubusercontent.com/u/283483?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/283483?s=400&v=4 |
| og:image:alt | As pointed out in #8325's thread, this breaks the corner case of char-literal addition and the convention that getStringValue only applies to String-typed constants. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6702a58b419a792226bd21ef0fb1bcb318bbcaa3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width