| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e8909984-cb16-8822-6285-9161e3613e31 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9642:F54DF:D14CCE:11D915A:6A4D59CE |
| html-safe-nonce | 95d9880d4c6cf20c3ed2964de633a3eb4a4f074866c30e7695e3c3643fcdb6c2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjQyOkY1NERGOkQxNENDRToxMUQ5MTVBOjZBNEQ1OUNFIiwidmlzaXRvcl9pZCI6IjE2NTczNjM2NzE1NDg3Nzg5NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b508af915249235e06c0afa0a70cba1e36282e1cb696e548fc3316703e03c16c |
| hovercard-subject-tag | pull_request:852496194 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/8032/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/125afec7d75ae5e5a34e6b09366d47d26d81034f7021db2884d89c5dbf5538bc/github/codeql/pull/8032 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/125afec7d75ae5e5a34e6b09366d47d26d81034f7021db2884d89c5dbf5538bc/github/codeql/pull/8032 |
| og:image:alt | This is useful when you have a bit of logic that is only vulnerable on specific OSes. Additionally, it unifies the access of all system properties (from all libraries and JDK APIs) into one method ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JLLeitschuh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2a1443ff9733a3016431263ea73c93d8fe00c195eb4a7670ac30e7848f045441 |
| turbo-cache-control | no-cache |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3bdd3157ea1f0fd738d408eceeead721acf1dc3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/github/codeql/pull/8032#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F8032 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F8032 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql |
| Reload | https://github.com/github/codeql/pull/8032 |
| Reload | https://github.com/github/codeql/pull/8032 |
| Reload | https://github.com/github/codeql/pull/8032 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
|
github
| https://github.com/github |
| codeql | https://github.com/github/codeql |
|
Notifications
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Fork
2k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Star
9.8k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Code
| https://github.com/github/codeql |
|
Issues
988
| https://github.com/github/codeql/issues |
|
Pull requests
424
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
0
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
|
Code
| https://github.com/github/codeql |
|
Issues
| https://github.com/github/codeql/issues |
|
Pull requests
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
| smowton | https://github.com/smowton |
| github:main | https://github.com/github/codeql/tree/main |
| JLLeitschuh:feat/JLL/check_os | https://github.com/JLLeitschuh/ql/tree/feat/JLL/check_os |
| Conversation | https://github.com/github/codeql/pull/8032 |
| Commits28 (28) | https://github.com/github/codeql/pull/8032/commits |
| Checks | https://github.com/github/codeql/pull/8032/checks |
| Files changed | https://github.com/github/codeql/pull/8032/files |
| Java: Add Guard Classes for checking OS & unify System Property Access | https://github.com/github/codeql/pull/8032#top |
| smowton | https://github.com/smowton |
| github:main | https://github.com/github/codeql/tree/main |
| JLLeitschuh:feat/JLL/check_os | https://github.com/JLLeitschuh/ql/tree/feat/JLL/check_os |
|
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Feb 14, 2022 | https://github.com/github/codeql/pull/8032#issue-1137812593 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Java
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava |
| Feb 14, 2022 | https://github.com/github/codeql/pull/8032#event-6070041049 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| force-pushed | https://github.com/github/codeql/compare/a31231ffa7203be86a8480cd43f28a047eea7718..e5c7e88b06a1adad51c76dac8aef6f0c546cfdab |
| a31231f | https://github.com/github/codeql/commit/a31231ffa7203be86a8480cd43f28a047eea7718 |
| e5c7e88 | https://github.com/github/codeql/commit/e5c7e88b06a1adad51c76dac8aef6f0c546cfdab |
|
Compare
| https://github.com/github/codeql/compare/a31231ffa7203be86a8480cd43f28a047eea7718..e5c7e88b06a1adad51c76dac8aef6f0c546cfdab |
| February 14, 2022 20:36 | https://github.com/github/codeql/pull/8032#event-6070048043 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Feb 14, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882230762 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/test/query-tests/security/CWE-200/semmle/tests/TestSafe.java | https://github.com/github/codeql/pull/8032/files#diff-8764375dd9d2bcab65561cb26be765d7598e2fbef76c46f912fd4aa28df4117a |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Feb 14, 2022 | https://github.com/github/codeql/pull/8032#discussion_r806269442 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Feb 14, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882230927 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/test/query-tests/security/CWE-200/semmle/tests/TestSafe.java | https://github.com/github/codeql/pull/8032/files#diff-8764375dd9d2bcab65561cb26be765d7598e2fbef76c46f912fd4aa28df4117a |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Feb 14, 2022 | https://github.com/github/codeql/pull/8032#discussion_r806269540 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Feb 14, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882231918 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/src/Security/CWE/CWE-200/TempDirUsageSafe.java | https://github.com/github/codeql/pull/8032/files#diff-be2ceb5ac70fbd2a009956e66232734ed5f2b907d2c377fdbe1160c5e72b745b |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Feb 14, 2022 | https://github.com/github/codeql/pull/8032#discussion_r806270385 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| February 14, 2022 21:55 | https://github.com/github/codeql/pull/8032#event-6070477477 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| code owner | https://github.com/github/codeql/blob/0bf6c83ef2356ceabfbf945a136c4f75eeeeda4f/CODEOWNERS#L3 |
| February 14, 2022 21:55 | https://github.com/github/codeql/pull/8032#event-6070477500 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Feb 14, 2022
| https://github.com/github/codeql/pull/8032#ref-pullrequest-713344484 |
|
Java: CWE-200: Temp directory local information disclosure vulnerability
#4388
| https://github.com/github/codeql/pull/4388 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| force-pushed | https://github.com/github/codeql/compare/0aabaa57fe5777583be5cb713979110b0e5b8b92..f55ef0e3e6a414556ab0ca4dd57b6ee0fd29e3d1 |
| 0aabaa5 | https://github.com/github/codeql/commit/0aabaa57fe5777583be5cb713979110b0e5b8b92 |
| f55ef0e | https://github.com/github/codeql/commit/f55ef0e3e6a414556ab0ca4dd57b6ee0fd29e3d1 |
|
Compare
| https://github.com/github/codeql/compare/0aabaa57fe5777583be5cb713979110b0e5b8b92..f55ef0e3e6a414556ab0ca4dd57b6ee0fd29e3d1 |
| February 14, 2022 23:10 | https://github.com/github/codeql/pull/8032#event-6070829580 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
documentation
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation |
| Feb 14, 2022 | https://github.com/github/codeql/pull/8032#event-6070830506 |
| https://github.com/intrigus-lgtm |
| intrigus-lgtm | https://github.com/intrigus-lgtm |
|
Feb 15, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882404971 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/lib/semmle/code/java/frameworks/apache/Lang.qll | https://github.com/github/codeql/pull/8032/files#diff-647a457451761e22ac6e4edede21fae8f51826e3bf859c8454ca445acb07a0a6 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/intrigus-lgtm |
| intrigus-lgtm | https://github.com/intrigus-lgtm |
|
Feb 15, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882405190 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/lib/semmle/code/java/frameworks/apache/Lang.qll | https://github.com/github/codeql/pull/8032/files#diff-647a457451761e22ac6e4edede21fae8f51826e3bf859c8454ca445acb07a0a6 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/intrigus-lgtm |
| intrigus-lgtm | https://github.com/intrigus-lgtm |
|
Feb 15, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882405353 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/intrigus-lgtm |
| intrigus-lgtm | https://github.com/intrigus-lgtm |
|
Feb 15, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882405418 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Feb 15, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1040410788 |
| @intrigus-lgtm | https://github.com/intrigus-lgtm |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
|
Feb 15, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-882948184 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/lib/semmle/code/java/StringCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-bb7fa41c4dde8a11fc4c34d3e8987f54621bc62457543d04c9bce6398766f791 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/lib/semmle/code/java/StringCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-bb7fa41c4dde8a11fc4c34d3e8987f54621bc62457543d04c9bce6398766f791 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| force-pushed | https://github.com/github/codeql/compare/d50e09b11c57d1ffd1894566838edbf9413ca014..2896c0ce23024517dc36ceba15b30dc64b0e8d33 |
| d50e09b | https://github.com/github/codeql/commit/d50e09b11c57d1ffd1894566838edbf9413ca014 |
| 2896c0c | https://github.com/github/codeql/commit/2896c0ce23024517dc36ceba15b30dc64b0e8d33 |
|
Compare
| https://github.com/github/codeql/compare/d50e09b11c57d1ffd1894566838edbf9413ca014..2896c0ce23024517dc36ceba15b30dc64b0e8d33 |
| February 15, 2022 17:05 | https://github.com/github/codeql/pull/8032#event-6076693366 |
| https://github.com/Marcono1234 |
| Marcono1234 | https://github.com/Marcono1234 |
|
Feb 20, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-888099436 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| Marcono1234 | https://github.com/Marcono1234 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/github/codeql/pull/8032#pullrequestreview-888099436 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| OperatingSystemMXBean.getName() | https://docs.oracle.com/en/java/javase/17/docs/api/java.management/java/lang/management/OperatingSystemMXBean.html#getName() |
| https://github.com/openjdk/jdk/blob/d7f31d0d53bfec627edc83ceb75fc6202891e186/src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java#L673-L674 | https://github.com/openjdk/jdk/blob/d7f31d0d53bfec627edc83ceb75fc6202891e186/src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java#L673-L674 |
| https://github.com/openjdk/jdk/blob/d7f31d0d53bfec627edc83ceb75fc6202891e186/src/jdk.compiler/share/classes/com/sun/tools/sjavac/JavacState.java#L913 | https://github.com/openjdk/jdk/blob/d7f31d0d53bfec627edc83ceb75fc6202891e186/src/jdk.compiler/share/classes/com/sun/tools/sjavac/JavacState.java#L913 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/lib/semmle/code/java/StringCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-bb7fa41c4dde8a11fc4c34d3e8987f54621bc62457543d04c9bce6398766f791 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.ql | https://github.com/github/codeql/pull/8032/files#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/Marcono1234 |
| Marcono1234 | https://github.com/Marcono1234 |
|
Feb 21, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-888106608 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| force-pushed | https://github.com/github/codeql/compare/97ca09a43bdfd77b4813806bbe54222496726170..cf2bfb5a0e476a062c2469041993007a75ebf025 |
| 97ca09a | https://github.com/github/codeql/commit/97ca09a43bdfd77b4813806bbe54222496726170 |
| cf2bfb5 | https://github.com/github/codeql/commit/cf2bfb5a0e476a062c2469041993007a75ebf025 |
|
Compare
| https://github.com/github/codeql/compare/97ca09a43bdfd77b4813806bbe54222496726170..cf2bfb5a0e476a062c2469041993007a75ebf025 |
| March 1, 2022 00:57 | https://github.com/github/codeql/pull/8032#event-6158493894 |
| JLLeitschuh | https://github.com/JLLeitschuh |
| March 2, 2022 12:50 | https://github.com/github/codeql/pull/8032#commits-pushed-cd073a2 |
|
| https://github.com/JLLeitschuh |
| Java: Add Guard Classes for checking OS | https://github.com/github/codeql/pull/8032/commits/cd073a21736b8a9aeab480c438b09d3656bead1b |
| cd073a2 | https://github.com/github/codeql/pull/8032/commits/cd073a21736b8a9aeab480c438b09d3656bead1b |
|
| https://github.com/JLLeitschuh |
| Apply OS guard checks to TempDirLocalInformationDisclosure | https://github.com/github/codeql/pull/8032/commits/39828fd5961aa89f1ae81f5ba739f7de5ed933d3 |
| 39828fd | https://github.com/github/codeql/pull/8032/commits/39828fd5961aa89f1ae81f5ba739f7de5ed933d3 |
|
| https://github.com/JLLeitschuh |
| Cleanup from review feedback | https://github.com/github/codeql/pull/8032/commits/3cdfc0054250726057e0a3b8b4673dc4c71fb9a0 |
| 3cdfc00 | https://github.com/github/codeql/pull/8032/commits/3cdfc0054250726057e0a3b8b4673dc4c71fb9a0 |
|
| https://github.com/JLLeitschuh |
|
| https://github.com/Marcono1234 |
| Update java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/commits/49513443f28ac30bbb3690e29a45d5a5a682a2ea |
| 4951344 | https://github.com/github/codeql/pull/8032/commits/49513443f28ac30bbb3690e29a45d5a5a682a2ea |
|
| https://github.com/JLLeitschuh |
| Review fixup and add test for apache SystemUtils | https://github.com/github/codeql/pull/8032/commits/9f5022ee958f8493f14e74335d8f671d4eb2ffc4 |
| 9f5022e | https://github.com/github/codeql/pull/8032/commits/9f5022ee958f8493f14e74335d8f671d4eb2ffc4 |
|
| https://github.com/JLLeitschuh |
| Update OS Check from Review Feedback | https://github.com/github/codeql/pull/8032/commits/fd63107edfe033f24543cb534e5ac55f49b4d1cb |
| fd63107 | https://github.com/github/codeql/pull/8032/commits/fd63107edfe033f24543cb534e5ac55f49b4d1cb |
|
| https://github.com/JLLeitschuh |
| Refactor OS Guard Checks | https://github.com/github/codeql/pull/8032/commits/5913c9acadde15013503207c3f5eab4703e93c29 |
| 5913c9a | https://github.com/github/codeql/pull/8032/commits/5913c9acadde15013503207c3f5eab4703e93c29 |
|
| https://github.com/JLLeitschuh |
| Update TempDirInfoDisclosure with new OS Guards | https://github.com/github/codeql/pull/8032/commits/dad9a02fbdbe425f78d153e9bd284344849ac667 |
| dad9a02 | https://github.com/github/codeql/pull/8032/commits/dad9a02fbdbe425f78d153e9bd284344849ac667 |
|
| https://github.com/JLLeitschuh |
| Improve system property lookup | https://github.com/github/codeql/pull/8032/commits/82d3cd8924f99e58ac9365dee51102321d025cb8 |
| 82d3cd8 | https://github.com/github/codeql/pull/8032/commits/82d3cd8924f99e58ac9365dee51102321d025cb8 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| force-pushed | https://github.com/github/codeql/compare/8a8f0fcc068b839b9ebb204db26ead64af6ca993..82d3cd8924f99e58ac9365dee51102321d025cb8 |
| 8a8f0fc | https://github.com/github/codeql/commit/8a8f0fcc068b839b9ebb204db26ead64af6ca993 |
| 82d3cd8 | https://github.com/github/codeql/commit/82d3cd8924f99e58ac9365dee51102321d025cb8 |
|
Compare
| https://github.com/github/codeql/compare/8a8f0fcc068b839b9ebb204db26ead64af6ca993..82d3cd8924f99e58ac9365dee51102321d025cb8 |
| March 2, 2022 17:51 | https://github.com/github/codeql/pull/8032#event-6172801001 |
| JLLeitschuh | https://github.com/JLLeitschuh |
| March 10, 2022 11:48 | https://github.com/github/codeql/pull/8032#commits-pushed-ecb8911 |
|
| https://github.com/JLLeitschuh |
|
| https://github.com/smowton |
| Apply suggestions from code review | https://github.com/github/codeql/pull/8032/commits/ecb89117563f0550caf8f18b9c5cf812b227976b |
| ecb8911 | https://github.com/github/codeql/pull/8032/commits/ecb89117563f0550caf8f18b9c5cf812b227976b |
|
| https://github.com/JLLeitschuh |
| Remove SystemProperty from FlowSources | https://github.com/github/codeql/pull/8032/commits/1c9864286d47ec106390f910d721e9001979bdbe |
| 1c98642 | https://github.com/github/codeql/pull/8032/commits/1c9864286d47ec106390f910d721e9001979bdbe |
| https://github.com/atorralba |
| atorralba | https://github.com/atorralba |
| Mar 11, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1064851714 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
| Mar 11, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1065029381 |
| #8360 | https://github.com/github/codeql/pull/8360 |
| https://lgtm.com/projects/g/geogebra/geogebra | https://lgtm.com/projects/g/geogebra/geogebra |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Mar 11, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1065076187 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
| Mar 11, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1065077149 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Mar 11, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1065077185 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
| Mar 11, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1065084783 |
| #8407 | https://github.com/github/codeql/pull/8407 |
| #8325 | https://github.com/github/codeql/pull/8325 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
|
| https://github.com/JLLeitschuh |
| Code cleanup from code review | https://github.com/github/codeql/pull/8032/commits/50ff2c2c68aea31f70a4d7019ffcc2788d9c2632 |
| 50ff2c2 | https://github.com/github/codeql/pull/8032/commits/50ff2c2c68aea31f70a4d7019ffcc2788d9c2632 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| force-pushed | https://github.com/github/codeql/compare/b73c74a99ce2ca59213763ab7caa3da26d0bc512..50ff2c2c68aea31f70a4d7019ffcc2788d9c2632 |
| b73c74a | https://github.com/github/codeql/commit/b73c74a99ce2ca59213763ab7caa3da26d0bc512 |
| 50ff2c2 | https://github.com/github/codeql/commit/50ff2c2c68aea31f70a4d7019ffcc2788d9c2632 |
|
Compare
| https://github.com/github/codeql/compare/b73c74a99ce2ca59213763ab7caa3da26d0bc512..50ff2c2c68aea31f70a4d7019ffcc2788d9c2632 |
| March 11, 2022 16:44 | https://github.com/github/codeql/pull/8032#event-6226129628 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Mar 14, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1067025917 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| smowton | https://github.com/smowton |
| March 14, 2022 21:01 | https://github.com/github/codeql/pull/8032#event-6238673990 |
|
| https://github.com/smowton |
| Improve guard class names | https://github.com/github/codeql/pull/8032/commits/451661dd20980029e9e4af6557dff9e4a97c07bf |
| 451661d | https://github.com/github/codeql/pull/8032/commits/451661dd20980029e9e4af6557dff9e4a97c07bf |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
|
Mar 15, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-910079666 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files/50ff2c2c68aea31f70a4d7019ffcc2788d9c2632 |
| smowton | https://github.com/smowton |
| https://github.com/github/codeql/pull/8032#pullrequestreview-910079666 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
| Mar 15, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1067897809 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
|
| https://github.com/JLLeitschuh |
| Add tests for StandardSystemProperty | https://github.com/github/codeql/pull/8032/commits/09cc8ee09e05d5e7f1829ac577cec576a5ba1bbe |
| 09cc8ee | https://github.com/github/codeql/pull/8032/commits/09cc8ee09e05d5e7f1829ac577cec576a5ba1bbe |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Mar 15, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1068204197 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| smowton | https://github.com/smowton |
| March 15, 2022 17:52 | https://github.com/github/codeql/pull/8032#event-6245277587 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Mar 15, 2022
| https://github.com/github/codeql/pull/8032#ref-pullrequest-721465796 |
|
Java: CWE-378: Temp Directory Hijacking Race Condition Vulnerability
#4473
| https://github.com/github/codeql/pull/4473 |
|
| https://github.com/smowton |
| Change note tense and detail level | https://github.com/github/codeql/pull/8032/commits/b11340c8293fd0db53a2f305d96dba2efb0ad6b1 |
| b11340c | https://github.com/github/codeql/pull/8032/commits/b11340c8293fd0db53a2f305d96dba2efb0ad6b1 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Mar 17, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1070857425 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
| Mar 17, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1070898497 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
|
Mar 18, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-914234500 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files/b11340c8293fd0db53a2f305d96dba2efb0ad6b1 |
| https://github.com/smowton |
| smowton | https://github.com/smowton |
| 7674535 | https://github.com/github/codeql/commit/767453520e98233f4db9e23844eb4200a2702a61 |
| Mar 18, 2022 | https://github.com/github/codeql/pull/8032#event-6265520820 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Mar 18, 2022 | https://github.com/github/codeql/pull/8032#issuecomment-1072378418 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/aschackmull |
| aschackmull | https://github.com/aschackmull |
|
Apr 4, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-930350663 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files/b11340c8293fd0db53a2f305d96dba2efb0ad6b1 |
| java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.ql | https://github.com/github/codeql/pull/8032/files/b11340c8293fd0db53a2f305d96dba2efb0ad6b1#diff-6d29e19010e83d1c9a9186af28fb2c8743a17540f12f15e006c4d7ee8e8efeb2 |
| aschackmull | https://github.com/aschackmull |
| Apr 4, 2022 | https://github.com/github/codeql/pull/8032#discussion_r841723906 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| JLLeitschuh | https://github.com/JLLeitschuh |
| Apr 5, 2022 | https://github.com/github/codeql/pull/8032#discussion_r842660550 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| aschackmull | https://github.com/aschackmull |
| Apr 5, 2022 | https://github.com/github/codeql/pull/8032#discussion_r842687565 |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| https://github.com/aschackmull |
| aschackmull | https://github.com/aschackmull |
|
Apr 5, 2022
| https://github.com/github/codeql/pull/8032#pullrequestreview-931727859 |
|
View reviewed changes
| https://github.com/github/codeql/pull/8032/files/b11340c8293fd0db53a2f305d96dba2efb0ad6b1 |
| java/ql/lib/semmle/code/java/os/OSCheck.qll | https://github.com/github/codeql/pull/8032/files/b11340c8293fd0db53a2f305d96dba2efb0ad6b1#diff-8001f35b4e15100384db7586e47a569a2f029506ffe3f3e2eb8e5f60050616a5 |
| aschackmull | https://github.com/aschackmull |
| Apr 5, 2022 | https://github.com/github/codeql/pull/8032#discussion_r842693490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Apr 6, 2022
| https://github.com/github/codeql/pull/8032#ref-commit-e65d4c0 |
|
| https://github.com/JLLeitschuh |
| Java: Fix Local Temp File/Dir Incorrect Guard Logic | https://github.com/JLLeitschuh/ql/commit/e65d4c0800c68929ea241eef2d658a9f7c27c7ab |
| e65d4c0 | https://github.com/JLLeitschuh/ql/commit/e65d4c0800c68929ea241eef2d658a9f7c27c7ab |
| github#8032 (comment) | https://github.com/github/codeql/pull/8032#discussion_r841723906 |
| https://github.com/JLLeitschuh |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Apr 6, 2022
| https://github.com/github/codeql/pull/8032#ref-pullrequest-1194672147 |
|
Java: Fix Local Temp File/Dir Incorrect Guard Logic
#8681
| https://github.com/github/codeql/pull/8681 |
| JLLeitschuh | https://github.com/JLLeitschuh |
|
Apr 6, 2022
| https://github.com/github/codeql/pull/8032#ref-commit-2753521 |
|
| https://github.com/JLLeitschuh |
| Java: Fix Local Temp File/Dir Incorrect Guard Logic | https://github.com/JLLeitschuh/ql/commit/27535216502aba81889c3a76ee45861ea1adcbec |
| 2753521 | https://github.com/JLLeitschuh/ql/commit/27535216502aba81889c3a76ee45861ea1adcbec |
| github#8032 (comment) | https://github.com/github/codeql/pull/8032#discussion_r841723906 |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F8032 |
|
| https://github.com/aschackmull |
|
aschackmull
| https://github.com/aschackmull |
|
| https://github.com/github/codeql/pull/8032/files/b11340c8293fd0db53a2f305d96dba2efb0ad6b1 |
|
| https://github.com/smowton |
|
smowton
| https://github.com/smowton |
|
| https://github.com/github/codeql/pull/8032/files/b11340c8293fd0db53a2f305d96dba2efb0ad6b1 |
|
| https://github.com/Marcono1234 |
|
Marcono1234
| https://github.com/Marcono1234 |
|
| https://github.com/github/codeql/pull/8032/files/b282c7f1b979e97652cfa2d3b6b7e8e4594e4d23 |
|
| https://github.com/intrigus-lgtm |
|
intrigus-lgtm
| https://github.com/intrigus-lgtm |
|
| https://github.com/github/codeql/pull/8032/files/7ab193dde2dc454db1808bdc6b69afff2504be3f |
|
documentation
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation |
|
Java
| https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava |
| Please reload this page | https://github.com/github/codeql/pull/8032 |
|
| https://github.com/JLLeitschuh |
|
| https://github.com/atorralba |
|
| https://github.com/smowton |
|
| https://github.com/Marcono1234 |
|
| https://github.com/aschackmull |
|
| https://github.com/intrigus-lgtm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |