| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ae2f1286-4f2a-993f-d624-b9a49016cd0b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86F6:1DAD98:F31D8A:1590D89:6A4D2BDC |
| html-safe-nonce | b775f419269e0965cd7f134a3d37dc4a193571c9f43a45d8951d49f81b455562 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkY2OjFEQUQ5ODpGMzFEOEE6MTU5MEQ4OTo2QTREMkJEQyIsInZpc2l0b3JfaWQiOiIyMTEzMzMxNjM3NTA4NzEzNDM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | faeac9032eccf356427e763b96d9936257ec976a5af13a85724799e7b635912b |
| hovercard-subject-tag | pull_request:829806424 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/github/codeql/pull/7712/files |
| twitter:image | https://avatars.githubusercontent.com/u/37377780?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/37377780?s=400&v=4 |
| og:image:alt | External Control of File Name or Path, also called File Path Injection, is a common attack and injection attack is listed as one of the top attacks in OWASP Top Ten 2021.
Loading files based on unv... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/github/codeql git https://github.com/github/codeql.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 143040428 |
| octolytics-dimension-repository_nwo | github/codeql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143040428 |
| octolytics-dimension-repository_network_root_nwo | github/codeql |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93f17a978ee60bc4668e1d7b90e6bd2d622261fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/github/codeql/pull/7712/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F7712%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F7712%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql |
| Reload | https://github.com/github/codeql/pull/7712/files |
| Reload | https://github.com/github/codeql/pull/7712/files |
| Reload | https://github.com/github/codeql/pull/7712/files |
| Please reload this page | https://github.com/github/codeql/pull/7712/files |
|
github
| https://github.com/github |
| codeql | https://github.com/github/codeql |
|
Notifications
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Fork
2k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Star
9.8k
| https://github.com/login?return_to=%2Fgithub%2Fcodeql |
|
Code
| https://github.com/github/codeql |
|
Issues
987
| https://github.com/github/codeql/issues |
|
Pull requests
424
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
0
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
|
Code
| https://github.com/github/codeql |
|
Issues
| https://github.com/github/codeql/issues |
|
Pull requests
| https://github.com/github/codeql/pulls |
|
Discussions
| https://github.com/github/codeql/discussions |
|
Actions
| https://github.com/github/codeql/actions |
|
Projects
| https://github.com/github/codeql/projects |
|
Models
| https://github.com/github/codeql/models |
|
Security and quality
| https://github.com/github/codeql/security |
|
Insights
| https://github.com/github/codeql/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose |
| atorralba | https://github.com/atorralba |
| github:main | https://github.com/github/codeql/tree/main |
| luchua-bc:java/file-path-injection | https://github.com/luchua-bc/ql/tree/java/file-path-injection |
|
Conversation
63
| https://github.com/github/codeql/pull/7712 |
|
Findings
| https://github.com/github/codeql/pull/7712/findings |
|
Commits
11
| https://github.com/github/codeql/pull/7712/commits |
|
Checks
0
| https://github.com/github/codeql/pull/7712/checks |
|
Files changed
| https://github.com/github/codeql/pull/7712/files |
| Please reload this page | https://github.com/github/codeql/pull/7712/files |
|
Java: CWE-073 File path injection with the JFinal framework
| https://github.com/github/codeql/pull/7712/files#top |
|
Show all changes
11 commits
| https://github.com/github/codeql/pull/7712/files |
|
27043a0
File path injection with the JFinal framework
luchua-bc Jan 23, 2022
| https://github.com/github/codeql/pull/7712/commits/27043a09b3899f7da6335b3cfa1e788ae42ed90c |
|
ff4826d
Correct the data model and update qldoc
luchua-bc Feb 8, 2022
| https://github.com/github/codeql/pull/7712/commits/ff4826d20316d143c318020e54072bd1ca4cb97e |
|
4609227
Use data model for request/session attribute operations
luchua-bc Feb 9, 2022
| https://github.com/github/codeql/pull/7712/commits/4609227e769385a026ebff2435ab270bd7ce5bb3 |
|
ce03aeb
Fixed an issue related to normalized path
luchua-bc Feb 9, 2022
| https://github.com/github/codeql/pull/7712/commits/ce03aeb4d9cff7d35ae394d46d5b5360265bfabc |
|
12c53ba
Simplify the query
luchua-bc Feb 11, 2022
| https://github.com/github/codeql/pull/7712/commits/12c53baba4a4e85ded2ca6f4fb7d6465550bf868 |
|
e3d0e9f
Update normalized path node
luchua-bc Feb 11, 2022
| https://github.com/github/codeql/pull/7712/commits/e3d0e9f083c01b590309615a16fd23543cc84257 |
|
78630f2
Match attribute name to reduce FP
luchua-bc Feb 11, 2022
| https://github.com/github/codeql/pull/7712/commits/78630f25dd8cfed0ccdca1c4afb49fb6fb0b74b8 |
|
35a9242
Model value passing between a setter and a getter call as a value step
luchua-bc Feb 14, 2022
| https://github.com/github/codeql/pull/7712/commits/35a924292bf739f248b34bf2fb7634fb6996c856 |
|
2b5982f
Remove specified value step from additional taint step
luchua-bc Feb 14, 2022
| https://github.com/github/codeql/pull/7712/commits/2b5982fd9d777ac367797f06999a8cd3d33b847b |
|
fd533f2
Remove the same callable constraint
luchua-bc Feb 15, 2022
| https://github.com/github/codeql/pull/7712/commits/fd533f2ba88eef6e93c6898d564a1ace66494cf7 |
|
40bf093
Move shared code to the lib folder and update qldoc
luchua-bc Feb 15, 2022
| https://github.com/github/codeql/pull/7712/commits/40bf093d34e7538b083bdd483bfff4ea8fde7f8c |
|
Clear filters
| https://github.com/github/codeql/pull/7712/files |
| Please reload this page | https://github.com/github/codeql/pull/7712/files |
| Please reload this page | https://github.com/github/codeql/pull/7712/files |
|
FilePathInjection.java
| https://github.com/github/codeql/pull/7712/files#diff-c01729d5a57523a323262ab68e2b6a7adf329555f83be8517e8a821877bf7856 |
|
FilePathInjection.qhelp
| https://github.com/github/codeql/pull/7712/files#diff-3d9c40d182499832eb881422d472038b6828b2acaa8da622d8b3443b0618291f |
|
FilePathInjection.ql
| https://github.com/github/codeql/pull/7712/files#diff-c02a6766a60fca2fbf2da69dc2b2a0a40216d1eb43de0d1a136d7f3ed598df62 |
|
JFinalController.qll
| https://github.com/github/codeql/pull/7712/files#diff-8219b965ff5433db0d9304d63125ecfd9723781de929bffad786f24fba884280 |
|
PathSanitizer.qll
| https://github.com/github/codeql/pull/7712/files#diff-f3846afbdd0bbc98e81457eec11a54d240b071c9ba87d2feb22a15a18f1f2b23 |
|
FilePathInjection.expected
| https://github.com/github/codeql/pull/7712/files#diff-184a4a0726225d645a299cf38f7f7e27e2c8420507d2f06ebfd835486a8565fb |
|
FilePathInjection.java
| https://github.com/github/codeql/pull/7712/files#diff-e81b5c63d05d9ad3b4f99655a64cc74277a94a1cbadefdc92655e9c5afc92724 |
|
FilePathInjection.qlref
| https://github.com/github/codeql/pull/7712/files#diff-09ae498e25c81377adb59bef6373764febdcdbf3cfc6022236d482aed5b9fbbc |
|
options
| https://github.com/github/codeql/pull/7712/files#diff-f17d1d8f025b63c62a37e7633fd97a7b7c57b8f7908b36130e25fe91b28cc5e1 |
|
Controller.java
| https://github.com/github/codeql/pull/7712/files#diff-e0c825d6073ac56cf58a453b95cdc68ad330283f48c818450bc7a7132bc8b18e |
|
Kv.java
| https://github.com/github/codeql/pull/7712/files#diff-395ad7f419a6a90920bb123061e6c5d0ac8a93bf17752920f7459f5dfa99d446 |
|
UploadFile.java
| https://github.com/github/codeql/pull/7712/files#diff-b69c4ea5de4c678d339027e82533520e7d571211f2e70e13c7a5c072256424c5 |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/experimental/Security/CWE/CWE-073/FilePathInjection.java | https://github.com/github/codeql/pull/7712/files#diff-c01729d5a57523a323262ab68e2b6a7adf329555f83be8517e8a821877bf7856 |
|
View file
| https://github.com/luchua-bc/ql/blob/40bf093d34e7538b083bdd483bfff4ea8fde7f8c/java/ql/src/experimental/Security/CWE/CWE-073/FilePathInjection.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/7712/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/experimental/Security/CWE/CWE-073/FilePathInjection.qhelp | https://github.com/github/codeql/pull/7712/files#diff-3d9c40d182499832eb881422d472038b6828b2acaa8da622d8b3443b0618291f |
|
View file
| https://github.com/luchua-bc/ql/blob/40bf093d34e7538b083bdd483bfff4ea8fde7f8c/java/ql/src/experimental/Security/CWE/CWE-073/FilePathInjection.qhelp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/7712/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/experimental/Security/CWE/CWE-073/FilePathInjection.ql | https://github.com/github/codeql/pull/7712/files#diff-c02a6766a60fca2fbf2da69dc2b2a0a40216d1eb43de0d1a136d7f3ed598df62 |
|
View file
| https://github.com/luchua-bc/ql/blob/40bf093d34e7538b083bdd483bfff4ea8fde7f8c/java/ql/src/experimental/Security/CWE/CWE-073/FilePathInjection.ql |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/7712/{{ revealButtonHref }} |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/experimental/Security/CWE/CWE-073/JFinalController.qll | https://github.com/github/codeql/pull/7712/files#diff-8219b965ff5433db0d9304d63125ecfd9723781de929bffad786f24fba884280 |
|
View file
| https://github.com/luchua-bc/ql/blob/40bf093d34e7538b083bdd483bfff4ea8fde7f8c/java/ql/src/experimental/Security/CWE/CWE-073/JFinalController.qll |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/7712/{{ revealButtonHref }} |
| Please reload this page | https://github.com/github/codeql/pull/7712/files |
|
| https://github.com/github/codeql/blob/main/CODEOWNERS#L16 |
| java/ql/src/experimental/semmle/code/java/PathSanitizer.qll | https://github.com/github/codeql/pull/7712/files#diff-f3846afbdd0bbc98e81457eec11a54d240b071c9ba87d2feb22a15a18f1f2b23 |
|
View file
| https://github.com/luchua-bc/ql/blob/40bf093d34e7538b083bdd483bfff4ea8fde7f8c/java/ql/src/experimental/semmle/code/java/PathSanitizer.qll |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/github/codeql/pull/7712/{{ revealButtonHref }} |
| Please reload this page | https://github.com/github/codeql/pull/7712/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |