René's URL Explorer Experiment


Title: Java: Refactor Cleartext Storage queries by atorralba · Pull Request #6493 · github/codeql · GitHub

Open Graph Title: Java: Refactor Cleartext Storage queries by atorralba · Pull Request #6493 · github/codeql

X Title: Java: Refactor Cleartext Storage queries by atorralba · Pull Request #6493 · github/codeql

Description: This PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been generalized to have extensible sinks, sanitizers and taint steps. The encryption sanitizer that was being used in the Shared Preferences query has also been generalized, and now all sensitive storage queries benefit from it.

Open Graph Description: This PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been general...

X Description: This PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been general...

Opengraph URL: https://github.com/github/codeql/pull/6493

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f38bc4c9-846f-171a-ea50-b3beb8b22a55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA996:2BF14B:CD2199:119FACA:6A4DCB24
html-safe-nonce2195223b9a3331d9ff1b540d2795e14c5c8786d854dfd6cca8868e56f05ddaf4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTk2OjJCRjE0QjpDRDIxOTk6MTE5RkFDQTo2QTREQ0IyNCIsInZpc2l0b3JfaWQiOiI1MDU4NjUwNTAyMDYyNzg3MzY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc389ab6ca9661632658cfd4ab6a14174c5ccaab3675d2dc0fa8008bef149eaf0
hovercard-subject-tagpull_request:714104905
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/6493/files
twitter:imagehttps://avatars.githubusercontent.com/u/11612352?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11612352?s=400&v=4
og:image:altThis PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been general...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/6493/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F6493%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F6493%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/6493/files
Reloadhttps://github.com/github/codeql/pull/6493/files
Reloadhttps://github.com/github/codeql/pull/6493/files
Please reload this pagehttps://github.com/github/codeql/pull/6493/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 426 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
aschackmullhttps://github.com/aschackmull
github:mainhttps://github.com/github/codeql/tree/main
atorralba:atorralba/cleartext-storage-query-refactorhttps://github.com/atorralba/codeql/tree/atorralba/cleartext-storage-query-refactor
Conversation 17 https://github.com/github/codeql/pull/6493
Findings https://github.com/github/codeql/pull/6493/findings
Commits 5 https://github.com/github/codeql/pull/6493/commits
Checks 0 https://github.com/github/codeql/pull/6493/checks
Files changed https://github.com/github/codeql/pull/6493/files
Please reload this pagehttps://github.com/github/codeql/pull/6493/files
Java: Refactor Cleartext Storage queries https://github.com/github/codeql/pull/6493/files#top
Show all changes 5 commits https://github.com/github/codeql/pull/6493/files
a30554e Refactored cleartext storage libraries atorralba Aug 17, 2021 https://github.com/github/codeql/pull/6493/commits/a30554e97c49aa14c81d8cc507e2e88fa998adac
563e8a2 Remove unused library atorralba Sep 3, 2021 https://github.com/github/codeql/pull/6493/commits/563e8a2bd651a41202c75be8342234239df6e005
51d2b52 Remove cached property from SensitiveSource::flowsTo atorralba Sep 14, 2021 https://github.com/github/codeql/pull/6493/commits/51d2b5225e7ab357714caab263937c1622178ac1
d0b9920 Fix encryption sanitizer atorralba Sep 14, 2021 https://github.com/github/codeql/pull/6493/commits/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
b52a2cd Apply code review comments atorralba Sep 23, 2021 https://github.com/github/codeql/pull/6493/commits/b52a2cd292df3ee79fc812e688a6c1000e439e24
Clear filters https://github.com/github/codeql/pull/6493/files
Please reload this pagehttps://github.com/github/codeql/pull/6493/files
Please reload this pagehttps://github.com/github/codeql/pull/6493/files
CleartextStorageClassQuery.qll https://github.com/github/codeql/pull/6493/files#diff-9eefc5518e65d67ee65d2bdb4de936d4012e46c6db6a533560c431c7884bc28e
CleartextStorageCookieQuery.qll https://github.com/github/codeql/pull/6493/files#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
CleartextStoragePropertiesQuery.qll https://github.com/github/codeql/pull/6493/files#diff-e0a469c07c4557c1a16448270aee066eb18865bce3a0035da4d111d5113ccdb2
CleartextStorageQuery.qll https://github.com/github/codeql/pull/6493/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
CleartextStorageClass.ql https://github.com/github/codeql/pull/6493/files#diff-8efe370fa6325659551340106a73c5dc5292964d0ca7ae59fc7f3688871ede99
CleartextStorageCookie.ql https://github.com/github/codeql/pull/6493/files#diff-4acfff2f975699aaca0a7f2f7fdd4c9cceb6a0aaca488f6e7b967a96a659b28a
CleartextStorageProperties.ql https://github.com/github/codeql/pull/6493/files#diff-9b084c2c416e1312c6bb224f46e8d6fab4db538bfc5fc1b905611f84855a0c0c
SensitiveStorage.qll https://github.com/github/codeql/pull/6493/files#diff-48e6273fcb6ad2ea3c896bc47287d0339f6570959c8ebf982db9eb56d92385a3
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/CleartextStorageClassQuery.qllhttps://github.com/github/codeql/pull/6493/files#diff-9eefc5518e65d67ee65d2bdb4de936d4012e46c6db6a533560c431c7884bc28e
View file https://github.com/atorralba/codeql/blob/b52a2cd292df3ee79fc812e688a6c1000e439e24/java/ql/lib/semmle/code/java/security/CleartextStorageClassQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/6493/{{ revealButtonHref }}
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/CleartextStorageCookieQuery.qllhttps://github.com/github/codeql/pull/6493/files#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
View file https://github.com/atorralba/codeql/blob/b52a2cd292df3ee79fc812e688a6c1000e439e24/java/ql/lib/semmle/code/java/security/CleartextStorageCookieQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/6493/{{ revealButtonHref }}
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/CleartextStoragePropertiesQuery.qllhttps://github.com/github/codeql/pull/6493/files#diff-e0a469c07c4557c1a16448270aee066eb18865bce3a0035da4d111d5113ccdb2
View file https://github.com/atorralba/codeql/blob/b52a2cd292df3ee79fc812e688a6c1000e439e24/java/ql/lib/semmle/code/java/security/CleartextStoragePropertiesQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/6493/{{ revealButtonHref }}
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qllhttps://github.com/github/codeql/pull/6493/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
View file https://github.com/atorralba/codeql/blob/b52a2cd292df3ee79fc812e688a6c1000e439e24/java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/6493/{{ revealButtonHref }}
Please reload this pagehttps://github.com/github/codeql/pull/6493/files
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/Security/CWE/CWE-312/CleartextStorageClass.qlhttps://github.com/github/codeql/pull/6493/files#diff-8efe370fa6325659551340106a73c5dc5292964d0ca7ae59fc7f3688871ede99
View file https://github.com/atorralba/codeql/blob/b52a2cd292df3ee79fc812e688a6c1000e439e24/java/ql/src/Security/CWE/CWE-312/CleartextStorageClass.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/6493/{{ revealButtonHref }}
https://github.com/github/codeql/pull/6493/files#diff-8efe370fa6325659551340106a73c5dc5292964d0ca7ae59fc7f3688871ede99
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/Security/CWE/CWE-312/CleartextStorageCookie.qlhttps://github.com/github/codeql/pull/6493/files#diff-4acfff2f975699aaca0a7f2f7fdd4c9cceb6a0aaca488f6e7b967a96a659b28a
View file https://github.com/atorralba/codeql/blob/b52a2cd292df3ee79fc812e688a6c1000e439e24/java/ql/src/Security/CWE/CWE-312/CleartextStorageCookie.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/6493/{{ revealButtonHref }}
https://github.com/github/codeql/pull/6493/files#diff-4acfff2f975699aaca0a7f2f7fdd4c9cceb6a0aaca488f6e7b967a96a659b28a
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/Security/CWE/CWE-312/CleartextStorageProperties.qlhttps://github.com/github/codeql/pull/6493/files#diff-9b084c2c416e1312c6bb224f46e8d6fab4db538bfc5fc1b905611f84855a0c0c
View file https://github.com/atorralba/codeql/blob/b52a2cd292df3ee79fc812e688a6c1000e439e24/java/ql/src/Security/CWE/CWE-312/CleartextStorageProperties.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/6493/{{ revealButtonHref }}
https://github.com/github/codeql/pull/6493/files#diff-9b084c2c416e1312c6bb224f46e8d6fab4db538bfc5fc1b905611f84855a0c0c
Please reload this pagehttps://github.com/github/codeql/pull/6493/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.