René's URL Explorer Experiment


Title: Java: Refactor Cleartext Storage queries by atorralba · Pull Request #6493 · github/codeql · GitHub

Open Graph Title: Java: Refactor Cleartext Storage queries by atorralba · Pull Request #6493 · github/codeql

X Title: Java: Refactor Cleartext Storage queries by atorralba · Pull Request #6493 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - Java: Refactor Cleartext Storage queries by atorralba · Pull Request #6493 · github/codeql

Open Graph Description: This PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been general...

X Description: This PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been general...

Opengraph URL: https://github.com/github/codeql/pull/6493

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c496c342-6879-5a98-5bbf-8d673ff18b39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id833C:2B7585:143AD18:1B91B3E:6A4D7563
html-safe-noncec7c032232576bccc332fdfa37e7021135642562c454d3c4f4fea86f4dcc17d3d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzNDOjJCNzU4NToxNDNBRDE4OjFCOTFCM0U6NkE0RDc1NjMiLCJ2aXNpdG9yX2lkIjoiNzk0MjkwMzc4Nzg5MDI0MjkxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb400da203b88cb505613e0d05161f6c89c674b70f3230319dc39395ffdcd6c9f
hovercard-subject-tagpull_request:714104905
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/6493/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/125806c6232eea105d0ae25d0c7b0461c71bb0e1585ce5b1a95adcf9887a77f4/github/codeql/pull/6493
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/125806c6232eea105d0ae25d0c7b0461c71bb0e1585ce5b1a95adcf9887a77f4/github/codeql/pull/6493
og:image:altThis PR splits the SensitiveStorage library in several files, one for each query. The *Query.qll naming convention has been followed, and the base CleartextStorageQuery.qll library has been general...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatorralba
hostnamegithub.com
expected-hostnamegithub.com
Nonec78260c7b3f4ac4b0356c8208537f05406a3a2d46a9ec3f735b372dcc519c39e
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release399fff412f48461d435721c009efc17ea44be72f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/6493#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F6493
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F6493
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/6493
Reloadhttps://github.com/github/codeql/pull/6493
Reloadhttps://github.com/github/codeql/pull/6493
Please reload this pagehttps://github.com/github/codeql/pull/6493
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 425 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
aschackmullhttps://github.com/aschackmull
github:mainhttps://github.com/github/codeql/tree/main
atorralba:atorralba/cleartext-storage-query-refactorhttps://github.com/atorralba/codeql/tree/atorralba/cleartext-storage-query-refactor
Conversationhttps://github.com/github/codeql/pull/6493
Commits5 (5)https://github.com/github/codeql/pull/6493/commits
Checkshttps://github.com/github/codeql/pull/6493/checks
Files changedhttps://github.com/github/codeql/pull/6493/files
Java: Refactor Cleartext Storage querieshttps://github.com/github/codeql/pull/6493#top
aschackmullhttps://github.com/aschackmull
github:mainhttps://github.com/github/codeql/tree/main
atorralba:atorralba/cleartext-storage-query-refactorhttps://github.com/atorralba/codeql/tree/atorralba/cleartext-storage-query-refactor
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Aug 17, 2021https://github.com/github/codeql/pull/6493#issue-972524215
Please reload this pagehttps://github.com/github/codeql/pull/6493
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
atorralbahttps://github.com/atorralba
code ownerhttps://github.com/github/codeql/blob/44ff623d8cb87e3c4fdc5a17b0b3285b7264fc91/CODEOWNERS#L3
August 17, 2021 10:12https://github.com/github/codeql/pull/6493#event-5167980914
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Java https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava
Aug 17, 2021https://github.com/github/codeql/pull/6493#event-5167982524
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 17, 2021https://github.com/github/codeql/pull/6493#issuecomment-900170991
artifacts of this workflow runhttps://github.com/github/codeql/actions/runs/1138853192
artifact of this workflow runhttps://github.com/github/codeql/actions/runs/1138853192
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Aug 17, 2021https://github.com/github/codeql/pull/6493#event-5167996741
https://github.com/atorralba
atorralbahttps://github.com/atorralba
force-pushedhttps://github.com/github/codeql/compare/4dbd67f8f91ac77a9675f44dcc7d810a34594ff4..710a9f3f431d45bf1b694b33ff4fae101187db6d
4dbd67fhttps://github.com/github/codeql/commit/4dbd67f8f91ac77a9675f44dcc7d810a34594ff4
710a9f3https://github.com/github/codeql/commit/710a9f3f431d45bf1b694b33ff4fae101187db6d
Compare https://github.com/github/codeql/compare/4dbd67f8f91ac77a9675f44dcc7d810a34594ff4..710a9f3f431d45bf1b694b33ff4fae101187db6d
August 23, 2021 14:56https://github.com/github/codeql/pull/6493#event-5195021837
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 23, 2021https://github.com/github/codeql/pull/6493#issuecomment-903850566
artifacts of this workflow runhttps://github.com/github/codeql/actions/runs/1159129933
artifact of this workflow runhttps://github.com/github/codeql/actions/runs/1159129933
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Aug 31, 2021 https://github.com/github/codeql/pull/6493#ref-pullrequest-983722659
Java: Create new query Cleartext storage of sensitive information in Android filesystem #6576 https://github.com/github/codeql/pull/6576
https://github.com/atorralba
atorralbahttps://github.com/atorralba
force-pushedhttps://github.com/github/codeql/compare/710a9f3f431d45bf1b694b33ff4fae101187db6d..d590906105a492236ae524002c35ae12dfa27d5c
710a9f3https://github.com/github/codeql/commit/710a9f3f431d45bf1b694b33ff4fae101187db6d
d590906https://github.com/github/codeql/commit/d590906105a492236ae524002c35ae12dfa27d5c
Compare https://github.com/github/codeql/compare/710a9f3f431d45bf1b694b33ff4fae101187db6d..d590906105a492236ae524002c35ae12dfa27d5c
September 3, 2021 11:26https://github.com/github/codeql/pull/6493#event-5252949463
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 3, 2021https://github.com/github/codeql/pull/6493#issuecomment-912467606
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Sep 3, 2021https://github.com/github/codeql/pull/6493#issuecomment-912467762
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
atorralbahttps://github.com/atorralba
no-change-note-required https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required
Sep 3, 2021https://github.com/github/codeql/pull/6493#event-5252963917
Java: Promote Cleartext storage of sensitive information using SharedPreferences from experimental #6468 https://github.com/github/codeql/pull/6468
Java: Create new query Cleartext storage of sensitive information in Android databases #6492 https://github.com/github/codeql/pull/6492
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 6, 2021https://github.com/github/codeql/pull/6493#issuecomment-913548020
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 6, 2021 https://github.com/github/codeql/pull/6493#pullrequestreview-747089677
View reviewed changes https://github.com/github/codeql/pull/6493/files
java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qllhttps://github.com/github/codeql/pull/6493/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 6, 2021 https://github.com/github/codeql/pull/6493#pullrequestreview-747092918
View reviewed changes https://github.com/github/codeql/pull/6493/files
java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qllhttps://github.com/github/codeql/pull/6493/files#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Sep 22, 2021https://github.com/github/codeql/pull/6493#issuecomment-924670767
Please reload this pagehttps://github.com/github/codeql/pull/6493
@aschackmullhttps://github.com/aschackmull
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 23, 2021https://github.com/github/codeql/pull/6493#issuecomment-925592013
Please reload this pagehttps://github.com/github/codeql/pull/6493
atorralbahttps://github.com/atorralba
September 23, 2021 10:42https://github.com/github/codeql/pull/6493#commits-pushed-a30554e
https://github.com/atorralba
Refactored cleartext storage librarieshttps://github.com/github/codeql/pull/6493/commits/a30554e97c49aa14c81d8cc507e2e88fa998adac
a30554ehttps://github.com/github/codeql/pull/6493/commits/a30554e97c49aa14c81d8cc507e2e88fa998adac
https://github.com/atorralba
Remove unused libraryhttps://github.com/github/codeql/pull/6493/commits/563e8a2bd651a41202c75be8342234239df6e005
563e8a2https://github.com/github/codeql/pull/6493/commits/563e8a2bd651a41202c75be8342234239df6e005
https://github.com/atorralba
Remove cached property from SensitiveSource::flowsTohttps://github.com/github/codeql/pull/6493/commits/51d2b5225e7ab357714caab263937c1622178ac1
51d2b52https://github.com/github/codeql/pull/6493/commits/51d2b5225e7ab357714caab263937c1622178ac1
https://github.com/atorralba
Fix encryption sanitizerhttps://github.com/github/codeql/pull/6493/commits/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
d0b9920https://github.com/github/codeql/pull/6493/commits/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
https://github.com/atorralba
atorralbahttps://github.com/atorralba
force-pushedhttps://github.com/github/codeql/compare/b12a0b7a67417409cfc21d1ecae1c68ccfeee96d..d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
b12a0b7https://github.com/github/codeql/commit/b12a0b7a67417409cfc21d1ecae1c68ccfeee96d
d0b9920https://github.com/github/codeql/commit/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
Compare https://github.com/github/codeql/compare/b12a0b7a67417409cfc21d1ecae1c68ccfeee96d..d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
September 23, 2021 08:42https://github.com/github/codeql/pull/6493#event-5348213003
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 23, 2021 https://github.com/github/codeql/pull/6493#pullrequestreview-761980897
View reviewed changes https://github.com/github/codeql/pull/6493/files/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
java/ql/lib/semmle/code/java/security/CleartextStorageCookieQuery.qllhttps://github.com/github/codeql/pull/6493/files/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 23, 2021 https://github.com/github/codeql/pull/6493#pullrequestreview-761981588
View reviewed changes https://github.com/github/codeql/pull/6493/files/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
java/ql/lib/semmle/code/java/security/CleartextStorageCookieQuery.qllhttps://github.com/github/codeql/pull/6493/files/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4#diff-c00be663ef41d9f37888f5c75dc16ef65ce2d84725f06edd16bd261d651a598d
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 23, 2021 https://github.com/github/codeql/pull/6493#pullrequestreview-761985183
View reviewed changes https://github.com/github/codeql/pull/6493/files/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4
java/ql/lib/semmle/code/java/security/CleartextStorageQuery.qllhttps://github.com/github/codeql/pull/6493/files/d0b9920cac5c762358cda00ba57c24e6c9cf2eb4#diff-b317189aa469ce7200bccffeaac500e3445c20300e15ec741f695a0808bcc8d8
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
https://github.com/aschackmull
Apply code review commentshttps://github.com/github/codeql/pull/6493/commits/b52a2cd292df3ee79fc812e688a6c1000e439e24
b52a2cdhttps://github.com/github/codeql/pull/6493/commits/b52a2cd292df3ee79fc812e688a6c1000e439e24
https://github.com/atorralba
atorralbahttps://github.com/atorralba
Sep 23, 2021https://github.com/github/codeql/pull/6493#issuecomment-925834781
@aschackmullhttps://github.com/aschackmull
b52a2cdhttps://github.com/github/codeql/commit/b52a2cd292df3ee79fc812e688a6c1000e439e24
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
Sep 23, 2021 https://github.com/github/codeql/pull/6493#pullrequestreview-762104633
View reviewed changes https://github.com/github/codeql/pull/6493/files/b52a2cd292df3ee79fc812e688a6c1000e439e24
https://github.com/aschackmull
aschackmullhttps://github.com/aschackmull
a031b2ahttps://github.com/github/codeql/commit/a031b2a09075e369a538b35744c3b9d1e6820123
Sep 23, 2021https://github.com/github/codeql/pull/6493#event-5350299374
https://github.com/atorralba
atorralbahttps://github.com/atorralba
September 23, 2021 14:46https://github.com/github/codeql/pull/6493#event-5350430319
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F6493
https://github.com/aschackmull
aschackmull https://github.com/aschackmull
https://github.com/github/codeql/pull/6493/files/b52a2cd292df3ee79fc812e688a6c1000e439e24
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Java https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava
no-change-note-required https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Ano-change-note-required
Please reload this pagehttps://github.com/github/codeql/pull/6493
https://github.com/atorralba
https://github.com/aschackmull
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.