René's URL Explorer Experiment


Title: [WIP] Java: Improve CWE 295 by intrigus-lgtm · Pull Request #4536 · github/codeql · GitHub

Open Graph Title: [WIP] Java: Improve CWE 295 by intrigus-lgtm · Pull Request #4536 · github/codeql

X Title: [WIP] Java: Improve CWE 295 by intrigus-lgtm · Pull Request #4536 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - [WIP] Java: Improve CWE 295 by intrigus-lgtm · Pull Request #4536 · github/codeql

Open Graph Description: Continuation of #3581 @smowton what do you think about the approach? I.e. using data flow and splitting everything into unsafe trustmanager, trust-all hostname verifier, and missing SSL endpoint in...

X Description: Continuation of #3581 @smowton what do you think about the approach? I.e. using data flow and splitting everything into unsafe trustmanager, trust-all hostname verifier, and missing SSL endpoint in...

Opengraph URL: https://github.com/github/codeql/pull/4536

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f95ac4a2-d268-94e1-5d4e-53db53c840ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD7E:3ECFD9:17DDEC6:21408A5:6A4CBC65
html-safe-noncedfc17dac4a307140eeeb80e20e3b47807b17b509082dd5640e91bc9a475c4f34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDdFOjNFQ0ZEOToxN0RERUM2OjIxNDA4QTU6NkE0Q0JDNjUiLCJ2aXNpdG9yX2lkIjoiMzU0OTcwOTE5Mzk2NjMwNDM1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac164f172abf27ea88d4ed16016bbd4ee301812f5a9035d519b02f7a41cc4fbd8b
hovercard-subject-tagpull_request:507879640
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/4536/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9acef39e3be8f06a14235fd9cef75d93dd75268ac8a6e8d3858b262982e5ac86/github/codeql/pull/4536
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9acef39e3be8f06a14235fd9cef75d93dd75268ac8a6e8d3858b262982e5ac86/github/codeql/pull/4536
og:image:altContinuation of #3581 @smowton what do you think about the approach? I.e. using data flow and splitting everything into unsafe trustmanager, trust-all hostname verifier, and missing SSL endpoint in...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameintrigus-lgtm
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec03e7e569190bc89b638cdd4acb4b6c6b38a170a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/4536#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F4536
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F4536
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/4536
Reloadhttps://github.com/github/codeql/pull/4536
Reloadhttps://github.com/github/codeql/pull/4536
Please reload this pagehttps://github.com/github/codeql/pull/4536
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 424 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
intrigus-lgtmhttps://github.com/intrigus-lgtm
github:mainhttps://github.com/github/codeql/tree/main
intrigus-lgtm:improve-cwe-295https://github.com/intrigus-lgtm/ql/tree/improve-cwe-295
Conversationhttps://github.com/github/codeql/pull/4536
Commits5 (5)https://github.com/github/codeql/pull/4536/commits
Checkshttps://github.com/github/codeql/pull/4536/checks
Files changedhttps://github.com/github/codeql/pull/4536/files
[WIP] Java: Improve CWE 295https://github.com/github/codeql/pull/4536#top
intrigus-lgtmhttps://github.com/intrigus-lgtm
github:mainhttps://github.com/github/codeql/tree/main
intrigus-lgtm:improve-cwe-295https://github.com/intrigus-lgtm/ql/tree/improve-cwe-295
https://github.com/intrigus-lgtm
intrigus-lgtmhttps://github.com/intrigus-lgtm
Oct 21, 2020https://github.com/github/codeql/pull/4536#issue-726882290
#3581https://github.com/github/codeql/pull/3581
@smowtonhttps://github.com/smowton
Please reload this pagehttps://github.com/github/codeql/pull/4536
intrigushttps://github.com/intrigus
October 21, 2020 22:06https://github.com/github/codeql/pull/4536#commits-pushed-2a0a7ad
https://github.com/intrigus
Separate hostname verification and trustmanger.https://github.com/github/codeql/pull/4536/commits/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3
2a0a7adhttps://github.com/github/codeql/pull/4536/commits/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3
https://github.com/intrigus
Accept test changes and more separation.https://github.com/github/codeql/pull/4536/commits/104accfdbee102ac98edb73c0f98781f2a93d359
104accfhttps://github.com/github/codeql/pull/4536/commits/104accfdbee102ac98edb73c0f98781f2a93d359
https://github.com/intrigus
Switch to dataflow for trust-all verifier.https://github.com/github/codeql/pull/4536/commits/4210ba8e89b457edc5edbe645e858a0a49d649cf
4210ba8https://github.com/github/codeql/pull/4536/commits/4210ba8e89b457edc5edbe645e858a0a49d649cf
https://github.com/intrigus
Further separation.https://github.com/github/codeql/pull/4536/commits/2a0067e5b46d151b263c1354c4cb2af0ceaadd78
2a0067ehttps://github.com/github/codeql/pull/4536/commits/2a0067e5b46d151b263c1354c4cb2af0ceaadd78
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Java https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava
Oct 21, 2020https://github.com/github/codeql/pull/4536#event-3906075871
https://github.com/smowton
smowtonhttps://github.com/smowton
Oct 23, 2020 https://github.com/github/codeql/pull/4536#pullrequestreview-515517758
View reviewed changes https://github.com/github/codeql/pull/4536/files/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3
smowtonhttps://github.com/smowton
https://github.com/github/codeql/pull/4536#pullrequestreview-515517758
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.javahttps://github.com/github/codeql/pull/4536/files/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3#diff-6880abd838fbbf7e55a5b102e1a8ff938057cfacd142af8f40e9441f2733420e
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510772243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.javahttps://github.com/github/codeql/pull/4536/files/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3#diff-6880abd838fbbf7e55a5b102e1a8ff938057cfacd142af8f40e9441f2733420e
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510772580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-297/UnsafeHostnameVerification.qhelphttps://github.com/github/codeql/pull/4536/files/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3#diff-abacc6b1947a5ec1fbcf96a87adcaa2a5000fcdd4f8260b86ea7e1b5b6eb862d
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510774017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-297/UnsafeHostnameVerification.qlhttps://github.com/github/codeql/pull/4536/files/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3#diff-07841d5a3d10617e388d055689955e0226b52fd4b378d359ba209c3faf66fa15
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-297/UnsafeHostnameVerification.qlhttps://github.com/github/codeql/pull/4536/files/2a0a7adcf4b33f8df3e5646c6501eb16f4846ab3#diff-07841d5a3d10617e388d055689955e0226b52fd4b378d359ba209c3faf66fa15
Please reload this pagehttps://github.com/github/codeql/pull/4536
https://github.com/smowton
smowtonhttps://github.com/smowton
Oct 23, 2020 https://github.com/github/codeql/pull/4536#pullrequestreview-515537771
View reviewed changes https://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78
smowtonhttps://github.com/smowton
https://github.com/github/codeql/pull/4536#pullrequestreview-515537771
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.qhelphttps://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78#diff-6865a8d7f2d1446b73e2abf3b3de784e7b89269b9bc065a14d66d67ccb2f9783
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510787726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.qhelphttps://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78#diff-6865a8d7f2d1446b73e2abf3b3de784e7b89269b9bc065a14d66d67ccb2f9783
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510789406
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.qhelphttps://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78#diff-6865a8d7f2d1446b73e2abf3b3de784e7b89269b9bc065a14d66d67ccb2f9783
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510790432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.qhelphttps://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78#diff-6865a8d7f2d1446b73e2abf3b3de784e7b89269b9bc065a14d66d67ccb2f9783
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510790776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.qlhttps://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78#diff-dfaf155f0ba1d49fca84d126d37f54fb93e9bea1b73db4194a3cdfd1762bd11e
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510791590
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-295/UnsafeCertificateTrust.qlhttps://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78#diff-dfaf155f0ba1d49fca84d126d37f54fb93e9bea1b73db4194a3cdfd1762bd11e
smowtonhttps://github.com/smowton
Oct 23, 2020https://github.com/github/codeql/pull/4536#discussion_r510792104
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/4536
java/ql/src/experimental/Security/CWE/CWE-297/UnsafeHostnameVerification.qlhttps://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78#diff-07841d5a3d10617e388d055689955e0226b52fd4b378d359ba209c3faf66fa15
Please reload this pagehttps://github.com/github/codeql/pull/4536
https://github.com/intrigus
Inline TrueStmt classhttps://github.com/github/codeql/pull/4536/commits/e140fb580866e6bbef6312af4b5ff226f4f38dd8
e140fb5https://github.com/github/codeql/pull/4536/commits/e140fb580866e6bbef6312af4b5ff226f4f38dd8
https://github.com/smowton
smowtonhttps://github.com/smowton
Jan 4, 2021 https://github.com/github/codeql/pull/4536#ref-issue-774578921
[Java]: CWE 295 - Insecure TrustManager - MiTM github/securitylab#221 https://github.com/github/securitylab/issues/221
https://github.com/intrigus-lgtm
intrigus-lgtmhttps://github.com/intrigus-lgtm
Jan 4, 2021https://github.com/github/codeql/pull/4536#issuecomment-753996016
#4771https://github.com/github/codeql/pull/4771
Please reload this pagehttps://github.com/github/codeql/pull/4536
https://github.com/intrigus-lgtm
intrigus-lgtmhttps://github.com/intrigus-lgtm
Jan 4, 2021https://github.com/github/codeql/pull/4536#event-4165131838
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F4536
https://github.com/smowton
smowton https://github.com/smowton
https://github.com/github/codeql/pull/4536/files/2a0067e5b46d151b263c1354c4cb2af0ceaadd78
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Java https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJava
Please reload this pagehttps://github.com/github/codeql/pull/4536
https://github.com/intrigus-lgtm
https://github.com/smowton
https://github.com/intrigus
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.