René's URL Explorer Experiment


Title: Java: Track taint through java.io.File constructor and #toURI; URI#toURL by daniel-beck · Pull Request #4457 · github/codeql · GitHub

Open Graph Title: Java: Track taint through java.io.File constructor and #toURI; URI#toURL by daniel-beck · Pull Request #4457 · github/codeql

X Title: Java: Track taint through java.io.File constructor and #toURI; URI#toURL by daniel-beck · Pull Request #4457 · github/codeql

Description: I was trying to write a query to detect the taint in https://github.com/jenkinsci/persona-plugin/blob/58ea0d9ca16ece310e2002100649aab919a33333/src/main/java/hudson/plugins/persona/ResourceServer.java#L55-L58 from #getRestOfPath to #serveFile and it didn't work. I looked a bit under the hood and found these missing. I did not find a straightforward way to test the impact of a change like this on existing queries on various projects, so other than a trivial query I have locally that now finds the above tainted data, and the addition to the taint test, this is untested.

Open Graph Description: I was trying to write a query to detect the taint in https://github.com/jenkinsci/persona-plugin/blob/58ea0d9ca16ece310e2002100649aab919a33333/src/main/java/hudson/plugins/persona/ResourceServer.ja...

X Description: I was trying to write a query to detect the taint in https://github.com/jenkinsci/persona-plugin/blob/58ea0d9ca16ece310e2002100649aab919a33333/src/main/java/hudson/plugins/persona/ResourceServer.ja...

Opengraph URL: https://github.com/github/codeql/pull/4457

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1917b99-dad5-92aa-cd19-57afa92becc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3CA:221C4E:1EA061:2BD577:6A4D093A
html-safe-noncee65ca3c0243211c823b1d866f1c0309b9cb68a1ff559ed791443068b50fecb8b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0NBOjIyMUM0RToxRUEwNjE6MkJENTc3OjZBNEQwOTNBIiwidmlzaXRvcl9pZCI6IjE3NzIyNzI0NzIxMjY0NTgxNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac509f50360fae033d383c304d310e4f351cecb9338ea0eb26a849bf634e799cc2
hovercard-subject-tagpull_request:501022902
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/4457/files
twitter:imagehttps://avatars.githubusercontent.com/u/1831569?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1831569?s=400&v=4
og:image:altI was trying to write a query to detect the taint in https://github.com/jenkinsci/persona-plugin/blob/58ea0d9ca16ece310e2002100649aab919a33333/src/main/java/hudson/plugins/persona/ResourceServer.ja...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/4457/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F4457%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F4457%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/4457/files
Reloadhttps://github.com/github/codeql/pull/4457/files
Reloadhttps://github.com/github/codeql/pull/4457/files
Please reload this pagehttps://github.com/github/codeql/pull/4457/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 424 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
aibaarshttps://github.com/aibaars
github:mainhttps://github.com/github/codeql/tree/main
daniel-beck:file-tainthttps://github.com/daniel-beck/codeql/tree/file-taint
Conversation 5 https://github.com/github/codeql/pull/4457
Findings https://github.com/github/codeql/pull/4457/findings
Commits 1 https://github.com/github/codeql/pull/4457/commits
Checks 0 https://github.com/github/codeql/pull/4457/checks
Files changed https://github.com/github/codeql/pull/4457/files
Please reload this pagehttps://github.com/github/codeql/pull/4457/files
Java: Track taint through java.io.File constructor and #toURI; URI#toURL https://github.com/github/codeql/pull/4457/files#top
Show all changes 1 commit https://github.com/github/codeql/pull/4457/files
0c70be1 Track taint through java.io.File constructor and #toURI; URI#toURL daniel-beck Oct 10, 2020 https://github.com/github/codeql/pull/4457/commits/0c70be145f366446fc593b1617268b4bd9728693
Clear filters https://github.com/github/codeql/pull/4457/files
Please reload this pagehttps://github.com/github/codeql/pull/4457/files
Please reload this pagehttps://github.com/github/codeql/pull/4457/files
TaintTrackingUtil.qll https://github.com/github/codeql/pull/4457/files#diff-97efb7ecf62c8b0752f8ac2381aa77dbd2806d5383d2dd705cb430268f2a6022
B.java https://github.com/github/codeql/pull/4457/files#diff-f1fe594a2f3e40a35022a96a2eedbc85d3edf4df331f6607d249aa411ed23a2f
test.expected https://github.com/github/codeql/pull/4457/files#diff-a188ac5f1c80d57841cb6f5d9a41ee23ea1b870f6eb000ca5d55ee862f3419bc
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qllhttps://github.com/github/codeql/pull/4457/files#diff-97efb7ecf62c8b0752f8ac2381aa77dbd2806d5383d2dd705cb430268f2a6022
View file https://github.com/daniel-beck/codeql/blob/0c70be145f366446fc593b1617268b4bd9728693/java/ql/src/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/4457/{{ revealButtonHref }}
https://github.com/github/codeql/pull/4457/files#diff-97efb7ecf62c8b0752f8ac2381aa77dbd2806d5383d2dd705cb430268f2a6022
Please reload this pagehttps://github.com/github/codeql/pull/4457/files
https://github.com/github/codeql/pull/4457/files#diff-97efb7ecf62c8b0752f8ac2381aa77dbd2806d5383d2dd705cb430268f2a6022
https://github.com/github/codeql/pull/4457/files#diff-97efb7ecf62c8b0752f8ac2381aa77dbd2806d5383d2dd705cb430268f2a6022
https://github.com/github/codeql/pull/4457/files#diff-97efb7ecf62c8b0752f8ac2381aa77dbd2806d5383d2dd705cb430268f2a6022
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/test/library-tests/dataflow/taint/B.javahttps://github.com/github/codeql/pull/4457/files#diff-f1fe594a2f3e40a35022a96a2eedbc85d3edf4df331f6607d249aa411ed23a2f
View file https://github.com/daniel-beck/codeql/blob/0c70be145f366446fc593b1617268b4bd9728693/java/ql/test/library-tests/dataflow/taint/B.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/4457/{{ revealButtonHref }}
https://github.com/github/codeql/pull/4457/files#diff-f1fe594a2f3e40a35022a96a2eedbc85d3edf4df331f6607d249aa411ed23a2f
https://github.com/github/codeql/pull/4457/files#diff-f1fe594a2f3e40a35022a96a2eedbc85d3edf4df331f6607d249aa411ed23a2f
https://github.com/github/codeql/blob/main/CODEOWNERS#L16
java/ql/test/library-tests/dataflow/taint/test.expectedhttps://github.com/github/codeql/pull/4457/files#diff-a188ac5f1c80d57841cb6f5d9a41ee23ea1b870f6eb000ca5d55ee862f3419bc
View file https://github.com/daniel-beck/codeql/blob/0c70be145f366446fc593b1617268b4bd9728693/java/ql/test/library-tests/dataflow/taint/test.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/4457/{{ revealButtonHref }}
https://github.com/github/codeql/pull/4457/files#diff-a188ac5f1c80d57841cb6f5d9a41ee23ea1b870f6eb000ca5d55ee862f3419bc
https://github.com/github/codeql/pull/4457/files#diff-a188ac5f1c80d57841cb6f5d9a41ee23ea1b870f6eb000ca5d55ee862f3419bc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.