René's URL Explorer Experiment


Title: JS: Add startsWith-sanitizer to redirect queries by asgerf · Pull Request #3892 · github/codeql · GitHub

Open Graph Title: JS: Add startsWith-sanitizer to redirect queries by asgerf · Pull Request #3892 · github/codeql

X Title: JS: Add startsWith-sanitizer to redirect queries by asgerf · Pull Request #3892 · github/codeql

Description: Fixes a FP I spotted in the evaluation of #3835, which was due to a missing sanitizer, not because of the PR.

Open Graph Description: Fixes a FP I spotted in the evaluation of #3835, which was due to a missing sanitizer, not because of the PR.

X Description: Fixes a FP I spotted in the evaluation of #3835, which was due to a missing sanitizer, not because of the PR.

Opengraph URL: https://github.com/github/codeql/pull/3892

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9dfdd52a-8133-914d-7264-b06620ca6acd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAAA:A2022:2DFEEEF:3F3C53D:6A4F153A
html-safe-noncefe480c8c914820a44bc980d0a7982b8c6f608ab6683df3574dd4c2ccb1c3780f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUFBOkEyMDIyOjJERkVFRUY6M0YzQzUzRDo2QTRGMTUzQSIsInZpc2l0b3JfaWQiOiI3OTE1ODg0NjE2NzgyNjQ4NjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0a9b73c60f714d594043b03c77b02cefa18e41f3db0d915decd37c350fbd4bea
hovercard-subject-tagpull_request:444069338
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/3892/files
twitter:imagehttps://avatars.githubusercontent.com/u/316427?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/316427?s=400&v=4
og:image:altFixes a FP I spotted in the evaluation of #3835, which was due to a missing sanitizer, not because of the PR.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/3892/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3892%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3892%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/3892/files
Reloadhttps://github.com/github/codeql/pull/3892/files
Reloadhttps://github.com/github/codeql/pull/3892/files
Please reload this pagehttps://github.com/github/codeql/pull/3892/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 986 https://github.com/github/codeql/issues
Pull requests 424 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
semmle-qlcihttps://github.com/semmle-qlci
github:masterhttps://github.com/github/codeql/tree/master
asger-semmle:js/redirect-starts-with-sanitizerhttps://github.com/asger-semmle/ql/tree/js/redirect-starts-with-sanitizer
Conversation 3 https://github.com/github/codeql/pull/3892
Findings https://github.com/github/codeql/pull/3892/findings
Commits 3 https://github.com/github/codeql/pull/3892/commits
Checks 0 https://github.com/github/codeql/pull/3892/checks
Files changed https://github.com/github/codeql/pull/3892/files
Please reload this pagehttps://github.com/github/codeql/pull/3892/files
JS: Add startsWith-sanitizer to redirect queries https://github.com/github/codeql/pull/3892/files#top
Show all changes 3 commits https://github.com/github/codeql/pull/3892/files
4c06eb8 JS: Add test showing FPs asgerf Jul 3, 2020 https://github.com/github/codeql/pull/3892/commits/4c06eb8bfec5b1fbac8f04557cf7c64b1d0da0ca
b5104ae JS: Add StartsWith sanitizer asgerf Jul 3, 2020 https://github.com/github/codeql/pull/3892/commits/b5104ae42d545bc75927fcb0453a1c85420cd89f
9a94462 autoformat erik-krogh Jul 6, 2020 https://github.com/github/codeql/pull/3892/commits/9a944625d167f7c985ef557ea819726ff1310c5b
Clear filters https://github.com/github/codeql/pull/3892/files
Please reload this pagehttps://github.com/github/codeql/pull/3892/files
Please reload this pagehttps://github.com/github/codeql/pull/3892/files
ClientSideUrlRedirect.qll https://github.com/github/codeql/pull/3892/files#diff-40af42befc9bd16a7a423afa1298cfceda4c1365c0e0937bfdf40bbbbbd83060
ClientSideUrlRedirectCustomizations.qll https://github.com/github/codeql/pull/3892/files#diff-109f360edd55bbe30d2d15fc51fb1292100718a7e2f082c09a07fd48a1a82e33
ServerSideUrlRedirect.qll https://github.com/github/codeql/pull/3892/files#diff-3b4bfaeeabf925f3c3f6a5c42817d230c16a47a926ffb8915acf2c3d97183228
ServerSideUrlRedirectCustomizations.qll https://github.com/github/codeql/pull/3892/files#diff-3490ac5ca9514a2fab9984819d3ea16b03a9dec70e10e67fc08d3e327df18179
UrlConcatenation.qll https://github.com/github/codeql/pull/3892/files#diff-e7d88807d734e896edad70900b32b2fb855175706e1d81e31cda3802a2c1e169
ClientSideUrlRedirect.expected https://github.com/github/codeql/pull/3892/files#diff-09826b26a0dcae5519da9a77f7665d22f3531423299cff64ccf0d743ea7b1556
sanitizer.js https://github.com/github/codeql/pull/3892/files#diff-66c1e1c09fb5bfd78e273706befee43381fadca3774a1b42742c883077a11c49
javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirect.qllhttps://github.com/github/codeql/pull/3892/files#diff-40af42befc9bd16a7a423afa1298cfceda4c1365c0e0937bfdf40bbbbbd83060
View file https://github.com/asger-semmle/ql/blob/9a944625d167f7c985ef557ea819726ff1310c5b/javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirect.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3892/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3892/files#diff-40af42befc9bd16a7a423afa1298cfceda4c1365c0e0937bfdf40bbbbbd83060
...script/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qllhttps://github.com/github/codeql/pull/3892/files#diff-109f360edd55bbe30d2d15fc51fb1292100718a7e2f082c09a07fd48a1a82e33
View file https://github.com/asger-semmle/ql/blob/9a944625d167f7c985ef557ea819726ff1310c5b/javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3892/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3892/files#diff-109f360edd55bbe30d2d15fc51fb1292100718a7e2f082c09a07fd48a1a82e33
https://github.com/github/codeql/pull/3892/files#diff-109f360edd55bbe30d2d15fc51fb1292100718a7e2f082c09a07fd48a1a82e33
javascript/ql/src/semmle/javascript/security/dataflow/ServerSideUrlRedirect.qllhttps://github.com/github/codeql/pull/3892/files#diff-3b4bfaeeabf925f3c3f6a5c42817d230c16a47a926ffb8915acf2c3d97183228
View file https://github.com/asger-semmle/ql/blob/9a944625d167f7c985ef557ea819726ff1310c5b/javascript/ql/src/semmle/javascript/security/dataflow/ServerSideUrlRedirect.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3892/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3892/files#diff-3b4bfaeeabf925f3c3f6a5c42817d230c16a47a926ffb8915acf2c3d97183228
...script/ql/src/semmle/javascript/security/dataflow/ServerSideUrlRedirectCustomizations.qllhttps://github.com/github/codeql/pull/3892/files#diff-3490ac5ca9514a2fab9984819d3ea16b03a9dec70e10e67fc08d3e327df18179
View file https://github.com/asger-semmle/ql/blob/9a944625d167f7c985ef557ea819726ff1310c5b/javascript/ql/src/semmle/javascript/security/dataflow/ServerSideUrlRedirectCustomizations.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3892/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3892/files#diff-3490ac5ca9514a2fab9984819d3ea16b03a9dec70e10e67fc08d3e327df18179
https://github.com/github/codeql/pull/3892/files#diff-3490ac5ca9514a2fab9984819d3ea16b03a9dec70e10e67fc08d3e327df18179
javascript/ql/src/semmle/javascript/security/dataflow/UrlConcatenation.qllhttps://github.com/github/codeql/pull/3892/files#diff-e7d88807d734e896edad70900b32b2fb855175706e1d81e31cda3802a2c1e169
View file https://github.com/asger-semmle/ql/blob/9a944625d167f7c985ef557ea819726ff1310c5b/javascript/ql/src/semmle/javascript/security/dataflow/UrlConcatenation.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3892/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3892/files#diff-e7d88807d734e896edad70900b32b2fb855175706e1d81e31cda3802a2c1e169
...ql/test/query-tests/Security/CWE-601/ClientSideUrlRedirect/ClientSideUrlRedirect.expectedhttps://github.com/github/codeql/pull/3892/files#diff-09826b26a0dcae5519da9a77f7665d22f3531423299cff64ccf0d743ea7b1556
View file https://github.com/asger-semmle/ql/blob/9a944625d167f7c985ef557ea819726ff1310c5b/javascript/ql/test/query-tests/Security/CWE-601/ClientSideUrlRedirect/ClientSideUrlRedirect.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3892/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3892/files#diff-09826b26a0dcae5519da9a77f7665d22f3531423299cff64ccf0d743ea7b1556
https://github.com/github/codeql/pull/3892/files#diff-09826b26a0dcae5519da9a77f7665d22f3531423299cff64ccf0d743ea7b1556
https://github.com/github/codeql/pull/3892/files#diff-09826b26a0dcae5519da9a77f7665d22f3531423299cff64ccf0d743ea7b1556
https://github.com/github/codeql/pull/3892/files#diff-09826b26a0dcae5519da9a77f7665d22f3531423299cff64ccf0d743ea7b1556
https://github.com/github/codeql/pull/3892/files#diff-09826b26a0dcae5519da9a77f7665d22f3531423299cff64ccf0d743ea7b1556
javascript/ql/test/query-tests/Security/CWE-601/ClientSideUrlRedirect/sanitizer.jshttps://github.com/github/codeql/pull/3892/files#diff-66c1e1c09fb5bfd78e273706befee43381fadca3774a1b42742c883077a11c49
View file https://github.com/asger-semmle/ql/blob/9a944625d167f7c985ef557ea819726ff1310c5b/javascript/ql/test/query-tests/Security/CWE-601/ClientSideUrlRedirect/sanitizer.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3892/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.