René's URL Explorer Experiment


Title: JS: Add startsWith-sanitizer to redirect queries by asgerf · Pull Request #3892 · github/codeql · GitHub

Open Graph Title: JS: Add startsWith-sanitizer to redirect queries by asgerf · Pull Request #3892 · github/codeql

X Title: JS: Add startsWith-sanitizer to redirect queries by asgerf · Pull Request #3892 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - JS: Add startsWith-sanitizer to redirect queries by asgerf · Pull Request #3892 · github/codeql

Open Graph Description: Fixes a FP I spotted in the evaluation of #3835, which was due to a missing sanitizer, not because of the PR.

X Description: Fixes a FP I spotted in the evaluation of #3835, which was due to a missing sanitizer, not because of the PR.

Opengraph URL: https://github.com/github/codeql/pull/3892

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cfc76107-7adc-5402-8bae-df3a97d7fed0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADC2:105A4A:20757ED:2C6569B:6A4EC39B
html-safe-nonce93c8305b84f594ff90b712ab9098001eacccbd134b234ae83fc4c75a8c772832
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREMyOjEwNUE0QToyMDc1N0VEOjJDNjU2OUI6NkE0RUMzOUIiLCJ2aXNpdG9yX2lkIjoiNTAyMTQwMzcyOTYyODE1MjczMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8c0eacbfeccd78da798539b2316b2b9366440c0a62faca600ee5816728a1aab8
hovercard-subject-tagpull_request:444069338
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/3892/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c8de426c6a94620660b3db1a64d3d7ba8b73ebe6dc1a7e08a8ed17a65b66d4f1/github/codeql/pull/3892
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c8de426c6a94620660b3db1a64d3d7ba8b73ebe6dc1a7e08a8ed17a65b66d4f1/github/codeql/pull/3892
og:image:altFixes a FP I spotted in the evaluation of #3835, which was due to a missing sanitizer, not because of the PR.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameasgerf
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/3892#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3892
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3892
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/3892
Reloadhttps://github.com/github/codeql/pull/3892
Reloadhttps://github.com/github/codeql/pull/3892
Please reload this pagehttps://github.com/github/codeql/pull/3892
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 986 https://github.com/github/codeql/issues
Pull requests 423 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
semmle-qlcihttps://github.com/semmle-qlci
github:masterhttps://github.com/github/codeql/tree/master
asger-semmle:js/redirect-starts-with-sanitizerhttps://github.com/asger-semmle/ql/tree/js/redirect-starts-with-sanitizer
Conversationhttps://github.com/github/codeql/pull/3892
Commits3 (3)https://github.com/github/codeql/pull/3892/commits
Checkshttps://github.com/github/codeql/pull/3892/checks
Files changedhttps://github.com/github/codeql/pull/3892/files
JS: Add startsWith-sanitizer to redirect querieshttps://github.com/github/codeql/pull/3892#top
semmle-qlcihttps://github.com/semmle-qlci
github:masterhttps://github.com/github/codeql/tree/master
asger-semmle:js/redirect-starts-with-sanitizerhttps://github.com/asger-semmle/ql/tree/js/redirect-starts-with-sanitizer
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jul 3, 2020https://github.com/github/codeql/pull/3892#issue-650610906
#3835https://github.com/github/codeql/pull/3835
Please reload this pagehttps://github.com/github/codeql/pull/3892
asgerfhttps://github.com/asgerf
July 3, 2020 14:45https://github.com/github/codeql/pull/3892#commits-pushed-4c06eb8
https://github.com/asgerf
JS: Add test showing FPshttps://github.com/github/codeql/pull/3892/commits/4c06eb8bfec5b1fbac8f04557cf7c64b1d0da0ca
4c06eb8https://github.com/github/codeql/pull/3892/commits/4c06eb8bfec5b1fbac8f04557cf7c64b1d0da0ca
https://github.com/asgerf
JS: Add StartsWith sanitizerhttps://github.com/github/codeql/pull/3892/commits/b5104ae42d545bc75927fcb0453a1c85420cd89f
b5104aehttps://github.com/github/codeql/pull/3892/commits/b5104ae42d545bc75927fcb0453a1c85420cd89f
https://github.com/asgerf
asgerfhttps://github.com/asgerf
JS https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS
Awaiting evaluation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3A%22Awaiting%20evaluation%22
Jul 3, 2020https://github.com/github/codeql/pull/3892#event-3511134127
https://github.com/asgerf
asgerfhttps://github.com/asgerf
code ownerhttps://github.com/github/codeql/blob/04a0d47ab9cc38645b06a38cd950a158ef99ed1e/CODEOWNERS#L4
July 3, 2020 13:51https://github.com/github/codeql/pull/3892#event-3511134140
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jul 3, 2020 https://github.com/github/codeql/pull/3892#ref-pullrequest-647448670
[js/client-side-unvalidated-url-redirection] add interpretsValueAsJavaScript predicate #3835 https://github.com/github/codeql/pull/3835
https://github.com/erik-krogh
erik-kroghhttps://github.com/erik-krogh
Jul 6, 2020 https://github.com/github/codeql/pull/3892#pullrequestreview-442923467
View reviewed changes https://github.com/github/codeql/pull/3892/files/b5104ae42d545bc75927fcb0453a1c85420cd89f
erik-kroghhttps://github.com/erik-krogh
https://github.com/github/codeql/pull/3892#pullrequestreview-442923467
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3892
https://github.com/erik-krogh
erik-kroghhttps://github.com/erik-krogh
Jul 6, 2020 https://github.com/github/codeql/pull/3892#pullrequestreview-443065159
View reviewed changes https://github.com/github/codeql/pull/3892/files/b5104ae42d545bc75927fcb0453a1c85420cd89f
javascript/ql/src/semmle/javascript/security/dataflow/UrlConcatenation.qllhttps://github.com/github/codeql/pull/3892/files/b5104ae42d545bc75927fcb0453a1c85420cd89f#diff-e7d88807d734e896edad70900b32b2fb855175706e1d81e31cda3802a2c1e169
Please reload this pagehttps://github.com/github/codeql/pull/3892
https://github.com/erik-krogh
autoformathttps://github.com/github/codeql/pull/3892/commits/9a944625d167f7c985ef557ea819726ff1310c5b
9a94462https://github.com/github/codeql/pull/3892/commits/9a944625d167f7c985ef557ea819726ff1310c5b
https://github.com/esbena
esbenahttps://github.com/esbena
Jul 6, 2020 https://github.com/github/codeql/pull/3892#pullrequestreview-443075112
View reviewed changes https://github.com/github/codeql/pull/3892/files/9a944625d167f7c985ef557ea819726ff1310c5b
https://github.com/semmle-qlci
semmle-qlcihttps://github.com/semmle-qlci
fe0c5a9https://github.com/github/codeql/commit/fe0c5a9ea6512e5a9e384833ae640ac8f4f7a31f
Jul 6, 2020https://github.com/github/codeql/pull/3892#event-3516642635
https://github.com/erik-krogh
erik-kroghhttps://github.com/erik-krogh
Jul 7, 2020https://github.com/github/codeql/pull/3892#issuecomment-654660566
here is an evaluationhttps://git.semmle.com/erik/dist-compare-reports/tree/profiling-erik-krogh.northeurope.cloudapp.azure.com_1594088439719
Please reload this pagehttps://github.com/github/codeql/pull/3892
https://github.com/erik-krogh
erik-kroghhttps://github.com/erik-krogh
Awaiting evaluation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3A%22Awaiting%20evaluation%22
Jul 7, 2020https://github.com/github/codeql/pull/3892#event-3519049570
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3892
https://github.com/erik-krogh
erik-krogh https://github.com/erik-krogh
https://github.com/github/codeql/pull/3892/files/b5104ae42d545bc75927fcb0453a1c85420cd89f
https://github.com/esbena
esbena https://github.com/esbena
https://github.com/github/codeql/pull/3892/files/9a944625d167f7c985ef557ea819726ff1310c5b
JS https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS
Please reload this pagehttps://github.com/github/codeql/pull/3892
https://github.com/asgerf
https://github.com/erik-krogh
https://github.com/esbena
https://github.com/semmle-qlci
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.