René's URL Explorer Experiment


Title: JS: Monorepo support: bugfixes and separate from dependency installation by asgerf · Pull Request #3731 · github/codeql · GitHub

Open Graph Title: JS: Monorepo support: bugfixes and separate from dependency installation by asgerf · Pull Request #3731 · github/codeql

X Title: JS: Monorepo support: bugfixes and separate from dependency installation by asgerf · Pull Request #3731 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - JS: Monorepo support: bugfixes and separate from dependency installation by asgerf · Pull Request #3731 · github/codeql

Open Graph Description: This PR largely does four things: Make extraction more deterministic by sorting files and choosing more carefully to extract TypeScript files with the right tsconfig.json file. Bugfixes: Use LGTM...

X Description: This PR largely does four things: Make extraction more deterministic by sorting files and choosing more carefully to extract TypeScript files with the right tsconfig.json file. Bugfixes: Use LGTM...

Opengraph URL: https://github.com/github/codeql/pull/3731

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:61608ec1-ebed-bde1-eacc-d8248157fd2d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC266:1148D3:637BD4:81275D:6B00E01D
html-safe-nonce6cf77b4122b53ac36c0f1f6931bbdf7fb38f07573929776bbedd45ed00e7f37f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjY2OjExNDhEMzo2MzdCRDQ6ODEyNzVEOjZCMDBFMDFEIiwidmlzaXRvcl9pZCI6Ijc2MjE1NzIyMTA0NjkxNjcxMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbdda2fcaaab8b3bbb60e58a9a7e602d11e9c2e2c003141e47a0c314029785d4e
hovercard-subject-tagpull_request:435701754
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/3731/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7e474adb50af5e7a2ec3487e13e55b248c9f4b81ae6b8b8a52ebfdeb33a7f3de/github/codeql/pull/3731
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7e474adb50af5e7a2ec3487e13e55b248c9f4b81ae6b8b8a52ebfdeb33a7f3de/github/codeql/pull/3731
og:image:altThis PR largely does four things: Make extraction more deterministic by sorting files and choosing more carefully to extract TypeScript files with the right tsconfig.json file. Bugfixes: Use LGTM...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameasgerf
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/github/codeql/pull/3731#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3731
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3731
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/3731
Reloadhttps://github.com/github/codeql/pull/3731
Reloadhttps://github.com/github/codeql/pull/3731
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests507 (507)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/insights
https://github.com/github/codeql
semmle-qlcihttps://github.com/semmle-qlci
github:masterhttps://github.com/github/codeql/tree/master
asger-semmle:js/monorepo-bugfixeshttps://github.com/asger-semmle/ql/tree/js/monorepo-bugfixes
Conversationhttps://github.com/github/codeql/pull/3731
Commits12 (12)https://github.com/github/codeql/pull/3731/commits
Checkshttps://github.com/github/codeql/pull/3731/checks
Findingshttps://github.com/github/codeql/pull/3731/findings
Files changedhttps://github.com/github/codeql/pull/3731/files
JS: Monorepo support: bugfixes and separate from dependency installationhttps://github.com/github/codeql/pull/3731#top
semmle-qlcihttps://github.com/semmle-qlci
github:masterhttps://github.com/github/codeql/tree/master
asger-semmle:js/monorepo-bugfixeshttps://github.com/asger-semmle/ql/tree/js/monorepo-bugfixes
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jun 17, 2020https://github.com/github/codeql/pull/3731#issue-640262630
Please reload this pagehttps://github.com/github/codeql/pull/3731
typescript-fullhttps://git.semmle.com/asger/dist-compare-reports/tree/js/monorepo-bugfixes_1592157799600
security/smoke-testhttps://git.semmle.com/asger/dist-compare-reports/tree/js/monorepo-bugfixes_1592349543319
security/nightlyhttps://git.semmle.com/asger/dist-compare-reports/tree/js/monorepo-bugfixes_1592325006302
This JS-Differences jobhttps://jenkins.internal.semmle.com/job/Changes/job/JS-Differences/148//artifact/data/data.html
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
asgerfhttps://github.com/asgerf
JS https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS
Awaiting evaluation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3A%22Awaiting%20evaluation%22
Jun 17, 2020https://github.com/github/codeql/pull/3731#event-3452541680
https://github.com/asgerf
asgerfhttps://github.com/asgerf
code ownerhttps://github.com/github/codeql/blob/ab327b989d9bc81fd1fcf8b8fc99264893ca46a6/CODEOWNERS#L4
June 17, 2020 08:51https://github.com/github/codeql/pull/3731#event-3452541689
https://github.com/erik-krogh
erik-kroghhttps://github.com/erik-krogh
Jun 17, 2020 https://github.com/github/codeql/pull/3731#pullrequestreview-432506678
View reviewed changes https://github.com/github/codeql/pull/3731/files
erik-kroghhttps://github.com/erik-krogh
https://github.com/github/codeql/pull/3731#pullrequestreview-432506678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jun 17, 2020https://github.com/github/codeql/pull/3731#issuecomment-645494476
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jun 18, 2020https://github.com/github/codeql/pull/3731#issuecomment-645840485
evaluationhttps://git.semmle.com/asger/dist-compare-reports/tree/js/monorepo-bugfixes_1592441519327
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/erik-krogh
erik-kroghhttps://github.com/erik-krogh
Jun 18, 2020 https://github.com/github/codeql/pull/3731#pullrequestreview-433218022
View reviewed changes https://github.com/github/codeql/pull/3731/files
erik-kroghhttps://github.com/erik-krogh
https://github.com/github/codeql/pull/3731#pullrequestreview-433218022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
evaluationhttps://git.semmle.com/asger/dist-compare-reports/tree/js/monorepo-bugfixes_1592441519327
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jun 19, 2020https://github.com/github/codeql/pull/3731#issuecomment-646891451
distribution buildhttps://git.semmle.com/gist/asger/d0e19ab87ad0a67b75c8e073f2ba17b9
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jun 24, 2020 https://github.com/github/codeql/pull/3731#ref-pullrequest-644459459
JS: Add more metric queries #3779 https://github.com/github/codeql/pull/3779
asgerfhttps://github.com/asgerf
June 25, 2020 15:38https://github.com/github/codeql/pull/3731#commits-pushed-cb0a249
https://github.com/asgerf
JS: Sort fileshttps://github.com/github/codeql/pull/3731/commits/cb0a2498b004857b5b56ce13af8836d4e8d31b23
cb0a249https://github.com/github/codeql/pull/3731/commits/cb0a2498b004857b5b56ce13af8836d4e8d31b23
https://github.com/asgerf
JS: Fix source roothttps://github.com/github/codeql/pull/3731/commits/aaf141782f1a3ee0bafab025a8226bdc3c35870b
aaf1417https://github.com/github/codeql/pull/3731/commits/aaf141782f1a3ee0bafab025a8226bdc3c35870b
https://github.com/asgerf
JS: Pass source root to Node.js processhttps://github.com/github/codeql/pull/3731/commits/dceb2110210f89c8a1b1df4ef12aa49baaf028a9
dceb211https://github.com/github/codeql/pull/3731/commits/dceb2110210f89c8a1b1df4ef12aa49baaf028a9
https://github.com/asgerf
JS: Actually set fieldshttps://github.com/github/codeql/pull/3731/commits/ba5d6bb2e9e70f9a76d4fb4b0ce750724c068e98
ba5d6bbhttps://github.com/github/codeql/pull/3731/commits/ba5d6bb2e9e70f9a76d4fb4b0ce750724c068e98
https://github.com/asgerf
JS: Ensure we never write outside the scratch dirhttps://github.com/github/codeql/pull/3731/commits/6d15397fdc7b4ee597a11666ebde56ea5a26ed2f
6d15397https://github.com/github/codeql/pull/3731/commits/6d15397fdc7b4ee597a11666ebde56ea5a26ed2f
https://github.com/asgerf
JS: Also sort files in legacy extractorhttps://github.com/github/codeql/pull/3731/commits/6ff81377d5b5e5fce112c5597156053caf5a10a7
6ff8137https://github.com/github/codeql/pull/3731/commits/6ff81377d5b5e5fce112c5597156053caf5a10a7
https://github.com/asgerf
JS: Only extract included files with a given tsconfighttps://github.com/github/codeql/pull/3731/commits/cf784757997035b07430bc1eb96068122abf2a81
cf78475https://github.com/github/codeql/pull/3731/commits/cf784757997035b07430bc1eb96068122abf2a81
https://github.com/asgerf
JS: Move stack trace limit to top of filehttps://github.com/github/codeql/pull/3731/commits/cc3e62f5357459aade88219cbc8d413b8ab016fa
cc3e62fhttps://github.com/github/codeql/pull/3731/commits/cc3e62f5357459aade88219cbc8d413b8ab016fa
https://github.com/asgerf
JS: Factor out loading of tsconfig fileshttps://github.com/github/codeql/pull/3731/commits/4c4acd50bdb05ad8badb41c06213aadd90359766
4c4acd5https://github.com/github/codeql/pull/3731/commits/4c4acd50bdb05ad8badb41c06213aadd90359766
https://github.com/asgerf
JS: Prefer extracting file with tsconfig that included ithttps://github.com/github/codeql/pull/3731/commits/675c64d9d4b32957c0c821c7f80d60e2bab7c3c8
675c64dhttps://github.com/github/codeql/pull/3731/commits/675c64d9d4b32957c0c821c7f80d60e2bab7c3c8
https://github.com/asgerf
JS: Always prepare package.json fileshttps://github.com/github/codeql/pull/3731/commits/ad48c4e54d1b80c698f61f1274eea2e97c2b1593
ad48c4ehttps://github.com/github/codeql/pull/3731/commits/ad48c4e54d1b80c698f61f1274eea2e97c2b1593
https://github.com/asgerf
JS: Fix javadochttps://github.com/github/codeql/pull/3731/commits/e28284bd01298a83ec4bf46a4dda73c224a9af05
e28284bhttps://github.com/github/codeql/pull/3731/commits/e28284bd01298a83ec4bf46a4dda73c224a9af05
https://github.com/asgerf
asgerfhttps://github.com/asgerf
erik-kroghhttps://github.com/erik-krogh
stale reviewhttps://github.com/github/codeql/pull/3731#pullrequestreview-433218022
e28284bhttps://github.com/github/codeql/commit/e28284bd01298a83ec4bf46a4dda73c224a9af05
June 25, 2020 14:39https://github.com/github/codeql/pull/3731#event-3482717560
https://github.com/asgerf
asgerfhttps://github.com/asgerf
force-pushedhttps://github.com/github/codeql/compare/f9191a1fd46a44dbc7d982763bd01f9ba1b7c113..e28284bd01298a83ec4bf46a4dda73c224a9af05
f9191a1https://github.com/github/codeql/commit/f9191a1fd46a44dbc7d982763bd01f9ba1b7c113
e28284bhttps://github.com/github/codeql/commit/e28284bd01298a83ec4bf46a4dda73c224a9af05
Compare https://github.com/github/codeql/compare/f9191a1fd46a44dbc7d982763bd01f9ba1b7c113..e28284bd01298a83ec4bf46a4dda73c224a9af05
June 25, 2020 14:39https://github.com/github/codeql/pull/3731#event-3482717563
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jun 25, 2020https://github.com/github/codeql/pull/3731#issuecomment-649594803
#3781https://github.com/github/codeql/pull/3781
#3781https://github.com/github/codeql/pull/3781
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Jun 26, 2020https://github.com/github/codeql/pull/3731#issuecomment-650069339
Security/typescript-fullhttps://git.semmle.com/asger/dist-compare-reports/tree/js/monorepo-bugfixes_1593133304476
Extraction timehttps://jenkins.internal.semmle.com/job/Changes/job/JS-Differences/160//artifact/data/data.html
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
asgerfhttps://github.com/asgerf
Awaiting evaluation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3A%22Awaiting%20evaluation%22
Jun 26, 2020https://github.com/github/codeql/pull/3731#event-3485797414
https://github.com/erik-krogh
erik-kroghhttps://github.com/erik-krogh
Jun 26, 2020 https://github.com/github/codeql/pull/3731#pullrequestreview-438222216
View reviewed changes https://github.com/github/codeql/pull/3731/files/e28284bd01298a83ec4bf46a4dda73c224a9af05
erik-kroghhttps://github.com/erik-krogh
https://github.com/github/codeql/pull/3731#pullrequestreview-438222216
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3731
javascript/extractor/src/com/semmle/js/extractor/DependencyInstallationResult.javahttps://github.com/github/codeql/pull/3731/files/e28284bd01298a83ec4bf46a4dda73c224a9af05#diff-5266bf16a477dc888a46c2773b219d20d41d87017d593492a6fcecdb7f162d66
erik-kroghhttps://github.com/erik-krogh
Jun 26, 2020https://github.com/github/codeql/pull/3731#discussion_r446129122
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3731
asgerfhttps://github.com/asgerf
Jun 26, 2020https://github.com/github/codeql/pull/3731#discussion_r446158309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/semmle-qlci
semmle-qlcihttps://github.com/semmle-qlci
1b4df57https://github.com/github/codeql/commit/1b4df57426ae910cde1bc417f42ca03e5212003a
Jun 26, 2020https://github.com/github/codeql/pull/3731#event-3486573155
https://github.com/nickrolfe
nickrolfehttps://github.com/nickrolfe
Jun 29, 2020 https://github.com/github/codeql/pull/3731#pullrequestreview-439040886
View reviewed changes https://github.com/github/codeql/pull/3731/files/e28284bd01298a83ec4bf46a4dda73c224a9af05
javascript/extractor/src/com/semmle/js/extractor/AutoBuild.javahttps://github.com/github/codeql/pull/3731/files/e28284bd01298a83ec4bf46a4dda73c224a9af05#diff-dfec202bb4425c99bf844bc2e4248e78fe2bda1e9f4e04e03ae51c92917acff0
nickrolfehttps://github.com/nickrolfe
Jun 29, 2020https://github.com/github/codeql/pull/3731#discussion_r446895100
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3731
javascript/extractor/src/com/semmle/js/extractor/AutoBuild.javahttps://github.com/github/codeql/pull/3731/files/e28284bd01298a83ec4bf46a4dda73c224a9af05#diff-dfec202bb4425c99bf844bc2e4248e78fe2bda1e9f4e04e03ae51c92917acff0
nickrolfehttps://github.com/nickrolfe
Jun 29, 2020https://github.com/github/codeql/pull/3731#discussion_r446895184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3731
https://github.com/nickrolfe
nickrolfe https://github.com/nickrolfe
https://github.com/github/codeql/pull/3731/files/e28284bd01298a83ec4bf46a4dda73c224a9af05
https://github.com/erik-krogh
erik-krogh https://github.com/erik-krogh
https://github.com/github/codeql/pull/3731/files/e28284bd01298a83ec4bf46a4dda73c224a9af05
Please reload this pagehttps://github.com/github/codeql/pull/3731
JS https://github.com/github/codeql/issues?q=state%3Aopen%20label%3AJS
Please reload this pagehttps://github.com/github/codeql/pull/3731
https://github.com/asgerf
https://github.com/nickrolfe
https://github.com/erik-krogh
https://github.com/semmle-qlci
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.