René's URL Explorer Experiment


Title: Java: CWE-273 Unsafe certificate trust by luchua-bc · Pull Request #3550 · github/codeql · GitHub

Open Graph Title: Java: CWE-273 Unsafe certificate trust by luchua-bc · Pull Request #3550 · github/codeql

X Title: Java: CWE-273 Unsafe certificate trust by luchua-bc · Pull Request #3550 · github/codeql

Description: Java offers two mechanisms for SSL authentication - trust manager and hostname verifier. Trust manager validates the peer's certificate chain while hostname verification establishes that the hostname in the URL matches the hostname in the server's identification. Unsafe implementation of the interface X509TrustManager and HostnameVerifier ignores all SSL certificate validation errors when establishing an HTTPS connection, thereby making the app vulnerable to man-in-the-middle attacks. This is a very common issue with web development. The query checks whether trust manager is set to trust all certificates or the hostname verifier is turned off. I've tested it against some GitHub projects, and a test case has been created. Please consider to merge the PR. Thanks.

Open Graph Description: Java offers two mechanisms for SSL authentication - trust manager and hostname verifier. Trust manager validates the peer's certificate chain while hostname verification establishes that the ho...

X Description: Java offers two mechanisms for SSL authentication - trust manager and hostname verifier. Trust manager validates the peer's certificate chain while hostname verification establishes that th...

Opengraph URL: https://github.com/github/codeql/pull/3550

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d608dd2c-a4fa-6ba9-c2bb-42c2a7158ab8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8380:2495A6:2CAB73:3F44D5:6A4C9EF2
html-safe-nonce8a8098e00112133f34e39c41a0835e6555b95657478cbeb6e559a39cf1a93954
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzgwOjI0OTVBNjoyQ0FCNzM6M0Y0NEQ1OjZBNEM5RUYyIiwidmlzaXRvcl9pZCI6IjUwMTcwMjI0ODUwMjg5NzAyMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7ced15b6dc1bb376ec75ca24d5352126c543e0f675a24ceed3977fe83d149788
hovercard-subject-tagpull_request:422439534
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/3550/files
twitter:imagehttps://avatars.githubusercontent.com/u/37377780?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/37377780?s=400&v=4
og:image:altJava offers two mechanisms for SSL authentication - trust manager and hostname verifier. Trust manager validates the peer's certificate chain while hostname verification establishes that the ho...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseae90d426644ca15e89bacceb72e51f4e9dbf85f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/3550/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3550%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3550%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/3550/files
Reloadhttps://github.com/github/codeql/pull/3550/files
Reloadhttps://github.com/github/codeql/pull/3550/files
Please reload this pagehttps://github.com/github/codeql/pull/3550/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 424 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
aschackmullhttps://github.com/aschackmull
github:masterhttps://github.com/github/codeql/tree/master
luchua-bc:java-unsafe-cert-trusthttps://github.com/luchua-bc/ql/tree/java-unsafe-cert-trust
Conversation 29 https://github.com/github/codeql/pull/3550
Findings https://github.com/github/codeql/pull/3550/findings
Commits 5 https://github.com/github/codeql/pull/3550/commits
Checks 0 https://github.com/github/codeql/pull/3550/checks
Files changed https://github.com/github/codeql/pull/3550/files
Please reload this pagehttps://github.com/github/codeql/pull/3550/files
Java: CWE-273 Unsafe certificate trust https://github.com/github/codeql/pull/3550/files#top
Show all changes 5 commits https://github.com/github/codeql/pull/3550/files
6d1ba3f Java: CWE-273 Unsafe certificate trust luchua-bc May 24, 2020 https://github.com/github/codeql/pull/3550/commits/6d1ba3f8997a633af8fe93fe3c6e53e94966b5ef
104f1c3 Add validation query for SSL Engine/Socket and com.rabbitmq.client.Co… luchua-bc May 28, 2020 https://github.com/github/codeql/pull/3550/commits/104f1c3197d6399880a6a63e8398765690a34a23
deabfe6 Adjust id tag and fix ending line error luchua-bc Jun 23, 2020 https://github.com/github/codeql/pull/3550/commits/deabfe6e5cba6755ee6132c3ec7985a17c2cc63c
f8c4947 Fix ending line error luchua-bc Jun 23, 2020 https://github.com/github/codeql/pull/3550/commits/f8c494716fa0800b0b4d95e83222a68ae79e1ee0
0779aab Clean up the QL code luchua-bc Jun 24, 2020 https://github.com/github/codeql/pull/3550/commits/0779aab28fe1baa0db8a70862e932a7a05e2a670
Clear filters https://github.com/github/codeql/pull/3550/files
Please reload this pagehttps://github.com/github/codeql/pull/3550/files
Please reload this pagehttps://github.com/github/codeql/pull/3550/files
UnsafeCertTrust.java https://github.com/github/codeql/pull/3550/files#diff-54313639648ebcc42206f6ff8a991fbed8c8918c1356faf9ebc0c225f776ec71
UnsafeCertTrust.qhelp https://github.com/github/codeql/pull/3550/files#diff-0b30e0f46fb9b453edfc8b85aa118489ac41cdaf26084ba7fe182bf49ea9fca7
UnsafeCertTrust.ql https://github.com/github/codeql/pull/3550/files#diff-0831fd5750f3ff67152a34c554e1f7c5cbf12a17d64fc1ffb3d842a292685cea
UnsafeCertTrust.expected https://github.com/github/codeql/pull/3550/files#diff-0ec81f6ae02a0e8e5af8eb074ec502146d4a8bd1586094ee6e3d34ca7d90a382
UnsafeCertTrust.qlref https://github.com/github/codeql/pull/3550/files#diff-38384a283446001658369b4f31f4a79636d1b5cfadec9515c606f6871343cde8
UnsafeCertTrustTest.java https://github.com/github/codeql/pull/3550/files#diff-8f8d2146e6476263ac25e1c84619ea4564aa5c8a3c1b39280c546e8e6e09dd7f
java/ql/src/experimental/Security/CWE/CWE-273/UnsafeCertTrust.javahttps://github.com/github/codeql/pull/3550/files#diff-54313639648ebcc42206f6ff8a991fbed8c8918c1356faf9ebc0c225f776ec71
View file https://github.com/luchua-bc/ql/blob/0779aab28fe1baa0db8a70862e932a7a05e2a670/java/ql/src/experimental/Security/CWE/CWE-273/UnsafeCertTrust.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3550/{{ revealButtonHref }}
java/ql/src/experimental/Security/CWE/CWE-273/UnsafeCertTrust.qhelphttps://github.com/github/codeql/pull/3550/files#diff-0b30e0f46fb9b453edfc8b85aa118489ac41cdaf26084ba7fe182bf49ea9fca7
View file https://github.com/luchua-bc/ql/blob/0779aab28fe1baa0db8a70862e932a7a05e2a670/java/ql/src/experimental/Security/CWE/CWE-273/UnsafeCertTrust.qhelp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3550/{{ revealButtonHref }}
java/ql/src/experimental/Security/CWE/CWE-273/UnsafeCertTrust.qlhttps://github.com/github/codeql/pull/3550/files#diff-0831fd5750f3ff67152a34c554e1f7c5cbf12a17d64fc1ffb3d842a292685cea
View file https://github.com/luchua-bc/ql/blob/0779aab28fe1baa0db8a70862e932a7a05e2a670/java/ql/src/experimental/Security/CWE/CWE-273/UnsafeCertTrust.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3550/{{ revealButtonHref }}
Please reload this pagehttps://github.com/github/codeql/pull/3550/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.