René's URL Explorer Experiment


Title: Python : Add support for detecting XSLT Injection · Pull Request #3521 · github/codeql · GitHub

Open Graph Title: Python : Add support for detecting XSLT Injection · Pull Request #3521 · github/codeql

X Title: Python : Add support for detecting XSLT Injection · Pull Request #3521 · github/codeql

Description: This PR adds support for detecting XSLT injection in Python. I have included the ql files as well as the tests with this. However, I haven't included included the *.expected files as lxml is not stubbed into master yet. If someone could run depstubber and push the stubs, I would be able to complete my work. cc: @RasmusWL @tausbn

Open Graph Description: This PR adds support for detecting XSLT injection in Python. I have included the ql files as well as the tests with this. However, I haven't included included the *.expected files as lxml is no...

X Description: This PR adds support for detecting XSLT injection in Python. I have included the ql files as well as the tests with this. However, I haven't included included the *.expected files as lxml i...

Opengraph URL: https://github.com/github/codeql/pull/3521

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:41b526eb-6069-32f4-b79a-f77bc3fb3eb4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEAE:34D244:22F5875:305AF54:6A4F527C
html-safe-noncee32a508f153ee0f6ec29ec0bdd65e847c3e30477e28c1b6c28b4d8745e5a6694
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUFFOjM0RDI0NDoyMkY1ODc1OjMwNUFGNTQ6NkE0RjUyN0MiLCJ2aXNpdG9yX2lkIjoiODUzODEwNTc2NzQyODgzODAxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9d6d9d857112d448dcc1d51ff6ebd32aa8b6043c8193c88ee9f7e8bc16e83f6d
hovercard-subject-tagpull_request:420366047
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/3521/files
twitter:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
og:image:altThis PR adds support for detecting XSLT injection in Python. I have included the ql files as well as the tests with this. However, I haven't included included the *.expected files as lxml is no...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/3521/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3521%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3521%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/3521/files
Reloadhttps://github.com/github/codeql/pull/3521/files
Reloadhttps://github.com/github/codeql/pull/3521/files
Please reload this pagehttps://github.com/github/codeql/pull/3521/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 986 https://github.com/github/codeql/issues
Pull requests 423 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
ghosthttps://github.com/ghost
github:masterhttps://github.com/github/codeql/tree/master
Conversation 15 https://github.com/github/codeql/pull/3521
Findings https://github.com/github/codeql/pull/3521/findings
Commits 4 https://github.com/github/codeql/pull/3521/commits
Checks 0 https://github.com/github/codeql/pull/3521/checks
Files changed https://github.com/github/codeql/pull/3521/files
Please reload this pagehttps://github.com/github/codeql/pull/3521/files
Python : Add support for detecting XSLT Injection https://github.com/github/codeql/pull/3521/files#top
Show all changes 4 commits https://github.com/github/codeql/pull/3521/files
1ceb963 Python : Add support for detecting XSLT Injection May 19, 2020 https://github.com/github/codeql/pull/3521/commits/1ceb963d4c11c4cbabf3a9e621afd74f011158a7
6dd9106 Update XSLT.qll Jun 7, 2020 https://github.com/github/codeql/pull/3521/commits/6dd9106301dcb23b6c7d3ed62e78d2819c548f21
33a9fb6 Python: Reorder XSLT qhelp to be valid RasmusWL Jun 11, 2020 https://github.com/github/codeql/pull/3521/commits/33a9fb6034b3a58bc273abe926d5f30d9667d12b
a24974b Python: Add missing

to qhelp RasmusWL Jun 11, 2020

https://github.com/github/codeql/pull/3521/commits/a24974b1946ab8e1ed72b02622f460b51d988173
Clear filters https://github.com/github/codeql/pull/3521/files
Please reload this pagehttps://github.com/github/codeql/pull/3521/files
Please reload this pagehttps://github.com/github/codeql/pull/3521/files
Xslt.qhelp https://github.com/github/codeql/pull/3521/files#diff-610ccd6ff0a796203b0c827e4181bb8ec4e4f06184e30f86c3192bf59a27c171
Xslt.ql https://github.com/github/codeql/pull/3521/files#diff-74810da71f79c68eb6873bd13987d34638ca00a228222bd57f27899ed1cbbf0a
xslt.py https://github.com/github/codeql/pull/3521/files#diff-098a28b2379655678481cd96e240c3e85be3d47a98f342ac135d4372553147e0
XSLT.qll https://github.com/github/codeql/pull/3521/files#diff-8a0a4a0e181e10ed5147965f4da409ec6d863f0b99f585ff113b89a75d678b67
Xslt.expected https://github.com/github/codeql/pull/3521/files#diff-c97d8d49b3bc04284785983cccfbd116318fca0f8a9b80c2dc0f745466bb41d4
Xslt.qlref https://github.com/github/codeql/pull/3521/files#diff-554341355b1cf21407ed4253b5c999f40f9a07f0fb4e8522a522ab40fc7e45c8
XsltSinks.expected https://github.com/github/codeql/pull/3521/files#diff-b852c93446783ff65a14df4628034a086df9a8495921e2d534eedc67021773a1
XsltSinks.ql https://github.com/github/codeql/pull/3521/files#diff-022a6a7fbe5ad685ef5aa39581f118cd026c5590748f1fedb472fdc31035fdc1
options https://github.com/github/codeql/pull/3521/files#diff-e6e373e9521694a478ecba4e08844829fea382ffc405a9b02a9fe17cbeadd292
xslt.py https://github.com/github/codeql/pull/3521/files#diff-d44a90bbbbdead400e3cf1974fcdb0dc9f26bb8097b53821de4f210b2ae1e5ed
xsltInjection.py https://github.com/github/codeql/pull/3521/files#diff-11754cc7a89cb7b3040fe28302c269dfe2b87611a4968d2d4b2daf7fdc5a546f
xsltSinks.py https://github.com/github/codeql/pull/3521/files#diff-756b2aff360f2792811ee7062ff69dd89508c102a3e3d7dd9cba772f24ddf1fe
__init__.py https://github.com/github/codeql/pull/3521/files#diff-32eee93d6cee0500fb672735c7b69b5aac7f7d9e4f91f26fecd911da4f5b4ffd
etree.py https://github.com/github/codeql/pull/3521/files#diff-5a66849bf8b7efb0ea581721ef72241a25ad5f14570aa60b68de5e8294da0244
python/ql/src/experimental/CWE-643/Xslt.qhelphttps://github.com/github/codeql/pull/3521/files#diff-610ccd6ff0a796203b0c827e4181bb8ec4e4f06184e30f86c3192bf59a27c171
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/src/experimental/CWE-643/Xslt.qhelp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/src/experimental/CWE-643/Xslt.qlhttps://github.com/github/codeql/pull/3521/files#diff-74810da71f79c68eb6873bd13987d34638ca00a228222bd57f27899ed1cbbf0a
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/src/experimental/CWE-643/Xslt.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/src/experimental/CWE-643/xslt.pyhttps://github.com/github/codeql/pull/3521/files#diff-098a28b2379655678481cd96e240c3e85be3d47a98f342ac135d4372553147e0
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/src/experimental/CWE-643/xslt.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/src/experimental/semmle/python/security/injection/XSLT.qllhttps://github.com/github/codeql/pull/3521/files#diff-8a0a4a0e181e10ed5147965f4da409ec6d863f0b99f585ff113b89a75d678b67
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/src/experimental/semmle/python/security/injection/XSLT.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
RasmusWLhttps://github.com/RasmusWL
Jun 12, 2020https://github.com/github/codeql/pull/3521/files#r439385514
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github/codeql/pull/3521/files
python/ql/test/experimental/CWE-074/Xslt.expectedhttps://github.com/github/codeql/pull/3521/files#diff-c97d8d49b3bc04284785983cccfbd116318fca0f8a9b80c2dc0f745466bb41d4
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/test/experimental/CWE-074/Xslt.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/test/experimental/CWE-074/Xslt.qlrefhttps://github.com/github/codeql/pull/3521/files#diff-554341355b1cf21407ed4253b5c999f40f9a07f0fb4e8522a522ab40fc7e45c8
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/test/experimental/CWE-074/Xslt.qlref
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/test/experimental/CWE-074/XsltSinks.expectedhttps://github.com/github/codeql/pull/3521/files#diff-b852c93446783ff65a14df4628034a086df9a8495921e2d534eedc67021773a1
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/test/experimental/CWE-074/XsltSinks.expected
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/test/experimental/CWE-074/XsltSinks.qlhttps://github.com/github/codeql/pull/3521/files#diff-022a6a7fbe5ad685ef5aa39581f118cd026c5590748f1fedb472fdc31035fdc1
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/test/experimental/CWE-074/XsltSinks.ql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/test/experimental/CWE-074/optionshttps://github.com/github/codeql/pull/3521/files#diff-e6e373e9521694a478ecba4e08844829fea382ffc405a9b02a9fe17cbeadd292
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/test/experimental/CWE-074/options
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/test/experimental/CWE-074/xslt.pyhttps://github.com/github/codeql/pull/3521/files#diff-d44a90bbbbdead400e3cf1974fcdb0dc9f26bb8097b53821de4f210b2ae1e5ed
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/test/experimental/CWE-074/xslt.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
python/ql/test/experimental/CWE-074/xsltInjection.pyhttps://github.com/github/codeql/pull/3521/files#diff-11754cc7a89cb7b3040fe28302c269dfe2b87611a4968d2d4b2daf7fdc5a546f
View file https://github.com/github/codeql/blob/a24974b1946ab8e1ed72b02622f460b51d988173/python/ql/test/experimental/CWE-074/xsltInjection.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3521/{{ revealButtonHref }}
Please reload this pagehttps://github.com/github/codeql/pull/3521/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.