René's URL Explorer Experiment


Title: Fixes FPs in SpringBootActuators query by ggolawski · Pull Request #3506 · github/codeql · GitHub

Open Graph Title: Fixes FPs in SpringBootActuators query by ggolawski · Pull Request #3506 · github/codeql

X Title: Fixes FPs in SpringBootActuators query by ggolawski · Pull Request #3506 · github/codeql

Description: This PR fixes FPs in SpringBootActuators query, as pointed out in #2901 (comment). No evidence that Spring Actuators are being used, e.g. http.authorizeRequests().anyRequest().permitAll() --> The query now makes sure that the permitAll() refers to Spring Actuators (EndpointRequest) Only safe Actuators are enabled, e.g. EndpointRequest.to("health", "info") --> The query now raises the flag only if EndpointRequest.toAnyEndpoint() is being used. More tests to handle the above cases are added.

Open Graph Description: This PR fixes FPs in SpringBootActuators query, as pointed out in #2901 (comment). No evidence that Spring Actuators are being used, e.g. http.authorizeRequests().anyRequest().permitAll() --> T...

X Description: This PR fixes FPs in SpringBootActuators query, as pointed out in #2901 (comment). No evidence that Spring Actuators are being used, e.g. http.authorizeRequests().anyRequest().permitAll() --&g...

Opengraph URL: https://github.com/github/codeql/pull/3506

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a24affe8-14a1-dcd7-8f0e-c4918e112a6a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1BA:35EA72:164C4B2:1ECD10D:6A4DF195
html-safe-noncedc62f2afde9ed61c93e7588f2f7dedc5bd56fc9d01f677690b795a10d610c3ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUJBOjM1RUE3MjoxNjRDNEIyOjFFQ0QxMEQ6NkE0REYxOTUiLCJ2aXNpdG9yX2lkIjoiOTE2MTczNjEzMTIwNDQ3NzMzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace1de05ef1d81c960bf92fc0a3f79413fdc535dad75b63b2a6aea1d15dbf02153
hovercard-subject-tagpull_request:419744391
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/3506/files
twitter:imagehttps://avatars.githubusercontent.com/u/35563296?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35563296?s=400&v=4
og:image:altThis PR fixes FPs in SpringBootActuators query, as pointed out in #2901 (comment). No evidence that Spring Actuators are being used, e.g. http.authorizeRequests().anyRequest().permitAll() --> T...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/3506/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3506%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F3506%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/3506/files
Reloadhttps://github.com/github/codeql/pull/3506/files
Reloadhttps://github.com/github/codeql/pull/3506/files
Please reload this pagehttps://github.com/github/codeql/pull/3506/files
github https://github.com/github
codeqlhttps://github.com/github/codeql
Notifications https://github.com/login?return_to=%2Fgithub%2Fcodeql
Fork 2k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Star 9.8k https://github.com/login?return_to=%2Fgithub%2Fcodeql
Code https://github.com/github/codeql
Issues 987 https://github.com/github/codeql/issues
Pull requests 426 https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality 0 https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Code https://github.com/github/codeql
Issues https://github.com/github/codeql/issues
Pull requests https://github.com/github/codeql/pulls
Discussions https://github.com/github/codeql/discussions
Actions https://github.com/github/codeql/actions
Projects https://github.com/github/codeql/projects
Models https://github.com/github/codeql/models
Security and quality https://github.com/github/codeql/security
Insights https://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
aschackmullhttps://github.com/aschackmull
github:masterhttps://github.com/github/codeql/tree/master
ggolawski:spring-actuators-fixhttps://github.com/ggolawski/ql/tree/spring-actuators-fix
Conversation 0 https://github.com/github/codeql/pull/3506
Findings https://github.com/github/codeql/pull/3506/findings
Commits 1 https://github.com/github/codeql/pull/3506/commits
Checks 0 https://github.com/github/codeql/pull/3506/checks
Files changed https://github.com/github/codeql/pull/3506/files
Please reload this pagehttps://github.com/github/codeql/pull/3506/files
Fixes FPs in SpringBootActuators query https://github.com/github/codeql/pull/3506/files#top
Show all changes 1 commit https://github.com/github/codeql/pull/3506/files
ac329e8 Fixes FPs in SpringBootActuators query ggolawski May 18, 2020 https://github.com/github/codeql/pull/3506/commits/ac329e81f84234fcaabcc1875935a7450b7f3dc6
Clear filters https://github.com/github/codeql/pull/3506/files
Please reload this pagehttps://github.com/github/codeql/pull/3506/files
Please reload this pagehttps://github.com/github/codeql/pull/3506/files
SpringBootActuators.qll https://github.com/github/codeql/pull/3506/files#diff-e39acdadbf9baa58ba5f020ad24c6820bfbf5e04afa2592ba10380b72e1ea646
SpringBootActuators.java https://github.com/github/codeql/pull/3506/files#diff-5db47233e3f137f5041b7afb8daba976dae834e8d69087821e6ee06b489a1c86
EndpointRequest.java https://github.com/github/codeql/pull/3506/files#diff-98c3f1aaa0605008d88c07d8df508c4264bbccb41f73c3a8e1bac3e1bd655c19
java/ql/src/experimental/Security/CWE/CWE-016/SpringBootActuators.qllhttps://github.com/github/codeql/pull/3506/files#diff-e39acdadbf9baa58ba5f020ad24c6820bfbf5e04afa2592ba10380b72e1ea646
View file https://github.com/ggolawski/ql/blob/ac329e81f84234fcaabcc1875935a7450b7f3dc6/java/ql/src/experimental/Security/CWE/CWE-016/SpringBootActuators.qll
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3506/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3506/files#diff-e39acdadbf9baa58ba5f020ad24c6820bfbf5e04afa2592ba10380b72e1ea646
https://github.com/github/codeql/pull/3506/files#diff-e39acdadbf9baa58ba5f020ad24c6820bfbf5e04afa2592ba10380b72e1ea646
https://github.com/github/codeql/pull/3506/files#diff-e39acdadbf9baa58ba5f020ad24c6820bfbf5e04afa2592ba10380b72e1ea646
https://github.com/github/codeql/pull/3506/files#diff-e39acdadbf9baa58ba5f020ad24c6820bfbf5e04afa2592ba10380b72e1ea646
https://github.com/github/codeql/pull/3506/files#diff-e39acdadbf9baa58ba5f020ad24c6820bfbf5e04afa2592ba10380b72e1ea646
java/ql/test/experimental/query-tests/security/CWE-016/SpringBootActuators.javahttps://github.com/github/codeql/pull/3506/files#diff-5db47233e3f137f5041b7afb8daba976dae834e8d69087821e6ee06b489a1c86
View file https://github.com/ggolawski/ql/blob/ac329e81f84234fcaabcc1875935a7450b7f3dc6/java/ql/test/experimental/query-tests/security/CWE-016/SpringBootActuators.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3506/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3506/files#diff-5db47233e3f137f5041b7afb8daba976dae834e8d69087821e6ee06b489a1c86
....2.3/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.javahttps://github.com/github/codeql/pull/3506/files#diff-98c3f1aaa0605008d88c07d8df508c4264bbccb41f73c3a8e1bac3e1bd655c19
View file https://github.com/ggolawski/ql/blob/ac329e81f84234fcaabcc1875935a7450b7f3dc6/java/ql/test/experimental/stubs/springframework-5.2.3/org/springframework/boot/actuate/autoconfigure/security/servlet/EndpointRequest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/3506/{{ revealButtonHref }}
https://github.com/github/codeql/pull/3506/files#diff-98c3f1aaa0605008d88c07d8df508c4264bbccb41f73c3a8e1bac3e1bd655c19
https://github.com/github/codeql/pull/3506/files#diff-98c3f1aaa0605008d88c07d8df508c4264bbccb41f73c3a8e1bac3e1bd655c19
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.