René's URL Explorer Experiment


Title: Rust: resolve modules declared in include expansions by hvitved · Pull Request #23113 · github/codeql · GitHub

Open Graph Title: Rust: resolve modules declared in include expansions by hvitved · Pull Request #23113 · github/codeql

X Title: Rust: resolve modules declared in include expansions by hvitved · Pull Request #23113 · github/codeql

Description: CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security - Rust: resolve modules declared in include expansions by hvitved · Pull Request #23113 · github/codeql

Open Graph Description: Summary Preserve source locations in item expansions of include! calls, so module declarations resolve relative to the included file rather than the include invocation. Use rust-analyzer's reso...

X Description: Summary Preserve source locations in item expansions of include! calls, so module declarations resolve relative to the included file rather than the include invocation. Use rust-analyzer's ...

Opengraph URL: https://github.com/github/codeql/pull/23113

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a90d3b65-09f6-eaf9-8129-04b2388bae48
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id916E:3B6BD:E104C1:1365ED8:6AF88D6E
html-safe-nonceb2c33911221d03c3a6c0c2440c3ae9cf846438aa143e27e53b54bae7c51f4d9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTZFOjNCNkJEOkUxMDRDMToxMzY1RUQ4OjZBRjg4RDZFIiwidmlzaXRvcl9pZCI6IjEyNTg0NDM5MzA4MzE3MTk3OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfe34f6381222ba1fb84dd463788c7450e082eea8ec38f5c0df2d20a05ad65f13
hovercard-subject-tagpull_request:5277030543
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github/codeql/23113/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1def9df22b8c237b6ff194a5d2f7d3c904410c563119054d16e52e9bbd9b6d36/github/codeql/pull/23113
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1def9df22b8c237b6ff194a5d2f7d3c904410c563119054d16e52e9bbd9b6d36/github/codeql/pull/23113
og:image:altSummary Preserve source locations in item expansions of include! calls, so module declarations resolve relative to the included file rather than the include invocation. Use rust-analyzer's reso...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehvitved
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/github/codeql/pull/23113#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F23113
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F23113
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/23113
Reloadhttps://github.com/github/codeql/pull/23113
Reloadhttps://github.com/github/codeql/pull/23113
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests516 (516)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/pulse
https://github.com/github/codeql
hvitvedhttps://github.com/hvitved
github:mainhttps://github.com/github/codeql/tree/main
hvitved:hvitved-rust-include-module-pathshttps://github.com/hvitved/codeql/tree/hvitved-rust-include-module-paths
Conversationhttps://github.com/github/codeql/pull/23113
Commits11 (11)https://github.com/github/codeql/pull/23113/commits
Checkshttps://github.com/github/codeql/pull/23113/checks
Findingshttps://github.com/github/codeql/pull/23113/findings
Files changedhttps://github.com/github/codeql/pull/23113/files
Rust: resolve modules declared in include expansionshttps://github.com/github/codeql/pull/23113#top
hvitvedhttps://github.com/hvitved
github:mainhttps://github.com/github/codeql/tree/main
hvitved:hvitved-rust-include-module-pathshttps://github.com/hvitved/codeql/tree/hvitved-rust-include-module-paths
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Nov 12, 2026https://github.com/github/codeql/pull/23113#issue-6349370200
Please reload this pagehttps://github.com/github/codeql/pull/23113
#23009https://github.com/github/codeql/issues/23009
Please reload this pagehttps://github.com/github/codeql/pull/23113
hvitvedhttps://github.com/hvitved
November 5, 2026 12:49https://github.com/github/codeql/pull/23113#commits-pushed-4b7a8da
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Rust: preserve locations in literal include expansionshttps://github.com/github/codeql/pull/23113/commits/4b7a8daedcc53a1e650cec268b015b6e83adaed5
4b7a8dahttps://github.com/github/codeql/pull/23113/commits/4b7a8daedcc53a1e650cec268b015b6e83adaed5
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Rust: use Option::replace for include contexthttps://github.com/github/codeql/pull/23113/commits/ea209d574f780fa7173b3f2abb1fd645ffcce359
ea209d5https://github.com/github/codeql/pull/23113/commits/ea209d574f780fa7173b3f2abb1fd645ffcce359
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Rust https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ARust
Nov 12, 2026https://github.com/github/codeql/pull/23113#event-35910539011
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Rust: update included macro item locationshttps://github.com/github/codeql/pull/23113/commits/47e8dd2d9f994a2deb79da95e15dcfa79cac4347
47e8dd2https://github.com/github/codeql/pull/23113/commits/47e8dd2d9f994a2deb79da95e15dcfa79cac4347
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 08:12https://github.com/github/codeql/pull/23113#event-36006930911
started reviewinghttps://github.com/github/codeql/sessions/c2dd5569-b574-4d62-b6f7-9d5be536fdb9
hvitvedhttps://github.com/hvitved
November 13, 2026 08:13https://github.com/github/codeql/pull/23113#event-36006971018
View session https://github.com/github/codeql/sessions/c2dd5569-b574-4d62-b6f7-9d5be536fdb9
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5888143718
View reviewed changes https://github.com/github/codeql/pull/23113/files/47e8dd2d9f994a2deb79da95e15dcfa79cac4347
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/23113#pullrequestreview-5888143718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Map expansion ranges to the included file's source spanshttps://github.com/github/codeql/pull/23113#discussion_r4561200287
Resolve nested includes relative to the containing filehttps://github.com/github/codeql/pull/23113#discussion_r4561200393
Cache per-file location data during extractionhttps://github.com/github/codeql/pull/23113#discussion_r4561200477
Apply include handling only to the built-in macrohttps://github.com/github/codeql/pull/23113#discussion_r4561200523
Accept valid include! delimiters, comments, and trailing commashttps://github.com/github/codeql/pull/23113#discussion_r4561200570
Include expanded files in crate source-file membershiphttps://github.com/github/codeql/pull/23113#discussion_r4561200634
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/47e8dd2d9f994a2deb79da95e15dcfa79cac4347#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/47e8dd2d9f994a2deb79da95e15dcfa79cac4347#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/47e8dd2d9f994a2deb79da95e15dcfa79cac4347#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/47e8dd2d9f994a2deb79da95e15dcfa79cac4347#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/47e8dd2d9f994a2deb79da95e15dcfa79cac4347#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/47e8dd2d9f994a2deb79da95e15dcfa79cac4347#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Rust: resolve included items through source spanshttps://github.com/github/codeql/pull/23113/commits/3fa6995025157e6b732ca6460df0397241b90972
3fa6995https://github.com/github/codeql/pull/23113/commits/3fa6995025157e6b732ca6460df0397241b90972
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Nov 13, 2026https://github.com/github/codeql/pull/23113#event-36009972622
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Nov 13, 2026https://github.com/github/codeql/pull/23113#event-36010204254
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 09:00https://github.com/github/codeql/pull/23113#event-36010616364
started reviewinghttps://github.com/github/codeql/sessions/a212d501-01fb-453e-91b6-78eb9f11f105
hvitvedhttps://github.com/hvitved
November 13, 2026 09:01https://github.com/github/codeql/pull/23113#event-36010667172
View session https://github.com/github/codeql/sessions/a212d501-01fb-453e-91b6-78eb9f11f105
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5888704163
View reviewed changes https://github.com/github/codeql/pull/23113/files/3fa6995025157e6b732ca6460df0397241b90972
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/23113#pullrequestreview-5888704163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Map nested macro module spans through their invocation sitehttps://github.com/github/codeql/pull/23113#discussion_r4561631736
Archive and classify OUT_DIR include targetshttps://github.com/github/codeql/pull/23113#discussion_r4561631786
Allow explicit includes across crate entry-point boundarieshttps://github.com/github/codeql/pull/23113#discussion_r4561631830
Restrict crate membership to items in the active include expansionhttps://github.com/github/codeql/pull/23113#discussion_r4561631879
Resolve included modules relative to the include file’s directoryhttps://github.com/github/codeql/pull/23113#discussion_r4561631914
Preserve diagnostics for macros in included fileshttps://github.com/github/codeql/pull/23113#discussion_r4561631956
Resolve nested includes relative to the containing filehttps://github.com/github/codeql/pull/23113#discussion_r4561200393
Map expansion ranges to the included file's source spanshttps://github.com/github/codeql/pull/23113#discussion_r4561200287
Include expanded files in crate source-file membershiphttps://github.com/github/codeql/pull/23113#discussion_r4561200634
Accept valid include! delimiters, comments, and trailing commashttps://github.com/github/codeql/pull/23113#discussion_r4561200570
Apply include handling only to the built-in macrohttps://github.com/github/codeql/pull/23113#discussion_r4561200523
Cache per-file location data during extractionhttps://github.com/github/codeql/pull/23113#discussion_r4561200477
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/3fa6995025157e6b732ca6460df0397241b90972#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/3fa6995025157e6b732ca6460df0397241b90972#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/3fa6995025157e6b732ca6460df0397241b90972#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/3fa6995025157e6b732ca6460df0397241b90972#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/3fa6995025157e6b732ca6460df0397241b90972#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/3fa6995025157e6b732ca6460df0397241b90972#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Rust: preserve active scopes and source metadata for includeshttps://github.com/github/codeql/pull/23113/commits/1e316ba406b0846e07cc59242da4ec0c9129aad8
1e316bahttps://github.com/github/codeql/pull/23113/commits/1e316ba406b0846e07cc59242da4ec0c9129aad8
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 09:59https://github.com/github/codeql/pull/23113#event-36015726820
started reviewinghttps://github.com/github/codeql/sessions/11275c4d-fc57-41b8-b000-a4315ce3cc0d
hvitvedhttps://github.com/hvitved
November 13, 2026 10:00https://github.com/github/codeql/pull/23113#event-36015756618
View session https://github.com/github/codeql/sessions/11275c4d-fc57-41b8-b000-a4315ce3cc0d
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5889381861
View reviewed changes https://github.com/github/codeql/pull/23113/files/1e316ba406b0846e07cc59242da4ec0c9129aad8
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/23113#pullrequestreview-5889381861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Schedule generated sibling modules as source inputshttps://github.com/github/codeql/pull/23113#discussion_r4562146066
Distinguish included-only files from compilation-skipped fileshttps://github.com/github/codeql/pull/23113#discussion_r4562146110
Preserve argument spans in macros inside included fileshttps://github.com/github/codeql/pull/23113#discussion_r4562146133
Move include-library outside the parent test input treehttps://github.com/github/codeql/pull/23113#discussion_r4562146172
Resolve included modules relative to the include file’s directoryhttps://github.com/github/codeql/pull/23113#discussion_r4561631914
Restrict crate membership to items in the active include expansionhttps://github.com/github/codeql/pull/23113#discussion_r4561631879
Allow explicit includes across crate entry-point boundarieshttps://github.com/github/codeql/pull/23113#discussion_r4561631830
Archive and classify OUT_DIR include targetshttps://github.com/github/codeql/pull/23113#discussion_r4561631786
Map nested macro module spans through their invocation sitehttps://github.com/github/codeql/pull/23113#discussion_r4561631736
Preserve diagnostics for macros in included fileshttps://github.com/github/codeql/pull/23113#discussion_r4561631956
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/1e316ba406b0846e07cc59242da4ec0c9129aad8#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/1e316ba406b0846e07cc59242da4ec0c9129aad8#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/1e316ba406b0846e07cc59242da4ec0c9129aad8#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/test/library-tests/path-resolution/include-library/main.rshttps://github.com/github/codeql/pull/23113/files/1e316ba406b0846e07cc59242da4ec0c9129aad8#diff-559d31ee8f445e1f2d523e01491f5a8ebff802f747c1e5852528c946e956e585
Please reload this pagehttps://github.com/github/codeql/pull/23113
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Rust: extract generated include modules and preserve argument spanshttps://github.com/github/codeql/pull/23113/commits/327743601f4a7b9822cd0671c42e8713de3d816d
3277436https://github.com/github/codeql/pull/23113/commits/327743601f4a7b9822cd0671c42e8713de3d816d
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 10:47https://github.com/github/codeql/pull/23113#event-36019290877
started reviewinghttps://github.com/github/codeql/sessions/25337143-b6c7-4339-b73d-85157a719480
hvitvedhttps://github.com/hvitved
November 13, 2026 10:48https://github.com/github/codeql/pull/23113#event-36019324785
View session https://github.com/github/codeql/sessions/25337143-b6c7-4339-b73d-85157a719480
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5889877817
View reviewed changes https://github.com/github/codeql/pull/23113/files/327743601f4a7b9822cd0671c42e8713de3d816d
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/23113#pullrequestreview-5889877817
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Recursive and included files bypass source exclusionshttps://github.com/github/codeql/pull/23113#discussion_r4562533924
Dependency fallback overwrites preferred-workspace extractionhttps://github.com/github/codeql/pull/23113#discussion_r4562533964
Included macro definitions use incorrect expansion orderhttps://github.com/github/codeql/pull/23113#discussion_r4562534007
Include-target initializers lack a control-flow scopehttps://github.com/github/codeql/pull/23113#discussion_r4562534047
Source deduplication persists across manifest changeshttps://github.com/github/codeql/pull/23113#discussion_r4562534079
Inactive standalone ASTs inflate missing-expansion statisticshttps://github.com/github/codeql/pull/23113#discussion_r4562534130
Distinguish included-only files from compilation-skipped fileshttps://github.com/github/codeql/pull/23113#discussion_r4562146110
Schedule generated sibling modules as source inputshttps://github.com/github/codeql/pull/23113#discussion_r4562146066
Move include-library outside the parent test input treehttps://github.com/github/codeql/pull/23113#discussion_r4562146172
Preserve argument spans in macros inside included fileshttps://github.com/github/codeql/pull/23113#discussion_r4562146133
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/327743601f4a7b9822cd0671c42e8713de3d816d#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/327743601f4a7b9822cd0671c42e8713de3d816d#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/327743601f4a7b9822cd0671c42e8713de3d816d#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/translate/base.rshttps://github.com/github/codeql/pull/23113/files/327743601f4a7b9822cd0671c42e8713de3d816d#diff-0df0ebedd46026de601ea75d88c8e156ef7c484a364184d279e68cd58a78c6cc
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/327743601f4a7b9822cd0671c42e8713de3d816d#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/files/FileSystem.qllhttps://github.com/github/codeql/pull/23113/files/327743601f4a7b9822cd0671c42e8713de3d816d#diff-4383418fb25d70804dd0aa45181727681d3104c94e07451f6070b5ad9f310a7a
Please reload this pagehttps://github.com/github/codeql/pull/23113
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Fix include extraction review issueshttps://github.com/github/codeql/pull/23113/commits/f1c0b0331b68362331b5375158eff50496ee408b
f1c0b03https://github.com/github/codeql/pull/23113/commits/f1c0b0331b68362331b5375158eff50496ee408b
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 11:41https://github.com/github/codeql/pull/23113#event-36023468822
started reviewinghttps://github.com/github/codeql/sessions/7b0933d6-33cd-4bee-a8b9-68f6157f1651
hvitvedhttps://github.com/hvitved
November 13, 2026 11:41https://github.com/github/codeql/pull/23113#event-36023505788
View session https://github.com/github/codeql/sessions/7b0933d6-33cd-4bee-a8b9-68f6157f1651
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5890580972
View reviewed changes https://github.com/github/codeql/pull/23113/files/f1c0b0331b68362331b5375158eff50496ee408b
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/23113#pullrequestreview-5890580972
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Archive valid include targets omitted by Rust input discoveryhttps://github.com/github/codeql/pull/23113#discussion_r4562991854
Apply path exclusions to source classification stepshttps://github.com/github/codeql/pull/23113#discussion_r4562991914
Preserve nested include order when resolving shadowed macroshttps://github.com/github/codeql/pull/23113#discussion_r4562991959
Avoid re-extracting explicitly selected module fileshttps://github.com/github/codeql/pull/23113#discussion_r4562991992
Restrict include filtering to inactive standalone file copieshttps://github.com/github/codeql/pull/23113#discussion_r4562992038
Assess downstream alert changes with DCA resultshttps://github.com/github/codeql/pull/23113#discussion_r4562992071
Include-target initializers lack a control-flow scopehttps://github.com/github/codeql/pull/23113#discussion_r4562534047
Included macro definitions use incorrect expansion orderhttps://github.com/github/codeql/pull/23113#discussion_r4562534007
Dependency fallback overwrites preferred-workspace extractionhttps://github.com/github/codeql/pull/23113#discussion_r4562533964
Recursive and included files bypass source exclusionshttps://github.com/github/codeql/pull/23113#discussion_r4562533924
Inactive standalone ASTs inflate missing-expansion statisticshttps://github.com/github/codeql/pull/23113#discussion_r4562534130
Source deduplication persists across manifest changeshttps://github.com/github/codeql/pull/23113#discussion_r4562534079
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/f1c0b0331b68362331b5375158eff50496ee408b#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/f1c0b0331b68362331b5375158eff50496ee408b#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/f1c0b0331b68362331b5375158eff50496ee408b#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/f1c0b0331b68362331b5375158eff50496ee408b#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/src/queries/telemetry/DatabaseQuality.qllhttps://github.com/github/codeql/pull/23113/files/f1c0b0331b68362331b5375158eff50496ee408b#diff-f47064fb8709c45a5c1c9abdd0706747bbc87c14f1d7c630669229049bb68a2c
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/f1c0b0331b68362331b5375158eff50496ee408b#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
Please reload this pagehttps://github.com/github/codeql/pull/23113
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Address Rust include review feedbackhttps://github.com/github/codeql/pull/23113/commits/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b
51c7d1ehttps://github.com/github/codeql/pull/23113/commits/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b
https://github.com/apps/github-advanced-security
github-advanced-securityhttps://github.com/apps/github-advanced-security
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5891230959
View reviewed changes https://github.com/github/codeql/pull/23113/files/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b
rust/ql/src/queries/telemetry/DatabaseQuality.qllhttps://github.com/github/codeql/pull/23113/files/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b#diff-f47064fb8709c45a5c1c9abdd0706747bbc87c14f1d7c630669229049bb68a2c
Please reload this pagehttps://github.com/github/codeql/pull/23113
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 12:52https://github.com/github/codeql/pull/23113#event-36029202690
started reviewinghttps://github.com/github/codeql/sessions/996d51ec-7a8e-4da5-a28b-eb2331de123b
hvitvedhttps://github.com/hvitved
November 13, 2026 12:52https://github.com/github/codeql/pull/23113#event-36029234649
View session https://github.com/github/codeql/sessions/996d51ec-7a8e-4da5-a28b-eb2331de123b
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5891592472
View reviewed changes https://github.com/github/codeql/pull/23113/files/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/23113#pullrequestreview-5891592472
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Compare full include-position chains when ordering definitionshttps://github.com/github/codeql/pull/23113#discussion_r4563681865
Retain extensionless include targetshttps://github.com/github/codeql/pull/23113#discussion_r4563681979
Apply path exclusions to non-Rust include targetshttps://github.com/github/codeql/pull/23113#discussion_r4563682027
Keep standalone extraction active when a file is also includedhttps://github.com/github/codeql/pull/23113#discussion_r4563682119
Preserve nested include order when resolving shadowed macroshttps://github.com/github/codeql/pull/23113#discussion_r4562991959
Apply path exclusions to source classification stepshttps://github.com/github/codeql/pull/23113#discussion_r4562991914
Archive valid include targets omitted by Rust input discoveryhttps://github.com/github/codeql/pull/23113#discussion_r4562991854
Restrict include filtering to inactive standalone file copieshttps://github.com/github/codeql/pull/23113#discussion_r4562992038
Avoid re-extracting explicitly selected module fileshttps://github.com/github/codeql/pull/23113#discussion_r4562991992
Assess downstream alert changes with DCA resultshttps://github.com/github/codeql/pull/23113#discussion_r4562992071
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/src/queries/telemetry/DatabaseQuality.qllhttps://github.com/github/codeql/pull/23113/files/51c7d1e0118890c61e4c87b8fc1fa83ff453fd2b#diff-f47064fb8709c45a5c1c9abdd0706747bbc87c14f1d7c630669229049bb68a2c
Please reload this pagehttps://github.com/github/codeql/pull/23113
hvitvedhttps://github.com/hvitved
November 13, 2026 15:44https://github.com/github/codeql/pull/23113#commits-pushed-7c3aee7
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Fix Rust include review feedbackhttps://github.com/github/codeql/pull/23113/commits/7c3aee74c1e3e0d6e6f80877d013b4ef9a333cca
7c3aee7https://github.com/github/codeql/pull/23113/commits/7c3aee74c1e3e0d6e6f80877d013b4ef9a333cca
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Remove generated QL test lockfilehttps://github.com/github/codeql/pull/23113/commits/3294bbb937254cc1a431cc777cae8d283b9eb599
3294bbbhttps://github.com/github/codeql/pull/23113/commits/3294bbb937254cc1a431cc777cae8d283b9eb599
https://github.com/apps/github-advanced-security
github-advanced-securityhttps://github.com/apps/github-advanced-security
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5893060742
View reviewed changes https://github.com/github/codeql/pull/23113/files/3294bbb937254cc1a431cc777cae8d283b9eb599
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/3294bbb937254cc1a431cc777cae8d283b9eb599#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
https://github.com/hvitved
https://github.com/apps/github-copilot-cli
Format Rust include path resolution queryhttps://github.com/github/codeql/pull/23113/commits/c4214ca7bbcd798e5a24d615146a295f52a157bc
c4214cahttps://github.com/github/codeql/pull/23113/commits/c4214ca7bbcd798e5a24d615146a295f52a157bc
https://github.com/hvitved
hvitvedhttps://github.com/hvitved
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 14:50https://github.com/github/codeql/pull/23113#event-36040355279
started reviewinghttps://github.com/github/codeql/sessions/9585403d-1804-4065-8271-5bf6b9754677
hvitvedhttps://github.com/hvitved
November 13, 2026 14:51https://github.com/github/codeql/pull/23113#event-36040407197
View session https://github.com/github/codeql/sessions/9585403d-1804-4065-8271-5bf6b9754677
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/github/codeql/pull/23113#pullrequestreview-5893431174
View reviewed changes https://github.com/github/codeql/pull/23113/files/c4214ca7bbcd798e5a24d615146a295f52a157bc
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/github/codeql/pull/23113#pullrequestreview-5893431174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Restrict cached location keys to relevant AST nodeshttps://github.com/github/codeql/pull/23113#discussion_r4564992151
Apply path exclusions to the included targethttps://github.com/github/codeql/pull/23113#discussion_r4564992211
Avoid applying project exclusions to dependency includeshttps://github.com/github/codeql/pull/23113#discussion_r4564992268
Preserve library-only files in macro-call statisticshttps://github.com/github/codeql/pull/23113#discussion_r4564992319
Compare full include-position chains when ordering definitionshttps://github.com/github/codeql/pull/23113#discussion_r4563681865
Keep standalone extraction active when a file is also includedhttps://github.com/github/codeql/pull/23113#discussion_r4563682119
Apply path exclusions to non-Rust include targetshttps://github.com/github/codeql/pull/23113#discussion_r4563682027
Retain extensionless include targetshttps://github.com/github/codeql/pull/23113#discussion_r4563681979
Please reload this pagehttps://github.com/github/codeql/pull/23113
rust/ql/lib/codeql/rust/internal/PathResolution.qllhttps://github.com/github/codeql/pull/23113/files/c4214ca7bbcd798e5a24d615146a295f52a157bc#diff-4c64a2645bfc19b90f9b2e60b92e1eb1a11b0844369bdc81b2b06d5ac0cc0008
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/c4214ca7bbcd798e5a24d615146a295f52a157bc#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
rust/extractor/src/main.rshttps://github.com/github/codeql/pull/23113/files/c4214ca7bbcd798e5a24d615146a295f52a157bc#diff-8dc8363b641c4b2278c33aaecc9ac95435461195138a61ac58a4aab9caa9c38e
rust/ql/src/queries/telemetry/DatabaseQuality.qllhttps://github.com/github/codeql/pull/23113/files/c4214ca7bbcd798e5a24d615146a295f52a157bc#diff-f47064fb8709c45a5c1c9abdd0706747bbc87c14f1d7c630669229049bb68a2c
https://github.co/hiddenchars
https://github.com/github/codeql/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F23113
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/github/codeql/pull/23113/files/c4214ca7bbcd798e5a24d615146a295f52a157bc
https://github.com/apps/github-advanced-security
github-advanced-security[bot] https://github.com/apps/github-advanced-security
https://github.com/github/codeql/pull/23113/files/3294bbb937254cc1a431cc777cae8d283b9eb599
Please reload this pagehttps://github.com/github/codeql/pull/23113
documentation https://github.com/github/codeql/issues?q=state%3Aopen%20label%3Adocumentation
Rust https://github.com/github/codeql/issues?q=state%3Aopen%20label%3ARust
Rust: modules declared in a file brought in by include! are not resolved (no canonical paths, unresolved calls), e.g. in windows-sys and windows https://github.com/github/codeql/issues/23009
Please reload this pagehttps://github.com/github/codeql/pull/23113
https://github.com/hvitved
https://github.com/apps/github-advanced-security
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.