René's URL Explorer Experiment


Title: Expand Rust workspace and add shared Clippy configuration by paldepind · Pull Request #23053 · github/codeql · GitHub

Open Graph Title: Expand Rust workspace and add shared Clippy configuration by paldepind · Pull Request #23053 · github/codeql

X Title: Expand Rust workspace and add shared Clippy configuration by paldepind · Pull Request #23053 · github/codeql

Description: The goal of this PR is to have one Clippy configuration that is shared across all of our Rust code. The standard Clippy way of doing this is to configure Clippy in a workspace Cargo.toml and let that config be inherited. We already have a workspace in the repo root, but it doesn't include all of our Rust code. This PR: Expands the root Rust workspace to include all Rust projects except the Python extractor. The Python extractor can not be included since it links with an old tree-sitter library, and libraries that are linked against must be off the same version. Adds a Clippy configuration to the root Cargo.toml. For now I've just added two non-default rules, but we can (and I intent to) add more later. Removes the custom Clippy setup for the C/C++ BMN extractor. Carries out a bunch of setup and configuration tweaks needed by the above changes. Fixes lint errors that where found by the expanded configuration. This PR does not change how much linting we do during CI and not all Rust code is currently being linted by CI. We could improve on this, for instance by having one workflow that triggers on all Rust changes and lints the relevant Rust packages. However, I think that is out of this PRs scope.

Open Graph Description: The goal of this PR is to have one Clippy configuration that is shared across all of our Rust code. The standard Clippy way of doing this is to configure Clippy in a workspace Cargo.toml and let th...

X Description: The goal of this PR is to have one Clippy configuration that is shared across all of our Rust code. The standard Clippy way of doing this is to configure Clippy in a workspace Cargo.toml and let th...

Opengraph URL: https://github.com/github/codeql/pull/23053

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b78efa79-a497-0fd1-8729-61be59da4812
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E42:C2F12:456064:5FAB3E:6AF89181
html-safe-nonce551b121d31915ef3870c38e8adec565f722f38991314f57984871a8d65eef199
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTQyOkMyRjEyOjQ1NjA2NDo1RkFCM0U6NkFGODkxODEiLCJ2aXNpdG9yX2lkIjoiMjQ2NjUwNjgxOTc0NDg2MjU5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2f6feabb0e253f0321afb5623b5c3ba19e7bb1eef5a92f37cb7a88d61f316d0f
hovercard-subject-tagpull_request:5222923414
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github/codeql/pull/23053/files
twitter:imagehttps://avatars.githubusercontent.com/u/521604?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/521604?s=400&v=4
og:image:altThe goal of this PR is to have one Clippy configuration that is shared across all of our Rust code. The standard Clippy way of doing this is to configure Clippy in a workspace Cargo.toml and let th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github/codeql git https://github.com/github/codeql.git
octolytics-dimension-user_id9919
octolytics-dimension-user_logingithub
octolytics-dimension-repository_id143040428
octolytics-dimension-repository_nwogithub/codeql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143040428
octolytics-dimension-repository_network_root_nwogithub/codeql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github/codeql/pull/23053/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F23053%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fpull%2F23053%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github%2Fcodeql
Reloadhttps://github.com/github/codeql/pull/23053/files
Reloadhttps://github.com/github/codeql/pull/23053/files
Reloadhttps://github.com/github/codeql/pull/23053/files
githubhttps://github.com/github
codeqlhttps://github.com/github/codeql
Codehttps://github.com/github/codeql
Issues1k (1k)https://github.com/github/codeql/issues
Pull requests516 (516)https://github.com/github/codeql/pulls
Discussionshttps://github.com/github/codeql/discussions
Actionshttps://github.com/github/codeql/actions
Projectshttps://github.com/github/codeql/projects
Security and qualityhttps://github.com/github/codeql/security
Insightshttps://github.com/github/codeql/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgithub%2Fcodeql%2Fissues%2Fnew%2Fchoose
paldepindhttps://github.com/paldepind
mainhttps://github.com/github/codeql/tree/main
rust/linthttps://github.com/github/codeql/tree/rust/lint
Conversation 16 https://github.com/github/codeql/pull/23053
Commits 11 https://github.com/github/codeql/pull/23053/commits
Checks 31 https://github.com/github/codeql/pull/23053/checks
Findings https://github.com/github/codeql/pull/23053/findings
Files changed https://github.com/github/codeql/pull/23053/files
Please reload this pagehttps://github.com/github/codeql/pull/23053/files
Expand Rust workspace and add shared Clippy configuration https://github.com/github/codeql/pull/23053/files#top
Show all changes 11 commits https://github.com/github/codeql/pull/23053/files
df49c8c Expand root Cargo workspace and add inherited Clippy config paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/df49c8c90c8553b21615c164438ae979afb37924
34101e9 Adapt Bazel configuration to the Rust workspace changes paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/34101e975a1e671c96783c7092cc156dbd94eb13
0da5ec1 Regenerate vendored Rust dependencies paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/0da5ec10c44506e7316ce8e4808c4d1ef4e6eda6
6f3e9d6 C++: Delete lint script paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/6f3e9d62aaeccf38910aa991e0b877e937f8015c
0906d25 Adapt paths to workspace changes paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/0906d25b12985836f6bee21e3eb568943cb19449
930b519 Rust: Adapt rust-analyzer update workflow paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/930b51932cde91d8810c8d5964af348ff0c8a61e
ece8a66 Fix Clippy lint errors paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/ece8a66e543c20d99bbab4cffc30477a0aef194d
4a03abc Configure VSCode to run Clippy for all targets paldepind Nov 9, 2026 https://github.com/github/codeql/pull/23053/commits/4a03abcecd0df981e37b0e9c1114fb3262056fca
e5e650a Rename Rust dependency vendoring scripts and related files paldepind Nov 10, 2026 https://github.com/github/codeql/pull/23053/commits/e5e650a484ab12169bd5466e6b3ad4edb1cbc1a4
035b072 Rename generated bazel files paldepind Nov 10, 2026 https://github.com/github/codeql/pull/23053/commits/035b07200fe608d0a48ddb8c8e051e2f4dcbef49
ec6d6e7 Add temporary script to fix reference to renamed script paldepind Nov 10, 2026 https://github.com/github/codeql/pull/23053/commits/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f
Clear filters https://github.com/github/codeql/pull/23053/files
Please reload this pagehttps://github.com/github/codeql/pull/23053/files
Please reload this pagehttps://github.com/github/codeql/pull/23053/files
https://github.com/github/codeql/blob/main/CODEOWNERS#L2
.github/skills/bazel/SKILL.mdhttps://github.com/github/codeql/pull/23053/files#diff-cf6f5dff953a10a4c0c8de1609bf3da8af0ebf219408fa6e3a1e697b2903672f
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/skills/bazel/SKILL.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/23053/{{ revealButtonHref }}
https://github.com/github/codeql/pull/23053/files#diff-cf6f5dff953a10a4c0c8de1609bf3da8af0ebf219408fa6e3a1e697b2903672f
https://github.com/github/codeql/pull/23053/files#diff-cf6f5dff953a10a4c0c8de1609bf3da8af0ebf219408fa6e3a1e697b2903672f
https://github.com/github/codeql/blob/main/CODEOWNERS#L60
.github/workflows/cpp-bmn.ymlhttps://github.com/github/codeql/pull/23053/files#diff-cc299f495a08d8ee87d98e98ab5d5b24c9acf6c320498d64b757c0f433288ca6
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/workflows/cpp-bmn.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/23053/{{ revealButtonHref }}
https://github.com/github/codeql/pull/23053/files#diff-cc299f495a08d8ee87d98e98ab5d5b24c9acf6c320498d64b757c0f433288ca6
https://github.com/github/codeql/pull/23053/files#diff-cc299f495a08d8ee87d98e98ab5d5b24c9acf6c320498d64b757c0f433288ca6
https://github.com/github/codeql/pull/23053/files#diff-cc299f495a08d8ee87d98e98ab5d5b24c9acf6c320498d64b757c0f433288ca6
https://github.com/github/codeql/blob/main/CODEOWNERS#L62
.github/workflows/ql-for-ql-build.ymlhttps://github.com/github/codeql/pull/23053/files#diff-c3c811f2f3a821590acf45fc281ba009b4886ec06d156f573019acf671e2d817
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/workflows/ql-for-ql-build.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/23053/{{ revealButtonHref }}
https://github.com/github/codeql/pull/23053/files#diff-c3c811f2f3a821590acf45fc281ba009b4886ec06d156f573019acf671e2d817
https://github.com/github/codeql/pull/23053/files#diff-c3c811f2f3a821590acf45fc281ba009b4886ec06d156f573019acf671e2d817
https://github.com/github/codeql/pull/23053/files#diff-c3c811f2f3a821590acf45fc281ba009b4886ec06d156f573019acf671e2d817
https://github.com/github/codeql/blob/main/CODEOWNERS#L62
.github/workflows/ql-for-ql-dataset_measure.ymlhttps://github.com/github/codeql/pull/23053/files#diff-21e0d8ff8b280b1cce8085af4934d04610be13cde25165f01c4623c9ad241090
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/workflows/ql-for-ql-dataset_measure.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/23053/{{ revealButtonHref }}
https://github.com/github/codeql/pull/23053/files#diff-21e0d8ff8b280b1cce8085af4934d04610be13cde25165f01c4623c9ad241090
https://github.com/github/codeql/pull/23053/files#diff-21e0d8ff8b280b1cce8085af4934d04610be13cde25165f01c4623c9ad241090
https://github.com/github/codeql/blob/main/CODEOWNERS#L62
.github/workflows/ql-for-ql-tests.ymlhttps://github.com/github/codeql/pull/23053/files#diff-1ebf3f51577da0c7efdf3a28a04889dcf1655452b707d107e6dc75fccc6c4a7d
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/workflows/ql-for-ql-tests.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/23053/{{ revealButtonHref }}
https://github.com/github/codeql/pull/23053/files#diff-1ebf3f51577da0c7efdf3a28a04889dcf1655452b707d107e6dc75fccc6c4a7d
Please reload this pagehttps://github.com/github/codeql/pull/23053/files
https://github.com/github/codeql/pull/23053/files#diff-1ebf3f51577da0c7efdf3a28a04889dcf1655452b707d107e6dc75fccc6c4a7d
https://github.com/github/codeql/pull/23053/files#diff-1ebf3f51577da0c7efdf3a28a04889dcf1655452b707d107e6dc75fccc6c4a7d
https://github.com/github/codeql/pull/23053/files#diff-1ebf3f51577da0c7efdf3a28a04889dcf1655452b707d107e6dc75fccc6c4a7d
https://github.com/github/codeql/pull/23053/files#diff-1ebf3f51577da0c7efdf3a28a04889dcf1655452b707d107e6dc75fccc6c4a7d
https://github.com/github/codeql/blob/main/CODEOWNERS#L64
.github/workflows/rust.ymlhttps://github.com/github/codeql/pull/23053/files#diff-73e17259d77e5fbef83b2bdbbe4dc40a912f807472287f7f45b77e0cbf78792d
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/workflows/rust.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/23053/{{ revealButtonHref }}
https://github.com/github/codeql/pull/23053/files#diff-73e17259d77e5fbef83b2bdbbe4dc40a912f807472287f7f45b77e0cbf78792d
https://github.com/github/codeql/pull/23053/files#diff-73e17259d77e5fbef83b2bdbbe4dc40a912f807472287f7f45b77e0cbf78792d
https://github.com/github/codeql/blob/main/CODEOWNERS#L60
.github/workflows/tree-sitter-extractor-test.ymlhttps://github.com/github/codeql/pull/23053/files#diff-58aafc980ea9dce49aae7b3d4bdf1d00aa7c3b259ecfa87044df37ef0ca56f00
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/workflows/tree-sitter-extractor-test.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github/codeql/pull/23053/{{ revealButtonHref }}
https://github.com/github/codeql/pull/23053/files#diff-58aafc980ea9dce49aae7b3d4bdf1d00aa7c3b259ecfa87044df37ef0ca56f00
https://github.com/github/codeql/pull/23053/files#diff-58aafc980ea9dce49aae7b3d4bdf1d00aa7c3b259ecfa87044df37ef0ca56f00
https://github.com/github/codeql/pull/23053/files#diff-58aafc980ea9dce49aae7b3d4bdf1d00aa7c3b259ecfa87044df37ef0ca56f00
https://github.com/github/codeql/blob/main/CODEOWNERS#L60
.github/workflows/update-rust-analyzer.lock.ymlhttps://github.com/github/codeql/pull/23053/files#diff-555e6a386c0db8f605a44d0d96f74691d9dd1342311c51b54bfda26f51f03663
View file https://github.com/github/codeql/blob/ec6d6e7c4d1a722d5752c32ba3bcd6792dd1958f/.github/workflows/update-rust-analyzer.lock.yml
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/github/codeql/pull/23053/files
Please reload this pagehttps://github.com/github/codeql/pull/23053/files
Please reload this pagehttps://github.com/github/codeql/pull/23053/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.